From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH v2] exec: make de_thread() freezable Date: Thu, 22 Nov 2018 00:35:25 +0100 Message-ID: <2198026.vTmrAJsSTa@aspire.rjw.lan> References: <1541994885-20059-1-git-send-email-chanho.min@lge.com> <20181112081517.GA23178@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20181112081517.GA23178@redhat.com> Sender: linux-kernel-owner@vger.kernel.org To: Oleg Nesterov , Chanho Min Cc: Pavel Machek , Len Brown , Andrew Morton , "Eric W. Biederman" , Christian Brauner , Anna-Maria Gleixner , Alexander Viro , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Seungho Park , Inkyu Hwang , Donghwan Jung , Jongsung Kim List-Id: linux-pm@vger.kernel.org On Monday, November 12, 2018 9:15:18 AM CET Oleg Nesterov wrote: > On 11/12, Chanho Min wrote: > > > > @@ -1083,7 +1084,7 @@ static int de_thread(struct task_struct *tsk) > > while (sig->notify_count) { > > __set_current_state(TASK_KILLABLE); > > spin_unlock_irq(lock); > > - schedule(); > > + freezable_schedule(); > > if (unlikely(__fatal_signal_pending(tsk))) > > goto killed; > > spin_lock_irq(lock); > > @@ -1111,7 +1112,7 @@ static int de_thread(struct task_struct *tsk) > > __set_current_state(TASK_KILLABLE); > > write_unlock_irq(&tasklist_lock); > > cgroup_threadgroup_change_end(tsk); > > - schedule(); > > + freezable_schedule(); > > if (unlikely(__fatal_signal_pending(tsk))) > > goto killed; > > } > > Thanks, looks good to me. > > Acked-by: Oleg Nesterov Patch applied, thanks!