Re: [PATCH v3 6/6] arm64: defconfig: Enable RZ/G3E thermal

[Krzysztof Kozlowski <krzk@kernel.org>]

On 17/03/2025 12:14, John Madieu wrote:
> Hi Krzysztof,
> 
> Thanks for the review!
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: Monday, March 17, 2025 10:29 AM
>> To: John Madieu <john.madieu.xa@bp.renesas.com>
>> Subject: Re: [PATCH v3 6/6] arm64: defconfig: Enable RZ/G3E thermal
>>
>> On Sat, Mar 15, 2025 at 09:12:16AM +0100, John Madieu wrote:
>>> Enable the CONFIG_RZG3E_THERMAL flag for the RZ/G3E SoC.
>>
>> s/RZ/Renesas RZ/ and which *upstream* board uses it? This is not your
>> platform defconfig, but all platforms and all users defconfig.
>>
> 
> Noted for the fix.
> 
> However, most thermal drivers use SOC-specific config options,
> as we can see in arm64 defconfig:
> 
> [...]
> CONFIG_IMX8MM_THERMAL=m
> CONFIG_K3_THERMAL=m
> CONFIG_QORIQ_THERMAL=m
> CONFIG_SUN8I_THERMAL=y
> CONFIG_ROCKCHIP_THERMAL=m
> CONFIG_RCAR_THERMAL=y
> CONFIG_RCAR_GEN3_THERMAL=y
> CONFIG_RZG2L_THERMAL=y
> CONFIG_ARMADA_THERMAL=y
> CONFIG_MTK_THERMAL=m
> CONFIG_MTK_LVTS_THERMAL=m
> CONFIG_BCM2711_THERMAL=m
> CONFIG_BCM2835_THERMAL=m
> CONFIG_BRCMSTB_THERMAL=m
> [...]
> 
> Hence my choice for RZG3E_THERMAL, or did I miss something in your comment?
Your commit msg must explain why do we want it. I gave you idea, if you
don't want to use it, sure, come with other.

Best regards,
Krzysztof