From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D03B2451F1; Mon, 17 Mar 2025 14:55:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742223359; cv=none; b=NKoqAL6aT5twZKmSenExFRPTW86AYqI6aeHL7jlZ2wCbHGx+hWFcFBfMDOSqqGFDllrx4Q+GCd7k/H9K33iwKj3I6WguKsKnit1AAO87x1nPSMZ3AEiT3XlCtLnJGnR63k/faKeV3tdLgk0OPMUtkK1CCiyQixCosW0cetwOjHY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742223359; c=relaxed/simple; bh=dufHt2ZbCtfSlksK/9SNCkEaezP+05PBRfmk1Spyi9M=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=JzRtQKv3NfTJFcUC4nxtDmqSZV+Sjs/iNBOTfFKU78zFO4a0EvBOcQxn77yfwtJOWNN2/nEJ3EvZodNgkMooVypNCsjrAWs1LzIZJ8zhEsqYd34Aj+5S8jG5xmmiAszxCD5hih1xpcCmhe5O4sPaNITwuHokfXYYwi0a7ie0i3s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Y1zIjvTX; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Y1zIjvTX" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 43128C4CEE9; Mon, 17 Mar 2025 14:55:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742223359; bh=dufHt2ZbCtfSlksK/9SNCkEaezP+05PBRfmk1Spyi9M=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Y1zIjvTX3LkHV0Wqdi72WtXFqj+qg1TRka/DivNu4W6YzyFR6lnNeaq/sn9yOE9Hf OS5D2z/ivOJI4ER45vbsyqnAPNBnv/kmLXYxyZ0ZKDu3XO3ERgYMmGB4cDCOvOJySL bJ9Aa7A3bXWN32No/nk7r7sTuow36H3PUj8zZrr1LA19JBeAaoCeFXnF7Wgw77MMvV /pt8GEsrCkgRxw9QkBq7C1t/EqrchMSrayHnsXb6s8UmShbBEy4MGIrJwbT5MVerBJ RYJDVLdrHYNPi3qrBwedKETKtjGV1psa+6E8CwOKcruE4Fi0tV42SxaVdSzNS96VQt Vy2NgDdTkVFJQ== Message-ID: <21de806b-1d25-4feb-bc30-1b5c3adf1bb0@kernel.org> Date: Mon, 17 Mar 2025 15:55:50 +0100 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 6/6] arm64: defconfig: Enable RZ/G3E thermal To: John Madieu Cc: "geert+renesas@glider.be" , "conor+dt@kernel.org" , "krzk+dt@kernel.org" , "robh@kernel.org" , "rafael@kernel.org" , "daniel.lezcano@linaro.org" , "magnus.damm@gmail.com" , "devicetree@vger.kernel.org" , "john.madieu@gmail.com" , "rui.zhang@intel.com" , "linux-kernel@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , "sboyd@kernel.org" , Biju Das , "linux-pm@vger.kernel.org" , "lukasz.luba@arm.com" References: <20250315081225.92118-1-john.madieu.xa@bp.renesas.com> <20250315081225.92118-7-john.madieu.xa@bp.renesas.com> <20250317-bipedal-inchworm-of-poetry-b60fc9@krzk-bin> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 17/03/2025 12:14, John Madieu wrote: > Hi Krzysztof, > > Thanks for the review! > >> -----Original Message----- >> From: Krzysztof Kozlowski >> Sent: Monday, March 17, 2025 10:29 AM >> To: John Madieu >> Subject: Re: [PATCH v3 6/6] arm64: defconfig: Enable RZ/G3E thermal >> >> On Sat, Mar 15, 2025 at 09:12:16AM +0100, John Madieu wrote: >>> Enable the CONFIG_RZG3E_THERMAL flag for the RZ/G3E SoC. >> >> s/RZ/Renesas RZ/ and which *upstream* board uses it? This is not your >> platform defconfig, but all platforms and all users defconfig. >> > > Noted for the fix. > > However, most thermal drivers use SOC-specific config options, > as we can see in arm64 defconfig: > > [...] > CONFIG_IMX8MM_THERMAL=m > CONFIG_K3_THERMAL=m > CONFIG_QORIQ_THERMAL=m > CONFIG_SUN8I_THERMAL=y > CONFIG_ROCKCHIP_THERMAL=m > CONFIG_RCAR_THERMAL=y > CONFIG_RCAR_GEN3_THERMAL=y > CONFIG_RZG2L_THERMAL=y > CONFIG_ARMADA_THERMAL=y > CONFIG_MTK_THERMAL=m > CONFIG_MTK_LVTS_THERMAL=m > CONFIG_BCM2711_THERMAL=m > CONFIG_BCM2835_THERMAL=m > CONFIG_BRCMSTB_THERMAL=m > [...] > > Hence my choice for RZG3E_THERMAL, or did I miss something in your comment? Your commit msg must explain why do we want it. I gave you idea, if you don't want to use it, sure, come with other. Best regards, Krzysztof