Re: [PATCH 0/4] cpufreq/opp: Turbo/boost mode support

[Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>]

On Tuesday, July 28, 2015 05:48:43 PM Viresh Kumar wrote:
> On 28-07-15, 13:55, Bartlomiej Zolnierkiewicz wrote:
> > Could you please tell me first how do you want me to fix the issue
> > with setting boost_supported flag in cpufreq driver structure?
> > 
> > For exynos-cpufreq driver we currently have:
> > 
> > #ifdef CONFIG_ARM_EXYNOS_CPU_FREQ_BOOST_SW
> > 	.boost_supported = true,
> > #endif
> > 
> > With my original patches the config option stayed the same and
> > the flag was enabled if necessary in Exynos platform code and
> > passed through platform data to cpufreq-dt driver.  This is no
> > longer possible with your changes.
> > 
> > Should I enable it unconditionally in cpufreq-dt driver or add new
> > config option for cpufreq-dt driver (CONFIG_CPUFREQ_DT_BOOST_SW?)
> > for enabling boost_supported flag if necessary?
> 
> Look at my implementation, last two patches are already doing that.
> You don't need another change to get this working for you, neither are

I did look a them and they are lacking enabling of boost support flag
in cpufreq_dt driver structure.

There is also CONFIG_CPU_FREQ_BOOST_SW which needs to be enabled to
have boost frequencies in sysfs (code for that is in freq_table.c).

> those config options required. Get rid of them :)

Do you mean that we should now depend only on dts info for enabling
boost support and that CONFIG_CPU_FREQ_BOOST_SW should be removed
(together with CONFIG_ARM_EXYNOS_CPU_FREQ_BOOST_SW)?

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics