From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Xiaofei Tan <tanxiaofei@huawei.com>
Cc: pavel@ucw.cz, linux-pm@vger.kernel.org, linuxarm@huawei.com
Subject: Re: [PATCH 1/1] PM / wakeirq: remove unnecessary parentheses
Date: Wed, 13 Nov 2019 13:17:31 +0100 [thread overview]
Message-ID: <2240259.dxfY0U6Kfo@kreacher> (raw)
In-Reply-To: <1571128290-55488-1-git-send-email-tanxiaofei@huawei.com>
On Tuesday, October 15, 2019 10:31:30 AM CET Xiaofei Tan wrote:
> Remove unnecessary parentheses found by code review.
>
> Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
> ---
> drivers/base/power/wakeirq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/base/power/wakeirq.c b/drivers/base/power/wakeirq.c
> index 5ce77d1..8e02108 100644
> --- a/drivers/base/power/wakeirq.c
> +++ b/drivers/base/power/wakeirq.c
> @@ -272,7 +272,7 @@ void dev_pm_enable_wake_irq_check(struct device *dev,
> {
> struct wake_irq *wirq = dev->power.wakeirq;
>
> - if (!wirq || !((wirq->status & WAKE_IRQ_DEDICATED_MASK)))
> + if (!wirq || !(wirq->status & WAKE_IRQ_DEDICATED_MASK))
> return;
>
> if (likely(wirq->status & WAKE_IRQ_DEDICATED_MANAGED)) {
> @@ -299,7 +299,7 @@ void dev_pm_disable_wake_irq_check(struct device *dev)
> {
> struct wake_irq *wirq = dev->power.wakeirq;
>
> - if (!wirq || !((wirq->status & WAKE_IRQ_DEDICATED_MASK)))
> + if (!wirq || !(wirq->status & WAKE_IRQ_DEDICATED_MASK))
> return;
>
> if (wirq->status & WAKE_IRQ_DEDICATED_MANAGED)
>
Applied as 5.5 material, thanks!
prev parent reply other threads:[~2019-11-13 12:17 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 8:31 [PATCH 1/1] PM / wakeirq: remove unnecessary parentheses Xiaofei Tan
2019-11-13 12:17 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2240259.dxfY0U6Kfo@kreacher \
--to=rjw@rjwysocki.net \
--cc=linux-pm@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=pavel@ucw.cz \
--cc=tanxiaofei@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox