linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Wang Weidong <wangweidong1@huawei.com>
Cc: viresh.kumar@linaro.org, linux-pm@vger.kernel.org,
	linux-kernel@vger.kernel.org, guohanjun@huawei.com
Subject: Re: [PATCH 0/2] fix some problems for cpufreq
Date: Sat, 29 Nov 2014 02:26:20 +0100	[thread overview]
Message-ID: <2248504.pAVebap2qN@vostro.rjw.lan> (raw)
In-Reply-To: <1417142619-14548-1-git-send-email-wangweidong1@huawei.com>

On Friday, November 28, 2014 10:43:37 AM Wang Weidong wrote:
> Hi Rafael and Viresh
> 
> Sorry to trouble you again. As for:
> "acpi-cpufreq: get the cur_freq from acpi_processor_performance states"
> I do it again, and add the other patch.
> 
> patch #1: acpi-cpufreq: make the freq_table store the same freq value
> 
> I think it can work. The set of available states which come
> from acpi won't change. Just like the power would be remove,
> the acpi driver will do that:
> call
>  ->acpi_processor_ppc_has_changed
>  ->cpufreq_update_policy
>  ->acpi_ppc_notifier_block.notifier_call
>    ->acpi_processor_ppc_notifier
>    ->cpufreq_verify_within_limits
> The progress will change the policy's min_freq and max_freq
> while it won't change the set of states(freq_tables).

OK, so the above information needs to go into the changelog of patch [1/2].
Also, please clarify the problem description in that changelog, it is very
difficult to understand the way it is now.

> patch #2: cpufreq: show the real avail freqs with the freq_table
> 
> when the min_freq and max_freq change, we should sync the availble
> freqs.

Why?  Do any other cpufreq drivers do that?

Rafael


  parent reply	other threads:[~2014-11-29  1:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-28  2:43 [PATCH 0/2] fix some problems for cpufreq Wang Weidong
2014-11-28  2:43 ` [PATCH 1/2] acpi-cpufreq: make the freq_table store the same freq value Wang Weidong
2014-11-28  2:43 ` [PATCH 2/2] cpufreq: show the real avail freqs with the freq_table Wang Weidong
2014-11-29  1:26 ` Rafael J. Wysocki [this message]
2014-11-29  1:40   ` [PATCH 0/2] fix some problems for cpufreq Wang Weidong
2014-11-29 22:30     ` Rafael J. Wysocki
2014-11-30  8:23       ` Wang Weidong
2014-12-02  4:38         ` Viresh Kumar
2014-12-03  5:49           ` Wang Weidong
2014-11-30 10:17 ` [PATCH v2] acpi-cpufreq: make the freq_table store the same freq value Wang Weidong
2014-12-27  1:33   ` [PATCH RESEND " Wang Weidong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2248504.pAVebap2qN@vostro.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=guohanjun@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=viresh.kumar@linaro.org \
    --cc=wangweidong1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).