From: Krzysztof Kozlowski <krzk@kernel.org>
To: John Erasmus Mari Geronimo <johnerasmusmari.geronimo@analog.com>,
linux-pm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: Sebastian Reichel <sre@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: power: supply: add adi,lt8491.yaml
Date: Fri, 10 Jan 2025 10:26:08 +0100 [thread overview]
Message-ID: <235467e3-75fe-46d4-b809-434261cc0798@kernel.org> (raw)
In-Reply-To: <20250110080235.54808-2-johnerasmusmari.geronimo@analog.com>
On 10/01/2025 09:02, John Erasmus Mari Geronimo wrote:
> +$id: http://devicetree.org/schemas/power/supply/adi,lt8491.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Linear Technology (Analog Devices) LT8491 Battery Charger
> +
> +maintainers:
> + - John Erasmus Mari Geronimo <johnerasmusmari.geronimo@analog.com>
> +
> +description: |
> + The LT8491 is a buck-boost switching regulator battery charger that implements
> + a constant-current constant-voltage (CCCV) charging profile used for most
> + battery types, including sealed lead-acid (SLA), flooded, gel and lithium-ion.
> +
> + Specifications about the charger can be found at:
> + https://www.analog.com/en/products/lt8491.html
> +
Mostly looks good, but I don't see $ref to power-supply, which brings
you the battery property.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-01-10 9:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-10 8:02 [PATCH 0/2] Add LT8491 driver John Erasmus Mari Geronimo
2025-01-10 8:02 ` [PATCH 1/2] dt-bindings: power: supply: add adi,lt8491.yaml John Erasmus Mari Geronimo
2025-01-10 9:26 ` Krzysztof Kozlowski [this message]
2025-01-10 8:02 ` [PATCH 2/2] power: supply: add LT8491 battery charger driver John Erasmus Mari Geronimo
2025-01-14 16:45 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=235467e3-75fe-46d4-b809-434261cc0798@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=johnerasmusmari.geronimo@analog.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).