From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH 01/10] i2c: add suspended flag and accessors for i2c adapters Date: Thu, 20 Dec 2018 22:09:37 +0100 Message-ID: <2368540.q2jLLRDsj0@aspire.rjw.lan> References: <20181219164827.20985-1-wsa+renesas@sang-engineering.com> <20181219223341.GA998@kunai> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Hans de Goede Cc: Wolfram Sang , Lukas Wunner , Wolfram Sang , linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org List-Id: linux-pm@vger.kernel.org On Thursday, December 20, 2018 11:00:29 AM CET Hans de Goede wrote: > Hi, > > On 19-12-18 23:33, Wolfram Sang wrote: > > Hi Lukas, Hans, > > > > On Wed, Dec 19, 2018 at 07:36:54PM +0100, Hans de Goede wrote: > >> Hi, > >> > >> On 19-12-18 18:22, Lukas Wunner wrote: > >>> On Wed, Dec 19, 2018 at 05:48:17PM +0100, Wolfram Sang wrote: > >>>> +static inline void i2c_mark_adapter_suspended(struct i2c_adapter *adap) > >>>> +{ > >>>> + i2c_lock_bus(adap, I2C_LOCK_ROOT_ADAPTER); > >>>> + set_bit(I2C_ALF_IS_SUSPENDED, &adap->locked_flags); > >>>> + i2c_unlock_bus(adap, I2C_LOCK_ROOT_ADAPTER); > >>>> +} > >>> > >>> This looks like a duplication of the is_suspended flag in struct dev_pm_info. > >>> Any reason why you can't use that? If so, it would be good to document the > >>> reason in the commit message. > >> > >> Oh, that is a very good point and that one only gets set on system suspend > >> and not on resume suspend, working around the problems with the i2c-designware > > > > Just to make it clear: you mean runtime suspend, not resume suspend, or? > > Yes I mean runtime-suspend, sorry. The power.is_suspended flag is about system-wide suspend, however.