Linux Power Management development
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Kevin Hilman <khilman@kernel.org>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	linux-pm@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] PM / Domains: Do not print PM domain add error message if EPROBE_DEFER
Date: Thu, 01 Dec 2016 15:25 +0100	[thread overview]
Message-ID: <2449753.iPCUDMXyRB@aspire.rjw.lan> (raw)
In-Reply-To: <1480508696-19294-1-git-send-email-geert+renesas@glider.be>

On Wednesday, November 30, 2016 01:24:56 PM Geert Uytterhoeven wrote:
> EPROBE_DEFER is not an error, hence printing an error message like
> 
>     renesas_irqc e61c0000.interrupt-controller: failed to add to PM domain always-on: -517
> 
> may confuse the user.
> 
> Suppress the error message in case of EPROBE_DEFER to fix this.
> 
> Reported-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/base/power/domain.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/base/power/domain.c b/drivers/base/power/domain.c
> index 64164aac6ae3990a..f22137b52dcb641b 100644
> --- a/drivers/base/power/domain.c
> +++ b/drivers/base/power/domain.c
> @@ -2032,8 +2032,9 @@ int genpd_dev_pm_attach(struct device *dev)
>  	mutex_unlock(&gpd_list_lock);
>  
>  	if (ret < 0) {
> -		dev_err(dev, "failed to add to PM domain %s: %d",
> -			pd->name, ret);
> +		if (ret != -EPROBE_DEFER)
> +			dev_err(dev, "failed to add to PM domain %s: %d",
> +				pd->name, ret);
>  		goto out;
>  	}
>  
> 

Applied (with ACKs etc).

Thanks,
Rafael


      parent reply	other threads:[~2016-12-01 14:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-30 12:24 [PATCH] PM / Domains: Do not print PM domain add error message if EPROBE_DEFER Geert Uytterhoeven
2016-11-30 12:41 ` Simon Horman
2016-11-30 14:34 ` Ulf Hansson
2016-11-30 16:41 ` Kevin Hilman
2016-12-01 14:25 ` Rafael J. Wysocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2449753.iPCUDMXyRB@aspire.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=geert+renesas@glider.be \
    --cc=khilman@kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox