From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Linux PM <linux-pm@vger.kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Lukasz Luba <lukasz.luba@arm.com>,
Zhang Rui <rui.zhang@intel.com>
Subject: [PATCH v3 11/14] thermal: imx: Use the .should_bind() thermal zone callback
Date: Mon, 19 Aug 2024 18:26:20 +0200 [thread overview]
Message-ID: <2485070.jE0xQCEvom@rjwysocki.net> (raw)
In-Reply-To: <2205737.irdbgypaU6@rjwysocki.net>
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Make the imx_thermal driver use the .should_bind() thermal zone callback
to provide the thermal core with the information on whether or not to
bind the given cooling device to the given trip point in the given
thermal zone. If it returns 'true', the thermal core will bind the
cooling device to the trip and the corresponding unbinding will be
taken care of automatically by the core on the removal of the involved
thermal zone or cooling device.
In the imx_thermal case, it only needs to return 'true' for the passive
trip point and it will match any cooling device passed to it, in
analogy with the old-style imx_bind() callback function.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
v1 -> v3: No changes
This patch only depends on the [06/14] introducing the .should_bind()
thermal zone callback:
https://lore.kernel.org/linux-pm/9334403.CDJkKcVGEf@rjwysocki.net/
---
drivers/thermal/imx_thermal.c | 20 ++++++--------------
1 file changed, 6 insertions(+), 14 deletions(-)
Index: linux-pm/drivers/thermal/imx_thermal.c
===================================================================
--- linux-pm.orig/drivers/thermal/imx_thermal.c
+++ linux-pm/drivers/thermal/imx_thermal.c
@@ -353,24 +353,16 @@ static int imx_set_trip_temp(struct ther
return 0;
}
-static int imx_bind(struct thermal_zone_device *tz,
- struct thermal_cooling_device *cdev)
+static bool imx_should_bind(struct thermal_zone_device *tz,
+ const struct thermal_trip *trip,
+ struct thermal_cooling_device *cdev,
+ struct cooling_spec *c)
{
- return thermal_zone_bind_cooling_device(tz, IMX_TRIP_PASSIVE, cdev,
- THERMAL_NO_LIMIT,
- THERMAL_NO_LIMIT,
- THERMAL_WEIGHT_DEFAULT);
-}
-
-static int imx_unbind(struct thermal_zone_device *tz,
- struct thermal_cooling_device *cdev)
-{
- return thermal_zone_unbind_cooling_device(tz, IMX_TRIP_PASSIVE, cdev);
+ return trip->type == THERMAL_TRIP_PASSIVE;
}
static struct thermal_zone_device_ops imx_tz_ops = {
- .bind = imx_bind,
- .unbind = imx_unbind,
+ .should_bind = imx_should_bind,
.get_temp = imx_get_temp,
.change_mode = imx_change_mode,
.set_trip_temp = imx_set_trip_temp,
next prev parent reply other threads:[~2024-08-19 16:33 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 15:49 [PATCH v3 00/14] thermal: Rework binding cooling devices to trip points Rafael J. Wysocki
2024-08-19 15:50 ` [PATCH v3 01/14] thermal: core: Fold two functions into their respective callers Rafael J. Wysocki
2024-08-20 7:04 ` Zhang, Rui
2024-08-21 7:57 ` Daniel Lezcano
2024-08-19 15:51 ` [PATCH v3 02/14] thermal: core: Rearrange checks in thermal_bind_cdev_to_trip() Rafael J. Wysocki
2024-08-20 7:05 ` Zhang, Rui
2024-08-21 7:59 ` Daniel Lezcano
2024-08-21 8:49 ` lihuisong (C)
2024-08-21 9:28 ` Daniel Lezcano
2024-08-21 9:44 ` lihuisong (C)
2024-08-21 10:49 ` Daniel Lezcano
2024-08-21 11:22 ` lihuisong (C)
2024-08-21 11:12 ` Rafael J. Wysocki
2024-08-21 10:51 ` Rafael J. Wysocki
2024-08-19 15:52 ` [PATCH v3 03/14] thermal: core: Drop redundant thermal instance checks Rafael J. Wysocki
2024-08-20 7:05 ` Zhang, Rui
2024-08-21 9:32 ` Daniel Lezcano
2024-08-21 11:11 ` Rafael J. Wysocki
2024-08-21 11:56 ` Daniel Lezcano
2024-08-21 12:52 ` Rafael J. Wysocki
2024-08-19 15:56 ` [PATCH v3 04/14] thermal: sysfs: Use the dev argument in instance-related show/store Rafael J. Wysocki
2024-08-20 7:05 ` Zhang, Rui
2024-08-20 7:59 ` lihuisong (C)
2024-08-21 9:36 ` Daniel Lezcano
2024-08-19 15:58 ` [PATCH v3 05/14] thermal: core: Move thermal zone locking out of bind/unbind functions Rafael J. Wysocki
2024-08-20 7:05 ` Zhang, Rui
2024-08-20 8:27 ` lihuisong (C)
2024-08-20 10:27 ` Rafael J. Wysocki
2024-08-21 9:02 ` lihuisong (C)
2024-08-21 10:30 ` Rafael J. Wysocki
2024-08-21 9:46 ` Daniel Lezcano
2024-08-19 16:00 ` [PATCH v3 06/14] thermal: core: Introduce .should_bind() thermal zone callback Rafael J. Wysocki
2024-08-20 7:06 ` Zhang, Rui
2024-08-21 9:09 ` lihuisong (C)
2024-08-21 13:21 ` Daniel Lezcano
2024-08-19 16:02 ` [PATCH v3 07/14] thermal: ACPI: Use the " Rafael J. Wysocki
2024-08-20 7:06 ` Zhang, Rui
2024-08-21 13:22 ` Daniel Lezcano
2024-08-19 16:05 ` [PATCH v3 08/14] thermal: core: Unexport thermal_bind_cdev_to_trip() and thermal_unbind_cdev_from_trip() Rafael J. Wysocki
2024-08-20 7:08 ` Zhang, Rui
2024-08-21 9:18 ` lihuisong (C)
2024-08-21 13:23 ` Daniel Lezcano
2024-08-19 16:19 ` [PATCH v3 09/14] platform/x86: acerhdf: Use the .should_bind() thermal zone callback Rafael J. Wysocki
2024-08-19 20:24 ` Peter Kästle
2024-08-21 13:25 ` Daniel Lezcano
2024-08-19 16:24 ` [PATCH v3 10/14] mlxsw: core_thermal: " Rafael J. Wysocki
2024-08-19 16:26 ` Rafael J. Wysocki [this message]
2024-08-21 13:42 ` [PATCH v3 11/14] thermal: imx: " Daniel Lezcano
2024-08-19 16:30 ` [PATCH v3 12/14] thermal/of: " Rafael J. Wysocki
2024-08-21 14:20 ` Daniel Lezcano
2024-08-26 11:31 ` Marek Szyprowski
2024-08-26 12:14 ` Rafael J. Wysocki
2024-08-26 20:49 ` Marek Szyprowski
2024-08-27 11:39 ` Rafael J. Wysocki
2024-08-19 16:31 ` [PATCH v3 13/14] thermal: core: Drop unused bind/unbind functions and callbacks Rafael J. Wysocki
2024-08-20 7:10 ` Zhang, Rui
2024-08-21 9:33 ` lihuisong (C)
2024-08-21 14:24 ` Daniel Lezcano
2024-08-19 16:33 ` [PATCH v3 14/14] thermal: core: Clean up trip bind/unbind functions Rafael J. Wysocki
2024-08-20 7:11 ` Zhang, Rui
2024-08-21 9:34 ` lihuisong (C)
2024-08-21 14:29 ` Daniel Lezcano
2024-08-21 16:21 ` Rafael J. Wysocki
2024-08-24 18:45 ` [PATCH v3 00/14] thermal: Rework binding cooling devices to trip points Nícolas F. R. A. Prado
2024-08-26 9:58 ` Rafael J. Wysocki
2024-08-30 13:55 ` Nícolas F. R. A. Prado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2485070.jE0xQCEvom@rjwysocki.net \
--to=rjw@rjwysocki.net \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox