[PATCH v3 0/7] PM / Domains: Add DT bindings for the R-Car System Controller

[PATCH v3 0/7] PM / Domains: Add DT bindings for the R-Car System Controller

[Geert Uytterhoeven]

	Hi all,

This patch series introduces DT bindings for the R-Car System
Controller.

Changes compared to v2:
  - Move power area hierarchy from DT to C (cfr. DT bindings for Renesas
    CPG/MSSR), and switch to "#power-domain-cells = <1>",
  - Drop fallback compatibility strings, as the bindings are
    SoC-specific,
  - Drop power area A3SH on R-Car H3, as it's no longer
    documented in the datasheet, and touching it seems to crash SYSC,
  - Add an "always-on" power area on R-Car H3,
  - Rename from renesas,sysc-rcar.txt to renesas,rcar-sysc.txt,
  - Extract bindings into a separate series (was "[PATCH/RFC v2 00/11]
    ARM/arm64: renesas: Add SYSC PM Domain DT Support",
    http://www.spinics.net/lists/arm-kernel/msg483199.html).

Changes compared to v1:
  - Add R-Car H3 (r8a7795) support,
  - Use "renesas,<type>-sysc" instead of "renesas,sysc-<type>",
  - Add fallback compatibility strings for R-Car Gen2 and Gen3.

Thanks for your comments!

Geert Uytterhoeven (7):
  PM / Domains: Add DT bindings for the R-Car System Controller
  soc: renesas: Add r8a7779 SYSC PM Domain Binding Definitions
  soc: renesas: Add r8a7790 SYSC PM Domain Binding Definitions
  soc: renesas: Add r8a7791 SYSC PM Domain Binding Definitions
  soc: renesas: Add r8a7793 SYSC PM Domain Binding Definitions
  soc: renesas: Add r8a7794 SYSC PM Domain Binding Definitions
  soc: renesas: Add r8a7795 SYSC PM Domain Binding Definitions

 .../bindings/power/renesas,rcar-sysc.txt           | 48 ++++++++++++++++++++++
 include/dt-bindings/power/r8a7779-sysc.h           | 25 +++++++++++
 include/dt-bindings/power/r8a7790-sysc.h           | 31 ++++++++++++++
 include/dt-bindings/power/r8a7791-sysc.h           | 23 +++++++++++
 include/dt-bindings/power/r8a7793-sysc.h           | 27 ++++++++++++
 include/dt-bindings/power/r8a7794-sysc.h           | 23 +++++++++++
 include/dt-bindings/power/r8a7795-sysc.h           | 42 +++++++++++++++++++
 7 files changed, 219 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/renesas,rcar-sysc.txt
 create mode 100644 include/dt-bindings/power/r8a7779-sysc.h
 create mode 100644 include/dt-bindings/power/r8a7790-sysc.h
 create mode 100644 include/dt-bindings/power/r8a7791-sysc.h
 create mode 100644 include/dt-bindings/power/r8a7793-sysc.h
 create mode 100644 include/dt-bindings/power/r8a7794-sysc.h
 create mode 100644 include/dt-bindings/power/r8a7795-sysc.h

-- 
1.9.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v3 1/7] PM / Domains: Add DT bindings for the R-Car System Controller

[Geert Uytterhoeven]

The Renesas R-Car System Controller provides power management for the
CPU cores and various coprocessors, following the generic PM domain
bindings in Documentation/devicetree/bindings/power/power_domain.txt.

This supports R-Car Gen1 (H1), Gen2, and Gen3.

Signed-off-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
---
v3:
  - Move power area hierarchy from DT to C (cfr. DT bindings for Renesas
    CPG/MSSR), and switch to "#power-domain-cells = <1>",
  - Drop fallback compatibility strings, as the bindings are
    SoC-specific,
  - Rename from renesas,sysc-rcar.txt to renesas,rcar-sysc.txt,

v2:
  - Add R-Car H3 (r8a7795) support,
  - Use "renesas,<type>-sysc" instead of "renesas,sysc-<type>",
  - Add fallback compatibility strings for R-Car Gen2 and Gen3.
---
 .../bindings/power/renesas,rcar-sysc.txt           | 48 ++++++++++++++++++++++
 1 file changed, 48 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/power/renesas,rcar-sysc.txt

diff --git a/Documentation/devicetree/bindings/power/renesas,rcar-sysc.txt b/Documentation/devicetree/bindings/power/renesas,rcar-sysc.txt
new file mode 100644
index 0000000000000000..1765fd37c3658b60
--- /dev/null
+++ b/Documentation/devicetree/bindings/power/renesas,rcar-sysc.txt
@@ -0,0 +1,48 @@
+DT bindings for the Renesas R-Car System Controller
+
+== System Controller Node ==
+
+The R-Car System Controller provides power management for the CPU cores and
+various coprocessors.
+
+Required properties:
+  - compatible: Must contain one or more of the following:
+      - "renesas,r8a7779-sysc" (R-Car H1)
+      - "renesas,r8a7790-sysc" (R-Car H2)
+      - "renesas,r8a7791-sysc" (R-Car M2-W)
+      - "renesas,r8a7792-sysc" (R-Car V2H)
+      - "renesas,r8a7793-sysc" (R-Car M2-N)
+      - "renesas,r8a7794-sysc" (R-Car E2)
+      - "renesas,r8a7795-sysc" (R-Car H3)
+  - reg: Address start and address range for the device.
+  - #power-domain-cells: Must be 1.
+
+
+Example:
+
+	sysc: system-controller@e6180000 {
+		compatible = "renesas,r8a7791-sysc";
+		reg = <0 0xe6180000 0 0x0200>;
+		#power-domain-cells = <1>;
+	};
+
+
+== PM Domain Consumers ==
+
+Devices residing in a power area must refer to that power area, as documented
+by the generic PM domain bindings in
+Documentation/devicetree/bindings/power/power_domain.txt.
+
+Required properties:
+  - power-domains: A phandle and symbolic PM domain specifier, as defined in
+		   <dt-bindings/power/r8a77*-sysc.h>.
+
+
+Example:
+
+	L2_CA15: cache-controller@0 {
+		compatible = "cache";
+		power-domains = <&sysc R8A7791_PD_CA15_SCU>;
+		cache-unified;
+		cache-level = <2>;
+	};
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 1/7] PM / Domains: Add DT bindings for the R-Car System Controller

[Laurent Pinchart]

Hi Geert,

Thank you for the patch.

On Wednesday 09 March 2016 20:18:36 Geert Uytterhoeven wrote:
> The Renesas R-Car System Controller provides power management for the
> CPU cores and various coprocessors, following the generic PM domain
> bindings in Documentation/devicetree/bindings/power/power_domain.txt.
> 
> This supports R-Car Gen1 (H1), Gen2, and Gen3.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v3:
>   - Move power area hierarchy from DT to C (cfr. DT bindings for Renesas
>     CPG/MSSR), and switch to "#power-domain-cells = <1>",
>   - Drop fallback compatibility strings, as the bindings are
>     SoC-specific,
>   - Rename from renesas,sysc-rcar.txt to renesas,rcar-sysc.txt,
> 
> v2:
>   - Add R-Car H3 (r8a7795) support,
>   - Use "renesas,<type>-sysc" instead of "renesas,sysc-<type>",
>   - Add fallback compatibility strings for R-Car Gen2 and Gen3.
> ---
>  .../bindings/power/renesas,rcar-sysc.txt           | 48 +++++++++++++++++++
>  1 file changed, 48 insertions(+)
>  create mode 100644
> Documentation/devicetree/bindings/power/renesas,rcar-sysc.txt
> 
> diff --git a/Documentation/devicetree/bindings/power/renesas,rcar-sysc.txt
> b/Documentation/devicetree/bindings/power/renesas,rcar-sysc.txt new file
> mode 100644
> index 0000000000000000..1765fd37c3658b60
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/renesas,rcar-sysc.txt
> @@ -0,0 +1,48 @@
> +DT bindings for the Renesas R-Car System Controller
> +
> +== System Controller Node ==
> +
> +The R-Car System Controller provides power management for the CPU cores and
> +various coprocessors.
> +
> +Required properties:
> +  - compatible: Must contain one or more of the following:

I'd be curious to see a use case for specifying more than one ;-) I think you 
can phrase it as "Must contain exactly one of the following".

Apart from that,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> +      - "renesas,r8a7779-sysc" (R-Car H1)
> +      - "renesas,r8a7790-sysc" (R-Car H2)
> +      - "renesas,r8a7791-sysc" (R-Car M2-W)
> +      - "renesas,r8a7792-sysc" (R-Car V2H)
> +      - "renesas,r8a7793-sysc" (R-Car M2-N)
> +      - "renesas,r8a7794-sysc" (R-Car E2)
> +      - "renesas,r8a7795-sysc" (R-Car H3)
> +  - reg: Address start and address range for the device.
> +  - #power-domain-cells: Must be 1.
> +
> +
> +Example:
> +
> +	sysc: system-controller@e6180000 {
> +		compatible = "renesas,r8a7791-sysc";
> +		reg = <0 0xe6180000 0 0x0200>;
> +		#power-domain-cells = <1>;
> +	};
> +
> +
> +== PM Domain Consumers ==
> +
> +Devices residing in a power area must refer to that power area, as
> documented +by the generic PM domain bindings in
> +Documentation/devicetree/bindings/power/power_domain.txt.
> +
> +Required properties:
> +  - power-domains: A phandle and symbolic PM domain specifier, as defined
> in
> +		   <dt-bindings/power/r8a77*-sysc.h>.
> +
> +
> +Example:
> +
> +	L2_CA15: cache-controller@0 {
> +		compatible = "cache";
> +		power-domains = <&sysc R8A7791_PD_CA15_SCU>;
> +		cache-unified;
> +		cache-level = <2>;
> +	};

-- 
Regards,

Laurent Pinchart

Re: [PATCH v3 1/7] PM / Domains: Add DT bindings for the R-Car System Controller

[Geert Uytterhoeven]

On Thu, Mar 10, 2016 at 3:24 AM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Wednesday 09 March 2016 20:18:36 Geert Uytterhoeven wrote:
>> The Renesas R-Car System Controller provides power management for the
>> CPU cores and various coprocessors, following the generic PM domain
>> bindings in Documentation/devicetree/bindings/power/power_domain.txt.
>>
>> This supports R-Car Gen1 (H1), Gen2, and Gen3.
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

>> +++ b/Documentation/devicetree/bindings/power/renesas,rcar-sysc.txt
>> @@ -0,0 +1,48 @@
>> +DT bindings for the Renesas R-Car System Controller
>> +
>> +== System Controller Node ==
>> +
>> +The R-Car System Controller provides power management for the CPU cores and
>> +various coprocessors.
>> +
>> +Required properties:
>> +  - compatible: Must contain one or more of the following:
>
> I'd be curious to see a use case for specifying more than one ;-) I think you
> can phrase it as "Must contain exactly one of the following".

Thanks, that was a leftover of the previous version. Will fix.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v3 1/7] PM / Domains: Add DT bindings for the R-Car System Controller

[Rob Herring]

On Wed, Mar 09, 2016 at 08:18:36PM +0100, Geert Uytterhoeven wrote:
> The Renesas R-Car System Controller provides power management for the
> CPU cores and various coprocessors, following the generic PM domain
> bindings in Documentation/devicetree/bindings/power/power_domain.txt.
> 
> This supports R-Car Gen1 (H1), Gen2, and Gen3.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v3:
>   - Move power area hierarchy from DT to C (cfr. DT bindings for Renesas
>     CPG/MSSR), and switch to "#power-domain-cells = <1>",
>   - Drop fallback compatibility strings, as the bindings are
>     SoC-specific,
>   - Rename from renesas,sysc-rcar.txt to renesas,rcar-sysc.txt,
> 
> v2:
>   - Add R-Car H3 (r8a7795) support,
>   - Use "renesas,<type>-sysc" instead of "renesas,sysc-<type>",
>   - Add fallback compatibility strings for R-Car Gen2 and Gen3.
> ---
>  .../bindings/power/renesas,rcar-sysc.txt           | 48 ++++++++++++++++++++++
>  1 file changed, 48 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/renesas,rcar-sysc.txt

Acked-by: Rob Herring <robh@kernel.org>

[PATCH v3 3/7] soc: renesas: Add r8a7790 SYSC PM Domain Binding Definitions

[Geert Uytterhoeven]

Signed-off-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
---
v3:
  - New.
---
 include/dt-bindings/power/r8a7790-sysc.h | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)
 create mode 100644 include/dt-bindings/power/r8a7790-sysc.h

diff --git a/include/dt-bindings/power/r8a7790-sysc.h b/include/dt-bindings/power/r8a7790-sysc.h
new file mode 100644
index 0000000000000000..8ff5b86c12a46e85
--- /dev/null
+++ b/include/dt-bindings/power/r8a7790-sysc.h
@@ -0,0 +1,31 @@
+/*
+ * Copyright (C) 2016 Glider bvba
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ */
+#ifndef __DT_BINDINGS_POWER_R8A7790_SYSC_H__
+#define __DT_BINDINGS_POWER_R8A7790_SYSC_H__
+
+/*
+ * These power domain indices match the numbers of the interrupt bits
+ * representing the power areas in the various Interrupt Registers
+ * (e.g. SYSCISR, Interrupt Status Register)
+ */
+
+#define R8A7790_PD_CA15_CPU0		 0
+#define R8A7790_PD_CA15_CPU1		 1
+#define R8A7790_PD_CA15_CPU2		 2
+#define R8A7790_PD_CA15_CPU3		 3
+#define R8A7790_PD_CA7_CPU0		 5
+#define R8A7790_PD_CA7_CPU1		 6
+#define R8A7790_PD_CA7_CPU2		 7
+#define R8A7790_PD_CA7_CPU3		 8
+#define R8A7790_PD_CA15_SCU		12
+#define R8A7790_PD_SH			16
+#define R8A7790_PD_RGX			20
+#define R8A7790_PD_CA7_SCU		21
+#define R8A7790_PD_IMP			24
+
+#endif /* __DT_BINDINGS_POWER_R8A7790_SYSC_H__ */
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 3/7] soc: renesas: Add r8a7790 SYSC PM Domain Binding Definitions

[Laurent Pinchart]

Hi Geert,

Thank you for the patch.

On Wednesday 09 March 2016 20:18:38 Geert Uytterhoeven wrote:
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v3:
>   - New.
> ---
>  include/dt-bindings/power/r8a7790-sysc.h | 31 +++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>  create mode 100644 include/dt-bindings/power/r8a7790-sysc.h
> 
> diff --git a/include/dt-bindings/power/r8a7790-sysc.h
> b/include/dt-bindings/power/r8a7790-sysc.h new file mode 100644
> index 0000000000000000..8ff5b86c12a46e85
> --- /dev/null
> +++ b/include/dt-bindings/power/r8a7790-sysc.h
> @@ -0,0 +1,31 @@
> +/*
> + * Copyright (C) 2016 Glider bvba
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; version 2 of the License.
> + */
> +#ifndef __DT_BINDINGS_POWER_R8A7790_SYSC_H__
> +#define __DT_BINDINGS_POWER_R8A7790_SYSC_H__
> +
> +/*
> + * These power domain indices match the numbers of the interrupt bits
> + * representing the power areas in the various Interrupt Registers
> + * (e.g. SYSCISR, Interrupt Status Register)
> + */
> +
> +#define R8A7790_PD_CA15_CPU0		 0
> +#define R8A7790_PD_CA15_CPU1		 1
> +#define R8A7790_PD_CA15_CPU2		 2
> +#define R8A7790_PD_CA15_CPU3		 3
> +#define R8A7790_PD_CA7_CPU0		 5
> +#define R8A7790_PD_CA7_CPU1		 6
> +#define R8A7790_PD_CA7_CPU2		 7
> +#define R8A7790_PD_CA7_CPU3		 8
> +#define R8A7790_PD_CA15_SCU		12
> +#define R8A7790_PD_SH			16

The power domain is called SH-4A in the datasheet, how about naming it 
R8A7790_PD_SH_4A ?

Apart from that,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> +#define R8A7790_PD_RGX			20
> +#define R8A7790_PD_CA7_SCU		21
> +#define R8A7790_PD_IMP			24
> +
> +#endif /* __DT_BINDINGS_POWER_R8A7790_SYSC_H__ */

-- 
Regards,

Laurent Pinchart

Re: [PATCH v3 3/7] soc: renesas: Add r8a7790 SYSC PM Domain Binding Definitions

[Geert Uytterhoeven]

Hi Laurent,

On Thu, Mar 10, 2016 at 7:57 AM, Laurent Pinchart
<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> wrote:
>> --- /dev/null
>> +++ b/include/dt-bindings/power/r8a7790-sysc.h
>> @@ -0,0 +1,31 @@

>> +#define R8A7790_PD_SH                        16
>
> The power domain is called SH-4A in the datasheet, how about naming it
> R8A7790_PD_SH_4A ?

Thanks, wlll update (for all SoCs).

> Apart from that,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>
>
>> +#define R8A7790_PD_RGX                       20
>> +#define R8A7790_PD_CA7_SCU           21
>> +#define R8A7790_PD_IMP                       24

Then this has to become R8A7790_PD_IMP_X4.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 3/7] soc: renesas: Add r8a7790 SYSC PM Domain Binding Definitions

[Geert Uytterhoeven]

On Thu, Mar 10, 2016 at 9:26 AM, Geert Uytterhoeven
<geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org> wrote:
>>> +#define R8A7790_PD_IMP                       24
>
> Then this has to become R8A7790_PD_IMP_X4.

Actually this bit is called IMP, so I'll keep it.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v3 4/7] soc: renesas: Add r8a7791 SYSC PM Domain Binding Definitions

[Geert Uytterhoeven]

Signed-off-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
---
v3:
  - New.
---
 include/dt-bindings/power/r8a7791-sysc.h | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 include/dt-bindings/power/r8a7791-sysc.h

diff --git a/include/dt-bindings/power/r8a7791-sysc.h b/include/dt-bindings/power/r8a7791-sysc.h
new file mode 100644
index 0000000000000000..791bcdc0df1c6c04
--- /dev/null
+++ b/include/dt-bindings/power/r8a7791-sysc.h
@@ -0,0 +1,23 @@
+/*
+ * Copyright (C) 2016 Glider bvba
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ */
+#ifndef __DT_BINDINGS_POWER_R8A7791_SYSC_H__
+#define __DT_BINDINGS_POWER_R8A7791_SYSC_H__
+
+/*
+ * These power domain indices match the numbers of the interrupt bits
+ * representing the power areas in the various Interrupt Registers
+ * (e.g. SYSCISR, Interrupt Status Register)
+ */
+
+#define R8A7791_PD_CA15_CPU0		 0
+#define R8A7791_PD_CA15_CPU1		 1
+#define R8A7791_PD_CA15_SCU		12
+#define R8A7791_PD_SH			16
+#define R8A7791_PD_SGX			20
+
+#endif /* __DT_BINDINGS_POWER_R8A7791_SYSC_H__ */
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 4/7] soc: renesas: Add r8a7791 SYSC PM Domain Binding Definitions

[Laurent Pinchart]

Hi Geert,

Thank you for the patch.

On Wednesday 09 March 2016 20:18:39 Geert Uytterhoeven wrote:
> Signed-off-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
> ---
> v3:
>   - New.
> ---
>  include/dt-bindings/power/r8a7791-sysc.h | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>  create mode 100644 include/dt-bindings/power/r8a7791-sysc.h
> 
> diff --git a/include/dt-bindings/power/r8a7791-sysc.h
> b/include/dt-bindings/power/r8a7791-sysc.h new file mode 100644
> index 0000000000000000..791bcdc0df1c6c04
> --- /dev/null
> +++ b/include/dt-bindings/power/r8a7791-sysc.h
> @@ -0,0 +1,23 @@
> +/*
> + * Copyright (C) 2016 Glider bvba
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; version 2 of the License.
> + */
> +#ifndef __DT_BINDINGS_POWER_R8A7791_SYSC_H__
> +#define __DT_BINDINGS_POWER_R8A7791_SYSC_H__
> +
> +/*
> + * These power domain indices match the numbers of the interrupt bits
> + * representing the power areas in the various Interrupt Registers
> + * (e.g. SYSCISR, Interrupt Status Register)
> + */
> +
> +#define R8A7791_PD_CA15_CPU0		 0
> +#define R8A7791_PD_CA15_CPU1		 1
> +#define R8A7791_PD_CA15_SCU		12
> +#define R8A7791_PD_SH			16

The power domain is called SH-4A in the datasheet, how about naming it 
R8A7791_PD_SH_4A ?

Apart from that,

Reviewed-by: Laurent Pinchart <laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org>

> +#define R8A7791_PD_SGX			20
> +
> +#endif /* __DT_BINDINGS_POWER_R8A7791_SYSC_H__ */

-- 
Regards,

Laurent Pinchart

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH v3 7/7] soc: renesas: Add r8a7795 SYSC PM Domain Binding Definitions

[Geert Uytterhoeven]

Signed-off-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>
---
v3:
  - New.
---
 include/dt-bindings/power/r8a7795-sysc.h | 42 ++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)
 create mode 100644 include/dt-bindings/power/r8a7795-sysc.h

diff --git a/include/dt-bindings/power/r8a7795-sysc.h b/include/dt-bindings/power/r8a7795-sysc.h
new file mode 100644
index 0000000000000000..ee2e26ba605ef9a3
--- /dev/null
+++ b/include/dt-bindings/power/r8a7795-sysc.h
@@ -0,0 +1,42 @@
+/*
+ * Copyright (C) 2016 Glider bvba
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ */
+#ifndef __DT_BINDINGS_POWER_R8A7795_SYSC_H__
+#define __DT_BINDINGS_POWER_R8A7795_SYSC_H__
+
+/*
+ * These power domain indices match the numbers of the interrupt bits
+ * representing the power areas in the various Interrupt Registers
+ * (e.g. SYSCISR, Interrupt Status Register)
+ */
+
+#define R8A7795_PD_CA57_CPU0		 0
+#define R8A7795_PD_CA57_CPU1		 1
+#define R8A7795_PD_CA57_CPU2		 2
+#define R8A7795_PD_CA57_CPU3		 3
+#define R8A7795_PD_CA53_CPU0		 5
+#define R8A7795_PD_CA53_CPU1		 6
+#define R8A7795_PD_CA53_CPU2		 7
+#define R8A7795_PD_CA53_CPU3		 8
+#define R8A7795_PD_A3VP			 9
+#define R8A7795_PD_CA57_SCU		12
+#define R8A7795_PD_CR7			13
+#define R8A7795_PD_A3VC			14
+#define R8A7795_PD_3DG_A		17
+#define R8A7795_PD_3DG_B		18
+#define R8A7795_PD_3DG_C		19
+#define R8A7795_PD_3DG_D		20
+#define R8A7795_PD_CA53_SCU		21
+#define R8A7795_PD_3DG_E		22
+#define R8A7795_PD_A3IR			24
+#define R8A7795_PD_A2VC0		25
+#define R8A7795_PD_A2VC1		26
+
+/* Always-on power area */
+#define R8A7795_PD_ALWAYS_ON		32
+
+#endif /* __DT_BINDINGS_POWER_R8A7795_SYSC_H__ */
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 7/7] soc: renesas: Add r8a7795 SYSC PM Domain Binding Definitions

[Laurent Pinchart]

Hi Geert,

Thank you for the patch.

On Wednesday 09 March 2016 20:18:42 Geert Uytterhoeven wrote:
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v3:
>   - New.
> ---
>  include/dt-bindings/power/r8a7795-sysc.h | 42 +++++++++++++++++++++++++++++
>  1 file changed, 42 insertions(+)
>  create mode 100644 include/dt-bindings/power/r8a7795-sysc.h
> 
> diff --git a/include/dt-bindings/power/r8a7795-sysc.h
> b/include/dt-bindings/power/r8a7795-sysc.h new file mode 100644
> index 0000000000000000..ee2e26ba605ef9a3
> --- /dev/null
> +++ b/include/dt-bindings/power/r8a7795-sysc.h
> @@ -0,0 +1,42 @@
> +/*
> + * Copyright (C) 2016 Glider bvba
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; version 2 of the License.
> + */
> +#ifndef __DT_BINDINGS_POWER_R8A7795_SYSC_H__
> +#define __DT_BINDINGS_POWER_R8A7795_SYSC_H__
> +
> +/*
> + * These power domain indices match the numbers of the interrupt bits
> + * representing the power areas in the various Interrupt Registers
> + * (e.g. SYSCISR, Interrupt Status Register)
> + */
> +
> +#define R8A7795_PD_CA57_CPU0		 0
> +#define R8A7795_PD_CA57_CPU1		 1
> +#define R8A7795_PD_CA57_CPU2		 2
> +#define R8A7795_PD_CA57_CPU3		 3
> +#define R8A7795_PD_CA53_CPU0		 5
> +#define R8A7795_PD_CA53_CPU1		 6
> +#define R8A7795_PD_CA53_CPU2		 7
> +#define R8A7795_PD_CA53_CPU3		 8
> +#define R8A7795_PD_A3VP			 9
> +#define R8A7795_PD_CA57_SCU		12
> +#define R8A7795_PD_CR7			13
> +#define R8A7795_PD_A3VC			14
> +#define R8A7795_PD_3DG_A		17
> +#define R8A7795_PD_3DG_B		18
> +#define R8A7795_PD_3DG_C		19
> +#define R8A7795_PD_3DG_D		20
> +#define R8A7795_PD_CA53_SCU		21
> +#define R8A7795_PD_3DG_E		22
> +#define R8A7795_PD_A3IR			24
> +#define R8A7795_PD_A2VC0		25
> +#define R8A7795_PD_A2VC1		26
> +
> +/* Always-on power area */
> +#define R8A7795_PD_ALWAYS_ON		32

Shouldn't we also define the always-on power domain for the other SoCs 
(patches 2/7 to 6/7 in this series) ? I know they're already covered by the 
cpg power domain, but going forward I believe that standardizing on the SYSC 
power domains would be beneficial. We of course have to keep backward 
compatibility in the implementation.

This isn't an issue for this patch, so

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> +#endif /* __DT_BINDINGS_POWER_R8A7795_SYSC_H__ */

-- 
Regards,

Laurent Pinchart

Re: [PATCH v3 7/7] soc: renesas: Add r8a7795 SYSC PM Domain Binding Definitions

[Geert Uytterhoeven]

Hi Laurent,

On Thu, Mar 10, 2016 at 3:32 AM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Wednesday 09 March 2016 20:18:42 Geert Uytterhoeven wrote:
>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

>> --- /dev/null
>> +++ b/include/dt-bindings/power/r8a7795-sysc.h
>> @@ -0,0 +1,42 @@

>> +/* Always-on power area */
>> +#define R8A7795_PD_ALWAYS_ON         32
>
> Shouldn't we also define the always-on power domain for the other SoCs
> (patches 2/7 to 6/7 in this series) ? I know they're already covered by the
> cpg power domain, but going forward I believe that standardizing on the SYSC
> power domains would be beneficial. We of course have to keep backward
> compatibility in the implementation.

Yes, that's the plan. I didn't want to make that change now, as someone
may object against the always-on power domain. On r8a7795 it feels more
natural, as it also has I/O devices in SYSC power areas, unlike R-Car Gen2
and H1.

Note that it also complicates the rcar-sysc core driver: it has to choose
between the cpg_mssr_*() or cpg_mstp_*() callbacks, depending on SoC, and also
depending on DTS if we migrate the older SoCs to CPG/MSSR and want to
maintain backwards-compatibility.

Time to finish the "renesas,apmu" enable-method work, and celebrate one big
flag day for all the new DT evolutions?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v3 7/7] soc: renesas: Add r8a7795 SYSC PM Domain Binding Definitions

[Laurent Pinchart]

Hi Geert,

On Thursday 10 March 2016 09:17:40 Geert Uytterhoeven wrote:
> On Thu, Mar 10, 2016 at 3:32 AM, Laurent Pinchart wrote:
> > On Wednesday 09 March 2016 20:18:42 Geert Uytterhoeven wrote:
> >> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >> 
> >> --- /dev/null
> >> +++ b/include/dt-bindings/power/r8a7795-sysc.h
> >> @@ -0,0 +1,42 @@
> >> 
> >> +/* Always-on power area */
> >> +#define R8A7795_PD_ALWAYS_ON         32
> > 
> > Shouldn't we also define the always-on power domain for the other SoCs
> > (patches 2/7 to 6/7 in this series) ? I know they're already covered by
> > the cpg power domain, but going forward I believe that standardizing on
> > the SYSC power domains would be beneficial. We of course have to keep
> > backward compatibility in the implementation.
> 
> Yes, that's the plan. I didn't want to make that change now, as someone
> may object against the always-on power domain. On r8a7795 it feels more
> natural, as it also has I/O devices in SYSC power areas, unlike R-Car Gen2
> and H1.

That's fine with me.

> Note that it also complicates the rcar-sysc core driver: it has to choose
> between the cpg_mssr_*() or cpg_mstp_*() callbacks, depending on SoC, and
> also depending on DTS if we migrate the older SoCs to CPG/MSSR and want to
> maintain backwards-compatibility.
> 
> Time to finish the "renesas,apmu" enable-method work, and celebrate one big
> flag day for all the new DT evolutions?

I'll bring champagne ;-)

-- 
Regards,

Laurent Pinchart

[PATCH v3 2/7] soc: renesas: Add r8a7779 SYSC PM Domain Binding Definitions

[Geert Uytterhoeven]

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v3:
  - New.
---
 include/dt-bindings/power/r8a7779-sysc.h | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)
 create mode 100644 include/dt-bindings/power/r8a7779-sysc.h

diff --git a/include/dt-bindings/power/r8a7779-sysc.h b/include/dt-bindings/power/r8a7779-sysc.h
new file mode 100644
index 0000000000000000..6b66612d1260d396
--- /dev/null
+++ b/include/dt-bindings/power/r8a7779-sysc.h
@@ -0,0 +1,25 @@
+/*
+ * Copyright (C) 2016 Glider bvba
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ */
+#ifndef __DT_BINDINGS_POWER_R8A7779_SYSC_H__
+#define __DT_BINDINGS_POWER_R8A7779_SYSC_H__
+
+/*
+ * These power domain indices match the numbers of the interrupt bits
+ * representing the power areas in the various Interrupt Registers
+ * (e.g. SYSCISR, Interrupt Status Register)
+ */
+
+#define R8A7779_PD_ARM1			 1
+#define R8A7779_PD_ARM2			 2
+#define R8A7779_PD_ARM3			 3
+#define R8A7779_PD_SH			16
+#define R8A7779_PD_SGX			20
+#define R8A7779_PD_VDP			21
+#define R8A7779_PD_IMP			24
+
+#endif /* __DT_BINDINGS_POWER_R8A7779_SYSC_H__ */
-- 
1.9.1

Re: [PATCH v3 2/7] soc: renesas: Add r8a7779 SYSC PM Domain Binding Definitions

[Laurent Pinchart]

Hi Geert,

Thank you for the patch.

On Wednesday 09 March 2016 20:18:37 Geert Uytterhoeven wrote:
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v3:
>   - New.
> ---
>  include/dt-bindings/power/r8a7779-sysc.h | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>  create mode 100644 include/dt-bindings/power/r8a7779-sysc.h
> 
> diff --git a/include/dt-bindings/power/r8a7779-sysc.h
> b/include/dt-bindings/power/r8a7779-sysc.h new file mode 100644
> index 0000000000000000..6b66612d1260d396
> --- /dev/null
> +++ b/include/dt-bindings/power/r8a7779-sysc.h
> @@ -0,0 +1,25 @@
> +/*
> + * Copyright (C) 2016 Glider bvba
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; version 2 of the License.
> + */
> +#ifndef __DT_BINDINGS_POWER_R8A7779_SYSC_H__
> +#define __DT_BINDINGS_POWER_R8A7779_SYSC_H__
> +
> +/*
> + * These power domain indices match the numbers of the interrupt bits
> + * representing the power areas in the various Interrupt Registers
> + * (e.g. SYSCISR, Interrupt Status Register)
> + */
> +
> +#define R8A7779_PD_ARM1			 1
> +#define R8A7779_PD_ARM2			 2
> +#define R8A7779_PD_ARM3			 3
> +#define R8A7779_PD_SH			16

I don't see this power domain in version 0.6 of the datasheet, you might have 
a more recent version than I do.

Apart from that,

Reveiwed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> +#define R8A7779_PD_SGX			20
> +#define R8A7779_PD_VDP			21
> +#define R8A7779_PD_IMP			24
> +
> +#endif /* __DT_BINDINGS_POWER_R8A7779_SYSC_H__ */

-- 
Regards,

Laurent Pinchart

Re: [PATCH v3 2/7] soc: renesas: Add r8a7779 SYSC PM Domain Binding Definitions

[Geert Uytterhoeven]

Hi Laurent,

On Thu, Mar 10, 2016 at 3:40 AM, Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
> On Wednesday 09 March 2016 20:18:37 Geert Uytterhoeven wrote:
>> --- /dev/null
>> +++ b/include/dt-bindings/power/r8a7779-sysc.h

>> +#define R8A7779_PD_SH                        16
>
> I don't see this power domain in version 0.6 of the datasheet, you might have
> a more recent version than I do.

It's indeed not in the datasheet.
I based it's presence on the value written to SYSCIER, which has bit 16 set,
both in upstream and in the BSP.

Perhaps Magnus knows, as he's the author of that code?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH v3 5/7] soc: renesas: Add r8a7793 SYSC PM Domain Binding Definitions

[Geert Uytterhoeven]

R-Car M2-N is identical to R-Car M2-W w.r.t. power domains, so reuse the
definitions from the latter.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v3:
  - New.
---
 include/dt-bindings/power/r8a7793-sysc.h | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)
 create mode 100644 include/dt-bindings/power/r8a7793-sysc.h

diff --git a/include/dt-bindings/power/r8a7793-sysc.h b/include/dt-bindings/power/r8a7793-sysc.h
new file mode 100644
index 0000000000000000..c2cc74cf06d653ed
--- /dev/null
+++ b/include/dt-bindings/power/r8a7793-sysc.h
@@ -0,0 +1,27 @@
+/*
+ * Copyright (C) 2016 Glider bvba
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ */
+#ifndef __DT_BINDINGS_POWER_R8A7793_SYSC_H__
+#define __DT_BINDINGS_POWER_R8A7793_SYSC_H__
+
+/*
+ * These power domain indices match the numbers of the interrupt bits
+ * representing the power areas in the various Interrupt Registers
+ * (e.g. SYSCISR, Interrupt Status Register)
+ *
+ * R-Car M2-N is identical to R-Car M2-W w.r.t. power domains.
+ */
+
+#include "r8a7791-sysc.h"
+
+#define R8A7793_PD_CA15_CPU0		R8A7791_PD_CA15_CPU0
+#define R8A7793_PD_CA15_CPU1		R8A7791_PD_CA15_CPU1
+#define R8A7793_PD_CA15_SCU		R8A7791_PD_CA15_SCU
+#define R8A7793_PD_SH			R8A7791_PD_SH
+#define R8A7793_PD_SGX			R8A7791_PD_SGX
+
+#endif /* __DT_BINDINGS_POWER_R8A7793_SYSC_H__ */
-- 
1.9.1

Re: [PATCH v3 5/7] soc: renesas: Add r8a7793 SYSC PM Domain Binding Definitions

[Laurent Pinchart]

Hi Geert,

Thank you for the patch.

On Wednesday 09 March 2016 20:18:40 Geert Uytterhoeven wrote:
> R-Car M2-N is identical to R-Car M2-W w.r.t. power domains, so reuse the
> definitions from the latter.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v3:
>   - New.
> ---
>  include/dt-bindings/power/r8a7793-sysc.h | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>  create mode 100644 include/dt-bindings/power/r8a7793-sysc.h
> 
> diff --git a/include/dt-bindings/power/r8a7793-sysc.h
> b/include/dt-bindings/power/r8a7793-sysc.h new file mode 100644
> index 0000000000000000..c2cc74cf06d653ed
> --- /dev/null
> +++ b/include/dt-bindings/power/r8a7793-sysc.h
> @@ -0,0 +1,27 @@
> +/*
> + * Copyright (C) 2016 Glider bvba
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; version 2 of the License.
> + */
> +#ifndef __DT_BINDINGS_POWER_R8A7793_SYSC_H__
> +#define __DT_BINDINGS_POWER_R8A7793_SYSC_H__
> +
> +/*
> + * These power domain indices match the numbers of the interrupt bits
> + * representing the power areas in the various Interrupt Registers
> + * (e.g. SYSCISR, Interrupt Status Register)
> + *
> + * R-Car M2-N is identical to R-Car M2-W w.r.t. power domains.
> + */
> +
> +#include "r8a7791-sysc.h"
> +
> +#define R8A7793_PD_CA15_CPU0		R8A7791_PD_CA15_CPU0
> +#define R8A7793_PD_CA15_CPU1		R8A7791_PD_CA15_CPU1
> +#define R8A7793_PD_CA15_SCU		R8A7791_PD_CA15_SCU
> +#define R8A7793_PD_SH			R8A7791_PD_SH
> +#define R8A7793_PD_SGX			R8A7791_PD_SGX

I would use numbers directly without including r8a7791-sysc.h, it would save 
going through yet another file when looking for the numerical value.

> +
> +#endif /* __DT_BINDINGS_POWER_R8A7793_SYSC_H__ */

-- 
Regards,

Laurent Pinchart

Re: [PATCH v3 5/7] soc: renesas: Add r8a7793 SYSC PM Domain Binding Definitions

[Geert Uytterhoeven]

Hi Laurent,

On Thu, Mar 10, 2016 at 7:59 AM, Laurent Pinchart
<laurent.pinchart-ryLnwIuWjnjg/C1BVhZhaw@public.gmane.org> wrote:
> On Wednesday 09 March 2016 20:18:40 Geert Uytterhoeven wrote:
>> R-Car M2-N is identical to R-Car M2-W w.r.t. power domains, so reuse the
>> definitions from the latter.
>>
>> Signed-off-by: Geert Uytterhoeven <geert+renesas-gXvu3+zWzMSzQB+pC5nmwQ@public.gmane.org>

>> --- /dev/null
>> +++ b/include/dt-bindings/power/r8a7793-sysc.h
>> @@ -0,0 +1,27 @@
>> +/*
>> + * Copyright (C) 2016 Glider bvba
>> + *
>> + * This program is free software; you can redistribute it and/or modify
>> + * it under the terms of the GNU General Public License as published by
>> + * the Free Software Foundation; version 2 of the License.
>> + */
>> +#ifndef __DT_BINDINGS_POWER_R8A7793_SYSC_H__
>> +#define __DT_BINDINGS_POWER_R8A7793_SYSC_H__
>> +
>> +/*
>> + * These power domain indices match the numbers of the interrupt bits
>> + * representing the power areas in the various Interrupt Registers
>> + * (e.g. SYSCISR, Interrupt Status Register)
>> + *
>> + * R-Car M2-N is identical to R-Car M2-W w.r.t. power domains.
>> + */
>> +
>> +#include "r8a7791-sysc.h"
>> +
>> +#define R8A7793_PD_CA15_CPU0         R8A7791_PD_CA15_CPU0
>> +#define R8A7793_PD_CA15_CPU1         R8A7791_PD_CA15_CPU1
>> +#define R8A7793_PD_CA15_SCU          R8A7791_PD_CA15_SCU
>> +#define R8A7793_PD_SH                        R8A7791_PD_SH
>> +#define R8A7793_PD_SGX                       R8A7791_PD_SGX
>
> I would use numbers directly without including r8a7791-sysc.h, it would save
> going through yet another file when looking for the numerical value.

My main motivation of doing it this way is that r8a7791-sysc.c is also used
on r8a7793, and thus uses the R8A7791_PD_* values directly.

But if you prefer it this way, I can make that change.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 5/7] soc: renesas: Add r8a7793 SYSC PM Domain Binding Definitions

[Geert Uytterhoeven]

On Thu, Mar 10, 2016 at 9:09 AM, Geert Uytterhoeven
<geert@linux-m68k.org> wrote:
> On Thu, Mar 10, 2016 at 7:59 AM, Laurent Pinchart
> <laurent.pinchart@ideasonboard.com> wrote:
>> On Wednesday 09 March 2016 20:18:40 Geert Uytterhoeven wrote:
>>> R-Car M2-N is identical to R-Car M2-W w.r.t. power domains, so reuse the
>>> definitions from the latter.
>>>
>>> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
>>> --- /dev/null
>>> +++ b/include/dt-bindings/power/r8a7793-sysc.h
>>> @@ -0,0 +1,27 @@
>>> +/*
>>> + * Copyright (C) 2016 Glider bvba
>>> + *
>>> + * This program is free software; you can redistribute it and/or modify
>>> + * it under the terms of the GNU General Public License as published by
>>> + * the Free Software Foundation; version 2 of the License.
>>> + */
>>> +#ifndef __DT_BINDINGS_POWER_R8A7793_SYSC_H__
>>> +#define __DT_BINDINGS_POWER_R8A7793_SYSC_H__
>>> +
>>> +/*
>>> + * These power domain indices match the numbers of the interrupt bits
>>> + * representing the power areas in the various Interrupt Registers
>>> + * (e.g. SYSCISR, Interrupt Status Register)
>>> + *
>>> + * R-Car M2-N is identical to R-Car M2-W w.r.t. power domains.
>>> + */
>>> +
>>> +#include "r8a7791-sysc.h"
>>> +
>>> +#define R8A7793_PD_CA15_CPU0         R8A7791_PD_CA15_CPU0
>>> +#define R8A7793_PD_CA15_CPU1         R8A7791_PD_CA15_CPU1
>>> +#define R8A7793_PD_CA15_SCU          R8A7791_PD_CA15_SCU
>>> +#define R8A7793_PD_SH                        R8A7791_PD_SH
>>> +#define R8A7793_PD_SGX                       R8A7791_PD_SGX
>>
>> I would use numbers directly without including r8a7791-sysc.h, it would save
>> going through yet another file when looking for the numerical value.
>
> My main motivation of doing it this way is that r8a7791-sysc.c is also used
> on r8a7793, and thus uses the R8A7791_PD_* values directly.
>
> But if you prefer it this way, I can make that change.

Upon second thought, I'll follow Laurent's advice, as it makes r8a7793-sysc.h
self-contained.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

[PATCH v3 6/7] soc: renesas: Add r8a7794 SYSC PM Domain Binding Definitions

[Geert Uytterhoeven]

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v3:
  - New.
---
 include/dt-bindings/power/r8a7794-sysc.h | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
 create mode 100644 include/dt-bindings/power/r8a7794-sysc.h

diff --git a/include/dt-bindings/power/r8a7794-sysc.h b/include/dt-bindings/power/r8a7794-sysc.h
new file mode 100644
index 0000000000000000..bbe54e977e05bdd1
--- /dev/null
+++ b/include/dt-bindings/power/r8a7794-sysc.h
@@ -0,0 +1,23 @@
+/*
+ * Copyright (C) 2016 Glider bvba
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; version 2 of the License.
+ */
+#ifndef __DT_BINDINGS_POWER_R8A7794_SYSC_H__
+#define __DT_BINDINGS_POWER_R8A7794_SYSC_H__
+
+/*
+ * These power domain indices match the numbers of the interrupt bits
+ * representing the power areas in the various Interrupt Registers
+ * (e.g. SYSCISR, Interrupt Status Register)
+ */
+
+#define R8A7794_PD_CA7_CPU0		 5
+#define R8A7794_PD_CA7_CPU1		 6
+#define R8A7794_PD_SH			16
+#define R8A7794_PD_SGX			20
+#define R8A7794_PD_CA7_SCU		21
+
+#endif /* __DT_BINDINGS_POWER_R8A7794_SYSC_H__ */
-- 
1.9.1

Re: [PATCH v3 6/7] soc: renesas: Add r8a7794 SYSC PM Domain Binding Definitions

[Laurent Pinchart]

Hi Geert,

Thank you for the patch.

On Wednesday 09 March 2016 20:18:41 Geert Uytterhoeven wrote:
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v3:
>   - New.
> ---
>  include/dt-bindings/power/r8a7794-sysc.h | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>  create mode 100644 include/dt-bindings/power/r8a7794-sysc.h
> 
> diff --git a/include/dt-bindings/power/r8a7794-sysc.h
> b/include/dt-bindings/power/r8a7794-sysc.h new file mode 100644
> index 0000000000000000..bbe54e977e05bdd1
> --- /dev/null
> +++ b/include/dt-bindings/power/r8a7794-sysc.h
> @@ -0,0 +1,23 @@
> +/*
> + * Copyright (C) 2016 Glider bvba
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; version 2 of the License.
> + */
> +#ifndef __DT_BINDINGS_POWER_R8A7794_SYSC_H__
> +#define __DT_BINDINGS_POWER_R8A7794_SYSC_H__
> +
> +/*
> + * These power domain indices match the numbers of the interrupt bits
> + * representing the power areas in the various Interrupt Registers
> + * (e.g. SYSCISR, Interrupt Status Register)
> + */
> +
> +#define R8A7794_PD_CA7_CPU0		 5
> +#define R8A7794_PD_CA7_CPU1		 6
> +#define R8A7794_PD_SH			16

This power domain is called SH-4A in the data sheet, you might want to name it 
R8A7794_PD_SH_4A.

Apart from that,

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> +#define R8A7794_PD_SGX			20
> +#define R8A7794_PD_CA7_SCU		21
> +
> +#endif /* __DT_BINDINGS_POWER_R8A7794_SYSC_H__ */

-- 
Regards,

Laurent Pinchart