From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Lan Tianyu <tianyu.lan@intel.com>
Cc: viresh.kumar@linaro.org, cpufreq@vger.kernel.org,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [Update PATCH 1/1] Cpufreq: Make governor data on nonboot cpus across system suspend/resume
Date: Sat, 16 Nov 2013 16:09:44 +0100 [thread overview]
Message-ID: <2541765.pYv7UXDJWx@vostro.rjw.lan> (raw)
In-Reply-To: <9847309.KdKOG5y1Zx@vostro.rjw.lan>
On Saturday, November 16, 2013 03:41:10 PM Rafael J. Wysocki wrote:
[...]
> > >> @@ -1822,6 +1822,9 @@ static int __cpufreq_governor(struct cpufreq_policy *policy,
> > >> ((event == CPUFREQ_GOV_POLICY_EXIT) && !ret))
> > >> module_put(policy->governor->owner);
> > >>
> > >> + if ((event == CPUFREQ_GOV_POLICY_INIT) && ret == -EALREADY)
> > >> + ret = 0;
> > >> +
>
> -> I'd prefer this check to be combined with the one done to determine whether
> or not we need to do the module_put(). Something like
>
> if (event == CPUFREQ_GOV_POLICY_EXIT && ret) {
Obviously, that should be:
if (event == CPUFREQ_GOV_POLICY_INIT && ret) {
> module_put(policy->governor->owner);
> if (ret == -EALREADY)
> return 0;
> } else if (event == CPUFREQ_GOV_POLICY_EXIT && !ret) {
> module_put(policy->governor->owner);
> }
Sorry for the confusion.
Thanks!
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2013-11-16 15:09 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-15 6:01 [PATCH 1/1] Cpufreq: Make governor data on nonboot cpus across system syspend/resume Lan Tianyu
2013-11-15 8:15 ` [Update PATCH 1/1] Cpufreq: Make governor data on nonboot cpus across system suspend/resume Lan Tianyu
2013-11-15 10:22 ` Viresh Kumar
2013-11-16 4:33 ` Lan Tianyu
2013-11-15 10:54 ` Viresh Kumar
2013-11-16 5:24 ` viresh kumar
2013-11-16 0:38 ` Rafael J. Wysocki
2013-11-16 3:59 ` Lan Tianyu
2013-11-16 14:41 ` Rafael J. Wysocki
2013-11-16 14:57 ` Viresh Kumar
2013-11-16 15:10 ` Rafael J. Wysocki
2013-11-16 15:09 ` Rafael J. Wysocki [this message]
2013-11-16 15:23 ` Lan Tianyu
2013-11-16 15:36 ` [PATCH V2] " Lan Tianyu
2013-11-17 4:13 ` viresh kumar
2013-11-17 14:44 ` Rafael J. Wysocki
2013-11-17 16:23 ` Viresh Kumar
2013-11-22 7:49 ` viresh kumar
2013-11-22 8:19 ` Lan Tianyu
2013-11-22 8:39 ` Viresh Kumar
2013-11-21 14:43 ` Rafael J. Wysocki
2013-11-21 15:54 ` Viresh Kumar
2013-11-21 21:43 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2541765.pYv7UXDJWx@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=cpufreq@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=tianyu.lan@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox