From: Thomas Renninger <trenn@suse.de>
To: Dmitry Shachnev <mitya57@debian.org>
Cc: linux-pm@vger.kernel.org
Subject: Re: [PATCH] cpupower: Install cpupower.h as a public header file
Date: Tue, 17 Oct 2017 10:29:23 +0200 [thread overview]
Message-ID: <2594649.cpXK6EFXZg@skinner> (raw)
In-Reply-To: <20171016185004.zyq6eugwedc34f7l@mitya57.me>
On Monday, October 16, 2017 09:50:04 PM Dmitry Shachnev wrote:
> This helps software that uses cpupower_is_cpu_online function, such as
> gnome-applets.
Can you give it a try or confirm that the CPU topology list/functions also
work as intended if used as an external library, please.
And whether they are written to be easily used and understood or whether
the interface could still be enhanced.
If things work as expected by others, it's certainly a good idea to publish
these.
Thanks,
Thomas
>
> Signed-off-by: Dmitry Shachnev <mitya57@debian.org>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=153161
> ---
> tools/power/cpupower/Makefile | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/tools/power/cpupower/Makefile b/tools/power/cpupower/Makefile
> index 4c5a481a850c..113e14983c7d 100644
> --- a/tools/power/cpupower/Makefile
> +++ b/tools/power/cpupower/Makefile
> @@ -278,6 +278,7 @@ install-lib:
> $(INSTALL) -d $(DESTDIR)${includedir}
> $(INSTALL_DATA) lib/cpufreq.h $(DESTDIR)${includedir}/cpufreq.h
> $(INSTALL_DATA) lib/cpuidle.h $(DESTDIR)${includedir}/cpuidle.h
> + $(INSTALL_DATA) lib/cpupower.h $(DESTDIR)${includedir}/cpupower.h
>
> install-tools:
> $(INSTALL) -d $(DESTDIR)${bindir}
> @@ -314,6 +315,7 @@ uninstall:
> - rm -f $(DESTDIR)${libdir}/libcpupower.*
> - rm -f $(DESTDIR)${includedir}/cpufreq.h
> - rm -f $(DESTDIR)${includedir}/cpuidle.h
> + - rm -f $(DESTDIR)${includedir}/cpupower.h
> - rm -f $(DESTDIR)${bindir}/utils/cpupower
> - rm -f $(DESTDIR)${mandir}/man1/cpupower.1
> - rm -f $(DESTDIR)${mandir}/man1/cpupower-frequency-set.1
>
next prev parent reply other threads:[~2017-10-17 8:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 18:50 [PATCH] cpupower: Install cpupower.h as a public header file Dmitry Shachnev
2017-10-17 8:29 ` Thomas Renninger [this message]
2017-10-17 19:53 ` Dmitry Shachnev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2594649.cpXK6EFXZg@skinner \
--to=trenn@suse.de \
--cc=linux-pm@vger.kernel.org \
--cc=mitya57@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox