From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83EAFC2D0D3 for ; Mon, 30 Dec 2019 12:10:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5B5F02080A for ; Mon, 30 Dec 2019 12:10:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727417AbfL3MKG (ORCPT ); Mon, 30 Dec 2019 07:10:06 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:54964 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727400AbfL3MKG (ORCPT ); Mon, 30 Dec 2019 07:10:06 -0500 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id C8FC8D8A95EED0F8C0E1; Mon, 30 Dec 2019 20:10:00 +0800 (CST) Received: from [127.0.0.1] (10.177.223.23) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.439.0; Mon, 30 Dec 2019 20:09:55 +0800 Subject: Re: [PATCH 1/2] cpufreq : cppc: Break out if we match the HiSilicon cppc workaround To: "Rafael J. Wysocki" CC: "Rafael J. Wysocki" , Viresh Kumar , , , Xiongfeng Wang References: <1577152590-25574-1-git-send-email-guohanjun@huawei.com> <2965934.S1MOicRWCW@kreacher> From: Hanjun Guo Message-ID: <25ced2e7-426b-be14-326f-076e01f9e2e7@huawei.com> Date: Mon, 30 Dec 2019 20:10:17 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <2965934.S1MOicRWCW@kreacher> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.223.23] X-CFilter-Loop: Reflected Sender: linux-pm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 2019/12/30 6:47, Rafael J. Wysocki wrote: > On Tuesday, December 24, 2019 2:56:29 AM CET Hanjun Guo wrote: >> Bail out if we match the OEM information, to save some possible >> extra iteration. And update the code to fix minor coding style issue. >> >> Signed-off-by: Hanjun Guo >> --- >> drivers/cpufreq/cppc_cpufreq.c | 6 ++++-- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/cpufreq/cppc_cpufreq.c b/drivers/cpufreq/cppc_cpufreq.c >> index 8d8da76..d0ca300 100644 >> --- a/drivers/cpufreq/cppc_cpufreq.c >> +++ b/drivers/cpufreq/cppc_cpufreq.c >> @@ -39,7 +39,7 @@ >> static struct cppc_cpudata **all_cpu_data; >> >> struct cppc_workaround_oem_info { >> - char oem_id[ACPI_OEM_ID_SIZE +1]; >> + char oem_id[ACPI_OEM_ID_SIZE + 1]; >> char oem_table_id[ACPI_OEM_TABLE_ID_SIZE + 1]; >> u32 oem_revision; >> }; >> @@ -93,8 +93,10 @@ static void cppc_check_hisi_workaround(void) >> for (i = 0; i < ARRAY_SIZE(wa_info); i++) { >> if (!memcmp(wa_info[i].oem_id, tbl->oem_id, ACPI_OEM_ID_SIZE) && >> !memcmp(wa_info[i].oem_table_id, tbl->oem_table_id, ACPI_OEM_TABLE_ID_SIZE) && >> - wa_info[i].oem_revision == tbl->oem_revision) >> + wa_info[i].oem_revision == tbl->oem_revision) { >> apply_hisi_workaround = true; >> + break; >> + } >> } >> } >> >> > > Both this and the [2/2] applies as 5.6 material with reworked > subjects and changelog changes. Thanks! Much better for the reworked subject and changelog, thank you very much! Hanjun