From: Thomas Renninger <trenn@suse.de>
To: Prarit Bhargava <prarit@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] tools, cpupower, fix return checks for sysfs_get_idlestate_count()
Date: Wed, 03 Dec 2014 19:25:25 +0100 [thread overview]
Message-ID: <2645048.kv31YXMmsb@skinner> (raw)
In-Reply-To: <1417444762-26450-1-git-send-email-prarit@redhat.com>
On Monday, December 01, 2014 09:39:22 AM Prarit Bhargava wrote:
> Red Hat and Fedora use a bug reporting tool that gathers data about
> "broken" systems called sosreport. Among other things, it includes the
> output of 'cpupower idle-info'. Executing 'cpupower idle-info' on a
> system that has cpuidle disabled via 'cpuidle.off=1' results in a 300
> second hang in the cpupower application.
>
> ie)
> [root@intel-brickland-05]# cpupower idle-info
> Could not determine cpuidle driver
>
> Analyzing CPU 0:
> Number of idle states: -19
> [hang]
>
> The problem is that the cpupower code only checks for a zero return from
> sysfs_get_idlestate_count(). The function can return -ENODEV (-19) as
> above. This patch fixes callers to sysfs_get_idlestate_count() to check
> the right return values.
>
> Cc: Thomas Renninger <trenn@suse.de>
> Cc: linux-pm@vger.kernel.org
> Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Signed-off-by: Thomas Renninger <trenn@suse.de>
prev parent reply other threads:[~2014-12-03 18:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 14:39 [PATCH] tools, cpupower, fix return checks for sysfs_get_idlestate_count() Prarit Bhargava
2014-12-03 18:25 ` Thomas Renninger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2645048.kv31YXMmsb@skinner \
--to=trenn@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=prarit@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).