From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB0F8CD6118 for ; Mon, 9 Oct 2023 17:24:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1377579AbjJIRYx (ORCPT ); Mon, 9 Oct 2023 13:24:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377258AbjJIRYw (ORCPT ); Mon, 9 Oct 2023 13:24:52 -0400 Received: from mail-pg1-x529.google.com (mail-pg1-x529.google.com [IPv6:2607:f8b0:4864:20::529]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0C569A3; Mon, 9 Oct 2023 10:24:51 -0700 (PDT) Received: by mail-pg1-x529.google.com with SMTP id 41be03b00d2f7-578d0d94986so3492567a12.2; Mon, 09 Oct 2023 10:24:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1696872290; x=1697477090; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=hzAdnPv6S7wemZW2LOvDdjej33oUOA4jt9qFcygegX8=; b=VcdmRB5Jyqw8aqvnps3ZcNESprEZdvjdfZIHohOck7OQ+ebTQDRRCAy5hDXxTGcBdW JEWThpfElMZZN6U7JsjnB5HH54J80NACyeKE3UbKbZCn6+bgBpt9Aa1leQHU85YufaMy iQbTWQUTq0Vw6PZIvJa8rUjjqanvgZw0ric83OoIZNRhValzcMsodZT/47Hl3oaBzBMQ lkWwnvITABSzqb1v73HekQEZSg75DYG95nUNBS76vzSMiaO355GiFoXRORwaIzvHlSY/ lezXmO1mxVPjyoBpb0fCiRcp1Wj/dvqoRpvGHK2Ym2SJmFrC5rORF6cLNIyUSGCYQpUH sQ+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696872290; x=1697477090; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=hzAdnPv6S7wemZW2LOvDdjej33oUOA4jt9qFcygegX8=; b=E75aMKFKTiQieeU28mkZ0AbzQI0IkhDi/5k6iSZUO4uEQRPyndpw/RP/bMRy0LatgT WNjaqRl9zR00QX9R+2jNiyfnX/le48V2g+BqCl82r4X7Imz28nfLbdxAWXcLZEWB2Sie mgHCOp5O5xt3SzjydAT2LU0bEv7O9xG7HoTZIIu4MQvm+PvS1SDmVpqPVTIGwgQBQLxx bZwHFAQi1F9kX1yw7i//D3ZrID6KW4ovplI0wQHJkUw5DldcGPS+WXy/yeKc77nhD7T1 fj463MYoENIbQb8wN/hHa5UfvECy2Js/lAGt+dVVqNynDrGbDnfSEWJz5KRs0y5wEmg1 P4+A== X-Gm-Message-State: AOJu0YwljsRwStMLikM9hRsaj+osT/BPLN2bOmDZ3tRZgPgxdpg2A6mM 3vXfkBbcyOkgLonNJwuH7Qw= X-Google-Smtp-Source: AGHT+IH+tyPqS70qDikWknMDjzYLaNh8XUrbid6v4dI3mkvPqY7I02GkSEKBPm73V9X3Q4ayZd0Azg== X-Received: by 2002:a05:6a20:8e05:b0:162:4f45:b415 with SMTP id y5-20020a056a208e0500b001624f45b415mr20823608pzj.51.1696872290343; Mon, 09 Oct 2023 10:24:50 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id m24-20020a17090a7f9800b0027b168cb011sm8557487pjl.56.2023.10.09.10.24.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Oct 2023 10:24:49 -0700 (PDT) Sender: Guenter Roeck Date: Mon, 9 Oct 2023 10:24:48 -0700 From: Guenter Roeck To: Max Kellermann Cc: Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Borislav Petkov , Tony Luck , James Morse , Mauro Carvalho Chehab , Robert Richter , Jean Delvare , Jason Gunthorpe , Leon Romanovsky , Bart Van Assche , Joerg Roedel , Will Deacon , Robin Murphy , Dan Williams , Vishal Verma , Dave Jiang , Ira Weiny , Keith Busch , Christoph Hellwig , Sagi Grimberg , Alessandro Zummo , Alexandre Belloni , Jiri Slaby , Suzuki K Poulose , Mike Leach , James Clark , Leo Yan , Thomas Gleixner , Peter Zijlstra , Pavel Machek , Lee Jones , Arnd Bergmann , Bjorn Helgaas , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Sebastian Reichel , Krzysztof Kozlowski , Wim Van Sebroeck , "James E.J. Bottomley" , "Martin K. Petersen" , linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-hwmon@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, nvdimm@lists.linux.dev, linux-nvme@lists.infradead.org, linux-rtc@vger.kernel.org, linux-serial@vger.kernel.org, coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-leds@vger.kernel.org, linux-pci@vger.kernel.org, linux-perf-users@vger.kernel.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-scsi@vger.kernel.org Subject: Re: [PATCH 6/7] fs/sysfs/group: make attribute_group pointers const Message-ID: <264fa39d-aed6-4a54-a085-107997078f8d@roeck-us.net> References: <20231009165741.746184-1-max.kellermann@ionos.com> <20231009165741.746184-6-max.kellermann@ionos.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231009165741.746184-6-max.kellermann@ionos.com> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Mon, Oct 09, 2023 at 06:57:39PM +0200, Max Kellermann wrote: > This allows passing arrays of const pointers. The goal is to make > lots of global variables "const" to allow them to live in the > ".rodata" section. > > Signed-off-by: Max Kellermann In my opinion this touches way too many subsystems in a single patch. If someting is wrong with just one of the changes, it will be all but impossible to revert the whole thing. Also, I don't know why checkpatch is happy with all the const struct attribute_group *const*groups; instead of const struct attribute_group *const *groups; but I still don't like it. Guenter