From: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
To: Lukasz Luba <lukasz.luba@arm.com>
Cc: rui.zhang@intel.com, linux-pm@vger.kernel.org,
jonathanh@nvidia.com, linux-tegra@vger.kernel.org,
thierry.reding@gmail.com, rafael@kernel.org,
daniel.lezcano@kernel.org
Subject: Re: [PATCH 1/2] drivers/thermal/tegra/soctherm: Use devm_add_action_or_reset() for clock disable
Date: Wed, 6 May 2026 12:27:33 +0200 [thread overview]
Message-ID: <2740bf17-27b5-4a68-8eaf-589252a84436@oss.qualcomm.com> (raw)
In-Reply-To: <c45c96a3-535c-4374-b9b2-cf75240a8b05@arm.com>
On 5/6/26 12:26, Lukasz Luba wrote:
> Hi Daniel,
>
> On 5/6/26 10:37, Daniel Lezcano wrote:
>> On 5/5/26 14:10, Daniel Lezcano wrote:
>>> On 4/24/26 18:00, Daniel Lezcano wrote:
>>>> Replace the manual error handling paths disabling the clocks with
>>>> devm_add_action_or_reset(). This ensures the clocks are properly
>>>> disabled on probe failure and driver removal, while simplifying the
>>>> code by removing the explicit error paths.
>>>>
>>>> Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
>>>> ---
>>>
>>> If nobody is against these two changes, I'll apply them
>>>
>>> Thanks
>>>
>>> -- Daniel
>>>
>>
>> Applied, thanks
>
> My apologies for being late. The changes make perfect sense.
> Feel free to add to both patches:
>
> Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
Thanks for the review
prev parent reply other threads:[~2026-05-06 10:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-24 16:00 [PATCH 1/2] drivers/thermal/tegra/soctherm: Use devm_add_action_or_reset() for clock disable Daniel Lezcano
2026-04-24 16:00 ` [PATCH 2/2] thermal/drivers/tegra/soctherma: Switch to devm cooling device registration Daniel Lezcano
2026-05-05 12:10 ` [PATCH 1/2] drivers/thermal/tegra/soctherm: Use devm_add_action_or_reset() for clock disable Daniel Lezcano
2026-05-06 9:37 ` Daniel Lezcano
2026-05-06 10:26 ` Lukasz Luba
2026-05-06 10:27 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2740bf17-27b5-4a68-8eaf-589252a84436@oss.qualcomm.com \
--to=daniel.lezcano@oss.qualcomm.com \
--cc=daniel.lezcano@kernel.org \
--cc=jonathanh@nvidia.com \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox