Re: [PATCH v2 1/4] nvmem: rockchip-efuse: Change initcall to subsys

Heiko Stuebner
2016-08-18T22:29:55Z

Am Donnerstag, 18. August 2016, 13:28:58 CEST schrieb Kevin Hilman:
> Finlye Xiao <finley.xiao-TNX95d0MmH7DzftRWevZcw@public.gmane.org> writes:
> > From: Finley Xiao <finley.xiao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
> >
> > We will register a cpufreq notifier for adjusting opp's voltage, and it
> > need to fetch cpu's leakage from efuse in the notifier_call. so the efuse
> > driver should probe before cpufreq driver.
> >
> > Signed-off-by: Finley Xiao <finley.xiao-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
>
> Why can't this be handled with deferred probling? initcall ordering is
> a can of worms.

I think the issue is less between efuse and avs driver, but more between avs
driver and cpufreq. The avs driver aims to modify the opp table and thus wants
to do that / register the notifier before cpufreq starts.

And as there is no direct connection between cpufreq and the avs driver,
making cpufreq defer probing is probably not really easy.