Linux Power Management development
 help / color / mirror / Atom feed
From: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
To: Anvesh Jain P <anvesh.p@oss.qualcomm.com>, rafael@kernel.org
Cc: Zhang Rui <rui.zhang@intel.com>,
	Lukasz Luba <lukasz.luba@arm.com>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Ulf Hansson <ulf.hansson@oss.qualcomm.com>,
	linux-pm@vger.kernel.org,
	Daniel Lezcano <daniel.lezcano@kernel.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v1 06/12] thermal: core: Calculate aggregated thermal zone temperatures
Date: Thu, 19 Nov 2026 16:22:49 +0100	[thread overview]
Message-ID: <284f2947-28d9-4d30-87df-eb224ccc0a73@oss.qualcomm.com> (raw)
In-Reply-To: <2c6e86e7-734b-47ab-8699-aa07b5a35e63@oss.qualcomm.com>


Hi Anvesh,

On 11/19/26 16:14, Anvesh Jain P wrote:
> 
> 
> On 11/19/2026 3:16 PM, Daniel Lezcano wrote:
>> Replace the aggregate temperature placeholder with a signed fixed-point
>> affine calculation. Accumulate source temperatures multiplied by their
>> coefficients using checked 64-bit arithmetic, divide once by the scale
>> of 1000, and add the existing offset from thermal_zone_params. Reject
>> arithmetic overflow and results outside the int range without modifying
>> the output on failure.
>>
>> Read each source under its zone lock and preserve temperature emulation
>> and error handling. Use nonblocking lock acquisition to return -EAGAIN
>> rather than wait for another zone lock while holding the aggregate lock.
>> Reject exiting sources and invalid temperature readings.
>>
>> Keep initialization-time checks in the aggregation validator. Require
>> validated, initialized entries and stable source references
>> throughout each read. Aggregations of aggregated zones are not supported
>> yet; source lifetime and detachment synchronization will be integrated
>> in subsequent changes.
>>
>> Signed-off-by: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
>> ---

[ ... ]

> 
> Tested the aggregation series on Glymur CRD with a few local DT
> additions for the aggregate zone.
> 
> Tested-by: Anvesh Jain P <anvesh.p@oss.qualcomm.com>


Thanks for testing


  reply	other threads:[~2026-11-19 15:22 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  9:46 [PATCH v1 00/12] thermal: Add multi-source thermal zone aggregation Daniel Lezcano
2026-11-19  9:46 ` [PATCH v1 01/12] thermal: core: Add thermal zone device reference helpers Daniel Lezcano
2026-11-19  9:46 ` [PATCH v1 02/12] thermal: core: Introduce private thermal zone aggregation structures Daniel Lezcano
2026-11-19  9:46 ` [PATCH v1 03/12] thermal: core: Validate thermal zone aggregation descriptions Daniel Lezcano
2026-11-19  9:46 ` [PATCH v1 04/12] thermal: core: Initialize thermal zone aggregation coefficients Daniel Lezcano
2026-11-19  9:46 ` [PATCH v1 05/12] thermal: core: Dispatch aggregate temperature reads Daniel Lezcano
2026-11-19  9:46 ` [PATCH v1 06/12] thermal: core: Calculate aggregated thermal zone temperatures Daniel Lezcano
2026-11-19 15:14   ` Anvesh Jain P
2026-11-19 15:22     ` Daniel Lezcano [this message]
2026-11-19  9:46 ` [PATCH v1 07/12] thermal: core: Initialize aggregation during zone registration Daniel Lezcano
2026-11-19  9:46 ` [PATCH v1 08/12] thermal: of: Separate zone parsing from sensor lookup Daniel Lezcano
2026-11-19  9:46 ` [PATCH v1 09/12] thermal: of: Track registered hardware temperature sources Daniel Lezcano
2026-11-19  9:46 ` [PATCH v1 10/12] thermal: of: Instantiate aggregates after their source zones Daniel Lezcano
2026-11-19  9:46 ` [PATCH v1 11/12] dt-bindings: thermal: Describe multi-source zone aggregation Daniel Lezcano
2026-11-19  9:46 ` [PATCH v1 12/12] thermal: testing: Add KUnit coverage for " Daniel Lezcano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=284f2947-28d9-4d30-87df-eb224ccc0a73@oss.qualcomm.com \
    --to=daniel.lezcano@oss.qualcomm.com \
    --cc=anvesh.p@oss.qualcomm.com \
    --cc=daniel.lezcano@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=lukasz.luba@arm.com \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    --cc=rui.zhang@intel.com \
    --cc=ulf.hansson@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox