Re: [PATCH v3 2/5] arm64: dts: rockchip: Add powerzones definition for rock960

Ulf Hansson
2021-12-02T14:46:14Z

On Wed, 1 Dec 2021 at 17:42, Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>
> Add the powerzones description. This first step introduces the big,
> the little as powerzone places.
>
> Cc: Robin Murphy <robin.murphy@arm.com>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> ---
> V3:
> - Remove GPU section as no power is available (yet)
> - Remove '#powerzone-cells' conforming to the bindings change
> V2:
> - Move description in the SoC dtsi specific file
> V1: Initial post
> ---
> arch/arm64/boot/dts/rockchip/rk3399.dtsi | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> index d3cdf6f42a30..c41b20888a44 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399.dtsi
> @@ -76,6 +76,7 @@ cpu_l0: cpu@0 {
> #cooling-cells = <2>; /* min followed by max */
> dynamic-power-coefficient = <100>;
> cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>;
> + powerzone = <&PKG_PZ>;
> };
>
> cpu_l1: cpu@1 {
> @@ -88,6 +89,7 @@ cpu_l1: cpu@1 {
> #cooling-cells = <2>; /* min followed by max */
> dynamic-power-coefficient = <100>;
> cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>;
> + powerzone = <&PKG_PZ>;
> };
>
> cpu_l2: cpu@2 {
> @@ -100,6 +102,7 @@ cpu_l2: cpu@2 {
> #cooling-cells = <2>; /* min followed by max */
> dynamic-power-coefficient = <100>;
> cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>;
> + powerzone = <&PKG_PZ>;
> };
>
> cpu_l3: cpu@3 {
> @@ -112,6 +115,7 @@ cpu_l3: cpu@3 {
> #cooling-cells = <2>; /* min followed by max */
> dynamic-power-coefficient = <100>;
> cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>;
> + powerzone = <&PKG_PZ>;
> };
>
> cpu_b0: cpu@100 {
> @@ -124,6 +128,7 @@ cpu_b0: cpu@100 {
> #cooling-cells = <2>; /* min followed by max */
> dynamic-power-coefficient = <436>;
> cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>;
> + powerzone = <&PKG_PZ>;
>
> thermal-idle {
> #cooling-cells = <2>;
> @@ -142,6 +147,7 @@ cpu_b1: cpu@101 {
> #cooling-cells = <2>; /* min followed by max */
> dynamic-power-coefficient = <436>;
> cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>;
> + powerzone = <&PKG_PZ>;
>
> thermal-idle {
> #cooling-cells = <2>;
> @@ -791,6 +797,17 @@ spi5: spi@ff200000 {
> status = "disabled";
> };
>
> + powerzones {
> +
> + PKG_PZ: pkg {
> + #powerzone-cells = <0>;
> + powerzone = <&SOC_PZ>;
> + };
> +
> + SOC_PZ: soc {

This needs "#powerzone-cells = <0>;"

> + };
> + };
> +
> thermal_zones: thermal-zones {
> cpu_thermal: cpu-thermal {
> polling-delay-passive = <100>;
> --
> 2.25.1
>

Other than the minor thing above, feel free to add:

Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>

Kind regards
Uffe