From: Viresh Kumar <viresh.kumar@linaro.org>
To: rjw@rjwysocki.net
Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, arvind.chauhan@arm.com,
inderpal.s@samsung.com, nm@ti.com, chander.kashyap@linaro.org,
pavel@ucw.cz, len.brown@intel.com, sudeep.holla@arm.com,
Viresh Kumar <viresh.kumar@linaro.org>
Subject: [PATCH V4 3/8] opp: Enhance debug messages in of_init_opp_table()
Date: Tue, 27 May 2014 17:20:52 +0530 [thread overview]
Message-ID: <2a9d8e2954166e47d7cdcf9c540dea572b080e7b.1401191054.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1401191054.git.viresh.kumar@linaro.org>
In-Reply-To: <cover.1401191054.git.viresh.kumar@linaro.org>
Enhance print messages for debugging purposes. Add a dev_err() whenever we fail
to initialize OPP table due to some error in the table present in dts and add a
dev_dbg() for success case.
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
drivers/base/power/opp.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/base/power/opp.c b/drivers/base/power/opp.c
index 2b615b9..ed5d580 100644
--- a/drivers/base/power/opp.c
+++ b/drivers/base/power/opp.c
@@ -628,8 +628,11 @@ int of_init_opp_table(struct device *dev)
prop = of_find_property(dev->of_node, "operating-points", NULL);
if (!prop)
return -ENODEV;
- if (!prop->value)
+ if (!prop->value) {
+ dev_err(dev, "%s: failed to init OPP: prop->value is NULL\n",
+ __func__);
return -ENODATA;
+ }
/*
* Each OPP is a set of tuples consisting of frequency and
@@ -653,6 +656,8 @@ int of_init_opp_table(struct device *dev)
}
of_node_put(dev->of_node);
+
+ dev_dbg(dev, "%s: successfully created OPP table\n", __func__);
return 0;
}
EXPORT_SYMBOL_GPL(of_init_opp_table);
--
2.0.0.rc2
next prev parent reply other threads:[~2014-05-27 11:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-27 11:50 [PATCH V4 0/8] driver/core: cpu: initialize opp table Viresh Kumar
2014-05-27 11:50 ` [PATCH V4 1/8] opp: of_init_opp_table(): return -ENOSYS when feature isn't implemented Viresh Kumar
2014-05-29 22:19 ` Nishanth Menon
2014-05-27 11:50 ` [PATCH V4 2/8] opp: call of_node_{get|put}() from of_init_opp_table() Viresh Kumar
2014-05-29 22:32 ` Nishanth Menon
2014-05-30 6:33 ` Sachin Kamat
2014-05-30 12:22 ` Rafael J. Wysocki
2014-06-02 6:59 ` [PATCH V5 " Viresh Kumar
2014-05-27 11:50 ` Viresh Kumar [this message]
2014-05-29 22:33 ` [PATCH V4 3/8] opp: Enhance debug messages in of_init_opp_table() Nishanth Menon
2014-06-02 7:00 ` [PATCH V5 " Viresh Kumar
2014-05-27 11:50 ` [PATCH V4 4/8] driver/core: cpu: initialize opp table Viresh Kumar
2014-05-29 22:41 ` Nishanth Menon
2014-06-02 6:37 ` Viresh Kumar
2014-06-06 21:41 ` Rafael J. Wysocki
2014-05-27 11:50 ` [PATCH V4 5/8] cpufreq: arm_big_little: don't " Viresh Kumar
2014-05-27 11:50 ` [PATCH V4 6/8] cpufreq: imx6q: " Viresh Kumar
2014-05-27 11:50 ` [PATCH V4 7/8] cpufreq: cpufreq-cpu0: " Viresh Kumar
2014-05-27 11:50 ` [PATCH V4 8/8] cpufreq: exynos5440: " Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2a9d8e2954166e47d7cdcf9c540dea572b080e7b.1401191054.git.viresh.kumar@linaro.org \
--to=viresh.kumar@linaro.org \
--cc=arvind.chauhan@arm.com \
--cc=chander.kashyap@linaro.org \
--cc=inderpal.s@samsung.com \
--cc=len.brown@intel.com \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=sudeep.holla@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).