From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: djakov@kernel.org, bjorn.andersson@linaro.org, agross@kernel.org,
linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org,
jun.nie@linaro.org, shawn.guo@linaro.org, benl@squareup.com
Subject: Re: [PATCH 2/3] interconnect: qcom: msm8939: Merge snoc and snoc_mm into one
Date: Fri, 28 Jan 2022 23:30:02 +0000 [thread overview]
Message-ID: <2acd53d0-c14e-a149-0708-d8ee4f33d15d@linaro.org> (raw)
In-Reply-To: <251a8515-7f8d-2535-e222-17443266f275@linaro.org>
On 28/01/2022 23:23, Bryan O'Donoghue wrote:
> On 28/01/2022 22:24, Dmitry Baryshkov wrote:
>> This would lead to higher frequencies being set on both 'normal' and
>> mm snoc clocks, thus (possibly) increasing power consumption.
>>
> How so ?
>
> There are four clocks
>
> bus
> bus_a
> bus_mm
> bus_a_mm
>
> The last two clocks
>
> SNOC performance points are
> 0 | 19.2 | XO
> 1 | 50 | GPLL0
> 2 | 100 | GPLL0
> 3 | 133.3 | GPLL0
> 4 | 160 | GPLL0
> 5 | 200 | GPLL0
> 6 | 266.6 | GPLL0
>
> SNOC_MM performance points are
> 0 | 19.2 | XO
> 1 | 50 | GPLL0
> 2 | 100 | GPLL0
> 3 | 133.3 | GPLL0
> 4 | 160 | GPLL0
> 5 | 200 | GPLL0
> 6 | 266.6 | GPLL0
> 7 | 320 | GPLL0
> 8 | 400 | GPLL0
>
> Its GPLL0 being set, the snoc_mm clocks really just map back to GPLL0
So taking an example
If venus
interconnects = <&snoc_mm MASTER_VIDEO_P0 &bimc SLAVE_EBI_CH0>;
or mdp
interconnects = <&snoc_mm MASTER_MDP_PORT0 &bimc SLAVE_EBI_CH0>,
<&snoc_mm MASTER_MDP_PORT1 &bimc SLAVE_EBI_CH0>;
wants performance point #6 GPLL0 runs at 266.6 but for performance point
#7 it runs at 320 MHz
Since the points all map back to a GPLL0 frequency, how does aggregating
snoc and snoc_mm - result in higher power consumption ?
next prev parent reply other threads:[~2022-01-28 23:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 16:09 [PATCH 0/3] interconnect: qcom: msm8939: Coalesce snoc and snoc_mm Bryan O'Donoghue
2022-01-28 16:10 ` [PATCH 1/3] dt-bindings: interconnect: Create modified msm8939-snoc description Bryan O'Donoghue
2022-01-28 16:10 ` [PATCH 2/3] interconnect: qcom: msm8939: Merge snoc and snoc_mm into one Bryan O'Donoghue
2022-01-28 22:24 ` Dmitry Baryshkov
2022-01-28 23:23 ` Bryan O'Donoghue
2022-01-28 23:30 ` Bryan O'Donoghue [this message]
2022-01-28 23:38 ` Bryan O'Donoghue
2022-01-29 4:10 ` Dmitry Baryshkov
2022-01-28 16:10 ` [PATCH 3/3] interconnect: qcom: msm8939: Deliniate bus, bus_a, bus_mm and bus_a_mm clocks Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2acd53d0-c14e-a149-0708-d8ee4f33d15d@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=benl@squareup.com \
--cc=bjorn.andersson@linaro.org \
--cc=djakov@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jun.nie@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).