From: Dragan Simic <dsimic@manjaro.org>
To: Sebastian Reichel <sebastian.reichel@collabora.com>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Lukasz Luba <lukasz.luba@arm.com>,
Heiko Stuebner <heiko@sntech.de>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
Diederik de Haas <didi.debian@cknow.org>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, kernel@collabora.com
Subject: Re: [PATCH v2 1/3] thermal: rockchip: unify struct rockchip_tsadc_chip format
Date: Fri, 22 Aug 2025 05:11:15 +0200 [thread overview]
Message-ID: <2bc3023e4b6e15b388f8765551018eed@manjaro.org> (raw)
In-Reply-To: <20250820-thermal-rockchip-grf-warning-v2-1-c7e2d35017b8@kernel.org>
Hello Sebastian,
On 2025-08-20 19:40, Sebastian Reichel wrote:
> Unify all chip descriptions to the version without any empty
> lines.
>
> Suggested-by: Heiko Stuebner <heiko@sntech.de>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
> ---
> drivers/thermal/rockchip_thermal.c | 27 ---------------------------
> 1 file changed, 27 deletions(-)
Thanks for the patch, it's perfectly reasonable and obviously correct.
Please feel free to include
Reviewed-by: Dragan Simic <dsimic@manjaro.org>
> diff --git a/drivers/thermal/rockchip_thermal.c
> b/drivers/thermal/rockchip_thermal.c
> index
> 3beff9b6fac3abe8948b56132b618ff1bed57217..7b18a705dfade6fa7318b28c2b57544a4446c1cc
> 100644
> --- a/drivers/thermal/rockchip_thermal.c
> +++ b/drivers/thermal/rockchip_thermal.c
> @@ -1098,10 +1098,8 @@ static const struct rockchip_tsadc_chip
> px30_tsadc_data = {
> /* cpu, gpu */
> .chn_offset = 0,
> .chn_num = 2, /* 2 channels for tsadc */
> -
> .tshut_mode = TSHUT_MODE_CRU, /* default TSHUT via CRU */
> .tshut_temp = 95000,
> -
> .initialize = rk_tsadcv4_initialize,
> .irq_ack = rk_tsadcv3_irq_ack,
> .control = rk_tsadcv3_control,
> @@ -1109,7 +1107,6 @@ static const struct rockchip_tsadc_chip
> px30_tsadc_data = {
> .set_alarm_temp = rk_tsadcv2_alarm_temp,
> .set_tshut_temp = rk_tsadcv2_tshut_temp,
> .set_tshut_mode = rk_tsadcv2_tshut_mode,
> -
> .table = {
> .id = rk3328_code_table,
> .length = ARRAY_SIZE(rk3328_code_table),
> @@ -1122,11 +1119,9 @@ static const struct rockchip_tsadc_chip
> rv1108_tsadc_data = {
> /* cpu */
> .chn_offset = 0,
> .chn_num = 1, /* one channel for tsadc */
> -
> .tshut_mode = TSHUT_MODE_GPIO, /* default TSHUT via GPIO give PMIC */
> .tshut_polarity = TSHUT_LOW_ACTIVE, /* default TSHUT LOW ACTIVE */
> .tshut_temp = 95000,
> -
> .initialize = rk_tsadcv2_initialize,
> .irq_ack = rk_tsadcv3_irq_ack,
> .control = rk_tsadcv3_control,
> @@ -1134,7 +1129,6 @@ static const struct rockchip_tsadc_chip
> rv1108_tsadc_data = {
> .set_alarm_temp = rk_tsadcv2_alarm_temp,
> .set_tshut_temp = rk_tsadcv2_tshut_temp,
> .set_tshut_mode = rk_tsadcv2_tshut_mode,
> -
> .table = {
> .id = rv1108_table,
> .length = ARRAY_SIZE(rv1108_table),
> @@ -1147,11 +1141,9 @@ static const struct rockchip_tsadc_chip
> rk3228_tsadc_data = {
> /* cpu */
> .chn_offset = 0,
> .chn_num = 1, /* one channel for tsadc */
> -
> .tshut_mode = TSHUT_MODE_GPIO, /* default TSHUT via GPIO give PMIC */
> .tshut_polarity = TSHUT_LOW_ACTIVE, /* default TSHUT LOW ACTIVE */
> .tshut_temp = 95000,
> -
> .initialize = rk_tsadcv2_initialize,
> .irq_ack = rk_tsadcv3_irq_ack,
> .control = rk_tsadcv3_control,
> @@ -1159,7 +1151,6 @@ static const struct rockchip_tsadc_chip
> rk3228_tsadc_data = {
> .set_alarm_temp = rk_tsadcv2_alarm_temp,
> .set_tshut_temp = rk_tsadcv2_tshut_temp,
> .set_tshut_mode = rk_tsadcv2_tshut_mode,
> -
> .table = {
> .id = rk3228_code_table,
> .length = ARRAY_SIZE(rk3228_code_table),
> @@ -1172,11 +1163,9 @@ static const struct rockchip_tsadc_chip
> rk3288_tsadc_data = {
> /* cpu, gpu */
> .chn_offset = 1,
> .chn_num = 2, /* two channels for tsadc */
> -
> .tshut_mode = TSHUT_MODE_GPIO, /* default TSHUT via GPIO give PMIC */
> .tshut_polarity = TSHUT_LOW_ACTIVE, /* default TSHUT LOW ACTIVE */
> .tshut_temp = 95000,
> -
> .initialize = rk_tsadcv2_initialize,
> .irq_ack = rk_tsadcv2_irq_ack,
> .control = rk_tsadcv2_control,
> @@ -1184,7 +1173,6 @@ static const struct rockchip_tsadc_chip
> rk3288_tsadc_data = {
> .set_alarm_temp = rk_tsadcv2_alarm_temp,
> .set_tshut_temp = rk_tsadcv2_tshut_temp,
> .set_tshut_mode = rk_tsadcv2_tshut_mode,
> -
> .table = {
> .id = rk3288_code_table,
> .length = ARRAY_SIZE(rk3288_code_table),
> @@ -1197,10 +1185,8 @@ static const struct rockchip_tsadc_chip
> rk3328_tsadc_data = {
> /* cpu */
> .chn_offset = 0,
> .chn_num = 1, /* one channels for tsadc */
> -
> .tshut_mode = TSHUT_MODE_CRU, /* default TSHUT via CRU */
> .tshut_temp = 95000,
> -
> .initialize = rk_tsadcv2_initialize,
> .irq_ack = rk_tsadcv3_irq_ack,
> .control = rk_tsadcv3_control,
> @@ -1208,7 +1194,6 @@ static const struct rockchip_tsadc_chip
> rk3328_tsadc_data = {
> .set_alarm_temp = rk_tsadcv2_alarm_temp,
> .set_tshut_temp = rk_tsadcv2_tshut_temp,
> .set_tshut_mode = rk_tsadcv2_tshut_mode,
> -
> .table = {
> .id = rk3328_code_table,
> .length = ARRAY_SIZE(rk3328_code_table),
> @@ -1221,11 +1206,9 @@ static const struct rockchip_tsadc_chip
> rk3366_tsadc_data = {
> /* cpu, gpu */
> .chn_offset = 0,
> .chn_num = 2, /* two channels for tsadc */
> -
> .tshut_mode = TSHUT_MODE_GPIO, /* default TSHUT via GPIO give PMIC */
> .tshut_polarity = TSHUT_LOW_ACTIVE, /* default TSHUT LOW ACTIVE */
> .tshut_temp = 95000,
> -
> .initialize = rk_tsadcv3_initialize,
> .irq_ack = rk_tsadcv3_irq_ack,
> .control = rk_tsadcv3_control,
> @@ -1233,7 +1216,6 @@ static const struct rockchip_tsadc_chip
> rk3366_tsadc_data = {
> .set_alarm_temp = rk_tsadcv2_alarm_temp,
> .set_tshut_temp = rk_tsadcv2_tshut_temp,
> .set_tshut_mode = rk_tsadcv2_tshut_mode,
> -
> .table = {
> .id = rk3228_code_table,
> .length = ARRAY_SIZE(rk3228_code_table),
> @@ -1246,11 +1228,9 @@ static const struct rockchip_tsadc_chip
> rk3368_tsadc_data = {
> /* cpu, gpu */
> .chn_offset = 0,
> .chn_num = 2, /* two channels for tsadc */
> -
> .tshut_mode = TSHUT_MODE_GPIO, /* default TSHUT via GPIO give PMIC */
> .tshut_polarity = TSHUT_LOW_ACTIVE, /* default TSHUT LOW ACTIVE */
> .tshut_temp = 95000,
> -
> .initialize = rk_tsadcv2_initialize,
> .irq_ack = rk_tsadcv2_irq_ack,
> .control = rk_tsadcv2_control,
> @@ -1258,7 +1238,6 @@ static const struct rockchip_tsadc_chip
> rk3368_tsadc_data = {
> .set_alarm_temp = rk_tsadcv2_alarm_temp,
> .set_tshut_temp = rk_tsadcv2_tshut_temp,
> .set_tshut_mode = rk_tsadcv2_tshut_mode,
> -
> .table = {
> .id = rk3368_code_table,
> .length = ARRAY_SIZE(rk3368_code_table),
> @@ -1271,11 +1250,9 @@ static const struct rockchip_tsadc_chip
> rk3399_tsadc_data = {
> /* cpu, gpu */
> .chn_offset = 0,
> .chn_num = 2, /* two channels for tsadc */
> -
> .tshut_mode = TSHUT_MODE_GPIO, /* default TSHUT via GPIO give PMIC */
> .tshut_polarity = TSHUT_LOW_ACTIVE, /* default TSHUT LOW ACTIVE */
> .tshut_temp = 95000,
> -
> .initialize = rk_tsadcv3_initialize,
> .irq_ack = rk_tsadcv3_irq_ack,
> .control = rk_tsadcv3_control,
> @@ -1283,7 +1260,6 @@ static const struct rockchip_tsadc_chip
> rk3399_tsadc_data = {
> .set_alarm_temp = rk_tsadcv2_alarm_temp,
> .set_tshut_temp = rk_tsadcv2_tshut_temp,
> .set_tshut_mode = rk_tsadcv2_tshut_mode,
> -
> .table = {
> .id = rk3399_code_table,
> .length = ARRAY_SIZE(rk3399_code_table),
> @@ -1296,11 +1272,9 @@ static const struct rockchip_tsadc_chip
> rk3568_tsadc_data = {
> /* cpu, gpu */
> .chn_offset = 0,
> .chn_num = 2, /* two channels for tsadc */
> -
> .tshut_mode = TSHUT_MODE_GPIO, /* default TSHUT via GPIO give PMIC */
> .tshut_polarity = TSHUT_LOW_ACTIVE, /* default TSHUT LOW ACTIVE */
> .tshut_temp = 95000,
> -
> .initialize = rk_tsadcv7_initialize,
> .irq_ack = rk_tsadcv3_irq_ack,
> .control = rk_tsadcv3_control,
> @@ -1308,7 +1282,6 @@ static const struct rockchip_tsadc_chip
> rk3568_tsadc_data = {
> .set_alarm_temp = rk_tsadcv2_alarm_temp,
> .set_tshut_temp = rk_tsadcv2_tshut_temp,
> .set_tshut_mode = rk_tsadcv2_tshut_mode,
> -
> .table = {
> .id = rk3568_code_table,
> .length = ARRAY_SIZE(rk3568_code_table),
next prev parent reply other threads:[~2025-08-22 3:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-20 17:40 [PATCH v2 0/3] thermal: rockchip: shut up GRF warning Sebastian Reichel
2025-08-20 17:40 ` [PATCH v2 1/3] thermal: rockchip: unify struct rockchip_tsadc_chip format Sebastian Reichel
2025-08-20 20:11 ` Heiko Stübner
2025-08-22 3:11 ` Dragan Simic [this message]
2025-08-20 17:40 ` [PATCH v2 2/3] thermal: rockchip: shut up GRF warning Sebastian Reichel
2025-08-20 20:14 ` Heiko Stübner
2025-08-21 12:41 ` Diederik de Haas
2025-08-22 3:15 ` Dragan Simic
2025-08-20 17:40 ` [PATCH v2 3/3] dt-bindings: thermal: rockchip: tighten grf requirements Sebastian Reichel
2025-08-20 19:48 ` Conor Dooley
2025-08-22 3:20 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bc3023e4b6e15b388f8765551018eed@manjaro.org \
--to=dsimic@manjaro.org \
--cc=conor+dt@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=didi.debian@cknow.org \
--cc=heiko@sntech.de \
--cc=kernel@collabora.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=lukasz.luba@arm.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
--cc=robin.murphy@arm.com \
--cc=rui.zhang@intel.com \
--cc=sebastian.reichel@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).