From: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: Thomas Gleixner <tglx@kernel.org>, Ingo Molnar <mingo@redhat.com>,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
"Rafael J . Wysocki" <rafael@kernel.org>,
linux-pci@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org, Lukas Wunner <lukas@wunner.de>
Subject: Re: [PATCH v5] PCI/PME: Resume Catlow Lake Root Ports on PME with PME Status clear
Date: Mon, 16 Nov 2026 13:45:36 -0800 [thread overview]
Message-ID: <2bd3ff86-d13f-41f5-acb5-def8c1a4fbaf@linux.intel.com> (raw)
In-Reply-To: <avsyp3TXjgj8km7T@wunner.de>
Hi Bjorn,
Please let me know your comments.
On 11/16/26 08:43, Lukas Wunner wrote:
> On Tue, Nov 03, 2026 at 11:31:36AM -0800, Kuppuswamy Sathyanarayanan wrote:
>> Intel Catlow Lake PCH Root Ports do not set PME Status in the Root
>> Status register when they generate a PME for their own hotplug event.
>> The PME interrupt itself is delivered. PMEs from devices below the Root
>> Port are reported correctly.
>>
>> PME and hotplug share the same interrupt. When a hotplug Root Port
>> runtime suspends to D3hot, pciehp disables hotplug interrupts and relies
>> on PME to resume the Port. On a hot-add the Port signals PME, but Root
>> Status stays clear. pcie_pme_irq() then returns IRQ_NONE. pciehp_isr()
>> also returns IRQ_NONE because hotplug interrupts are disabled. The Port
>> stays in D3hot and the new device is never enumerated.
>>
>> Mark the affected Root Ports with a new PCI_DEV_FLAGS_PME_UNRELIABLE
>> flag. If such a Port interrupts while not in D0 and PME Status is
>> clear, pcie_pme_irq() resumes the Port. pciehp re-enables hotplug
>> interrupts on runtime resume, and pciehp_check_presence() finds the new
>> device. pciehp itself is unchanged.
> [...]
>> Suggested-by: Lukas Wunner <lukas@wunner.de>
>> Link: https://lore.kernel.org/linux-pci/ara-_IPXV_i90if1@wunner.de/
>> Signed-off-by: Kuppuswamy Sathyanarayanan <sathyanarayanan.kuppuswamy@linux.intel.com>
>
> Reviewed-by: Lukas Wunner <lukas@wunner.de>
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer
prev parent reply other threads:[~2026-11-16 21:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 19:31 [PATCH v5] PCI/PME: Resume Catlow Lake Root Ports on PME with PME Status clear Kuppuswamy Sathyanarayanan
2026-11-04 14:24 ` Rafael J. Wysocki (Intel)
2026-11-16 11:27 ` Lukas Wunner
2026-11-16 16:06 ` Kuppuswamy Sathyanarayanan
2026-11-16 16:43 ` Lukas Wunner
2026-11-16 21:45 ` Kuppuswamy Sathyanarayanan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2bd3ff86-d13f-41f5-acb5-def8c1a4fbaf@linux.intel.com \
--to=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=helgaas@kernel.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukas@wunner.de \
--cc=mika.westerberg@linux.intel.com \
--cc=mingo@redhat.com \
--cc=rafael@kernel.org \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox