Re: [PATCH] thermal: int340x: fix tcc offset on resume

[Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>]

On Thu, 2021-09-09 at 09:09 +0200, Antoine Tenart wrote:
> Quoting Srinivas Pandruvada (2021-09-09 07:47:23)
> > 
> > We have to mark for stable. But It mayn't cleanly apply. So we have
> > to
> > submit for 5.12+ kernels.
> 
> If this can't be easily applied on stable kernels another approach
> could
> be to apply a simple fix (similar to the previous logic) for older
> kernels[1] and applying this patch only for 5.15+.
> 
> [1] Something like:
> 
>   -static unsigned int tcc_offset_save;
>   +static unsigned int tcc_offset_save = -1;
> 
>    int proc_thermal_resume(struct device *dev)
>    {
>           struct proc_thermal_device *proc_dev;
>   @@ -352,7 +371,9 @@ int proc_thermal_resume(struct device *dev)
>           proc_dev = dev_get_drvdata(dev);
>           proc_thermal_read_ppcc(proc_dev);
> 
>   -       tcc_offset_update(tcc_offset_save);
>   +       if (tcc_offset_save >= 0)
>   +               tcc_offset_update(tcc_offset_save);
> 
>           return 0;

This is a better approach. First submit this change with simple fix and
mark for stable and the other fix for 5.15 kernel.

Thanks,
Srinivas

>    }
> 
> Let me know if you prefer this approach.
> 
> Thanks,
> Antoine