From mboxrd@z Thu Jan 1 00:00:00 1970 From: yuankuiz@codeaurora.org Subject: Re: [PATCH] time: tick-sched: use bool for tick_stopped Date: Wed, 25 Apr 2018 15:01:46 +0800 Message-ID: <2c7c90722795ecfbe4e3e907f725549c@codeaurora.org> References: <891d4f632fbff5052e11f2d0b6fac35d@codeaurora.org> <2f7755fae34bb65ef0a4b5a11c67f431@codeaurora.org> <41aec3337f05316de118357fcbd9d175@codeaurora.org> <9447358d3f7cda9032b24d62dd79dacfca73fc30.camel@perches.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <9447358d3f7cda9032b24d62dd79dacfca73fc30.camel@perches.com> Sender: linux-kernel-owner@vger.kernel.org To: Joe Perches Cc: Thomas Gleixner , "Rafael J. Wysocki" , Linux PM , "Rafael J. Wysocki" , Frederic Weisbecker , Peter Zijlstra , Ingo Molnar , Len Brown , Linux Kernel Mailing List , linux-pm-owner@vger.kernel.org, akpm@linux-foundation.org List-Id: linux-pm@vger.kernel.org On 2018-04-21 03:24 AM, Joe Perches wrote: > On Fri, 2018-04-20 at 14:44 +0800, yuankuiz@codeaurora.org wrote: >> On 2018-04-20 09:47 AM, yuankuiz@codeaurora.org wrote: > [] >> > [ZJ] Further prototyping has been given based on gcc for both of >> > x86_64 and armv8-a, >> > unsigned int and bool share the same 1 bytes without the >> > addtional storage for sure. >> > Open this and welcome if any other difference behaviour could be >> > captured. >> >> [ZJ] Typo.. change 4 bytes above to 1 byte actually. > > Not really. > > unsigned int is 4 and bool is generally 1. > Alignment padding after a bool may exist. [ZJ] Depending on how to pack, the size was padded is variance. For example. In case of the "unsigned char" at the following, pack is happened and result 1 bytes.(if no more than 8 bits are used) In case of the "int" at the following, pack is happened but result 4 bytes. I mean, I demo it but use the 1# case due for another thread discussion on the ichx_desc() so move a little bit from the tick_sched struct.