From: Lukasz Luba <lukasz.luba@arm.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Dietmar.Eggemann@arm.com, dsmythies@telus.net,
Kajetan Puchalski <kajetan.puchalski@arm.com>,
yu.chen.surf@gmail.com, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Rafael J. Wysocki" <rafael@kernel.org>
Subject: Re: [RFC PATCH v2 0/1] cpuidle: teo: Introduce optional util-awareness
Date: Fri, 28 Oct 2022 08:08:31 +0100 [thread overview]
Message-ID: <2e02056b-24ef-6262-03bd-63fd6f3a5754@arm.com> (raw)
In-Reply-To: <71438330-dbfe-a10c-f289-24ba25c0d55f@linaro.org>
On 10/20/22 20:52, Daniel Lezcano wrote:
>
> Hi Kajetan,
>
> On 20/10/2022 18:20, Kajetan Puchalski wrote:
>> Hi Rafael,
>>
>>> The avg_util value tells us nothing about how much the CPU is going to
>>> be idle this time and it also tells us nothing about the
>>> latency-sensitivity of the workload.
>>>
>>> Yes, it tells us how much idle time there was on the given CPU in the
>>> past, on the average, but there is zero information about the
>>> distribution of that idle time in it.
>>>
>>> So in the first place please tell me why it fundamentally makes sense
>>> to use avg_util in CPU idle time management at all.
>>
>> I have an alternative suggestion that could be a reasonable way forward
>> here. Instead of applying util-awareness on top of TEO where it would
>> have to be reconciled with how TEO is currently expected to work, I just
>> wrote a simple completely new governor which operates only on timer
>> events alongside util values.
>
> I second the idea. I took a long time to investigate how to improve the
> governor and reached the conclusion having a dedicated governor for
> mobile platform makes sense. Also the behavior is very platform dependent.
>
> Regarding the utilization, one of the issue is the kernel threads
> preventing a task to wake up on the same CPU and forcing its migration
> at wake up time. So the prediction is screwed up at that time.
>
> There is a paper talking this issue [1]
>
> I've done a 'mobile' governor, including the next interrupt prediction
> [2]. It is very simple and almost has the same results as the teo on my
> platform (rock960).
>
> I'm not planning to upstream it because I don't have spare time to
> improve the results and take care of the IPIs. part.
>
> Also the paradigm is radically different and you may be interested in
> the approach.
>
> So if you want to rework, improve, test, upstream it, feel free to reuse
> the code.
>
> -- Daniel
>
> [1] Dynamic workload characterization for power efficient scheduling on
> CMP systems : https://cseweb.ucsd.edu//~tullsen/islped10.pdf
>
> [2]
> https://git.linaro.org/people/daniel.lezcano/linux.git/commit/?h=cpuidle/mobile-governor-v5.1&id=de1edb05e3c342f0738b414aa84263d6555b7462
>
>
>
Thanks Daniel! I forgot about your work in this area. As I have
responded in some other email in this thread, we might start
from a new small governor and than others can contribute.
Even this small governor that Kajetan showed me performs really
good on pixel6.
Regards,
Lukasz
next prev parent reply other threads:[~2022-10-28 7:08 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-03 14:49 [RFC PATCH v2 0/1] cpuidle: teo: Introduce optional util-awareness Kajetan Puchalski
2022-10-03 14:49 ` [RFC PATCH v2 1/1] " Kajetan Puchalski
2022-10-07 0:06 ` [RFC PATCH v2 0/1] " Doug Smythies
2022-10-10 10:09 ` Kajetan Puchalski
2022-10-11 8:21 ` Lukasz Luba
2022-10-12 18:50 ` Rafael J. Wysocki
2022-10-13 11:12 ` Kajetan Puchalski
2022-10-13 22:12 ` Doug Smythies
2022-10-27 19:56 ` Lukasz Luba
2022-10-28 13:29 ` Rafael J. Wysocki
2022-10-27 20:04 ` Lukasz Luba
2022-10-28 13:37 ` Rafael J. Wysocki
2022-10-28 13:12 ` Rafael J. Wysocki
2022-10-28 15:00 ` Kajetan Puchalski
2022-10-28 15:04 ` Rafael J. Wysocki
2022-10-28 15:08 ` Rafael J. Wysocki
2022-10-20 16:20 ` Kajetan Puchalski
2022-10-20 19:52 ` Daniel Lezcano
2022-10-28 7:08 ` Lukasz Luba [this message]
2022-10-28 7:11 ` Daniel Lezcano
2022-10-28 7:23 ` Lukasz Luba
2022-10-28 13:25 ` Rafael J. Wysocki
2022-10-28 13:22 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e02056b-24ef-6262-03bd-63fd6f3a5754@arm.com \
--to=lukasz.luba@arm.com \
--cc=Dietmar.Eggemann@arm.com \
--cc=daniel.lezcano@linaro.org \
--cc=dsmythies@telus.net \
--cc=kajetan.puchalski@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=yu.chen.surf@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox