From: Chanwoo Choi <cwchoi00@gmail.com>
To: Colin Ian King <colin.i.king@gmail.com>,
MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] PM / devfreq: imx-bus: use NULL to pass a null pointer rather than zero
Date: Thu, 30 Jun 2022 04:45:24 +0900 [thread overview]
Message-ID: <2e9d3702-595d-20e3-9e8c-c9723384b3a9@gmail.com> (raw)
In-Reply-To: <20220623180054.79687-1-colin.i.king@gmail.com>
On 22. 6. 24. 03:00, Colin Ian King wrote:
> The 3rd argument to the function of_get_property is a pointer and it is
> being passed using 0. Use NULL instead.
>
> Cleans up sparse warning:
> warning: Using plain integer as NULL pointer
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/devfreq/imx-bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/devfreq/imx-bus.c b/drivers/devfreq/imx-bus.c
> index f3f6e25053ed..f87067fc574d 100644
> --- a/drivers/devfreq/imx-bus.c
> +++ b/drivers/devfreq/imx-bus.c
> @@ -59,7 +59,7 @@ static int imx_bus_init_icc(struct device *dev)
> struct imx_bus *priv = dev_get_drvdata(dev);
> const char *icc_driver_name;
>
> - if (!of_get_property(dev->of_node, "#interconnect-cells", 0))
> + if (!of_get_property(dev->of_node, "#interconnect-cells", NULL))
> return 0;
> if (!IS_ENABLED(CONFIG_INTERCONNECT_IMX)) {
> dev_warn(dev, "imx interconnect drivers disabled\n");
Applied it. Thanks.
--
Best Regards,
Samsung Electronics
Chanwoo Choi
prev parent reply other threads:[~2022-06-29 19:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 18:00 [PATCH] PM / devfreq: imx-bus: use NULL to pass a null pointer rather than zero Colin Ian King
2022-06-29 19:45 ` Chanwoo Choi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e9d3702-595d-20e3-9e8c-c9723384b3a9@gmail.com \
--to=cwchoi00@gmail.com \
--cc=colin.i.king@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=festevam@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=myungjoo.ham@samsung.com \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).