From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Viresh Kumar <viresh.kumar@linaro.org>,
Lucas Stach <l.stach@pengutronix.de>
Cc: linux-pm@vger.kernel.org, Fabio Estevam <fabio.estevam@nxp.com>,
kernel@pengutronix.de, patchwork-lst@pengutronix.de
Subject: Re: [PATCH] cpufreq: imx6q: fix speed grading regression on i.MX6 QuadPlus
Date: Sun, 17 Dec 2017 19:06:41 +0100 [thread overview]
Message-ID: <3041111.LGmKWMtgYY@aspire.rjw.lan> (raw)
In-Reply-To: <20171212144133.GR25177@vireshk-i7>
On Tuesday, December 12, 2017 3:41:33 PM CET Viresh Kumar wrote:
> On 11-12-17, 14:19, Lucas Stach wrote:
> > The commit moving the speed grading check to the cpufreq driver introduced
> > some additional checks, so the OPP disable is only attempted on SoCs where
> > those OPPs are present. The compatible checks are missing the QuadPlus
> > compatible, so invalid OPPs are not correctly disabled there.
> >
> > Move both checks to a single condition, so we don't need to sprinkle even
> > more calls to of_machine_is_compatible().
> >
> > Fixes: 2b3d58a3adca (cpufreq: imx6q: Move speed grading check to cpufreq driver)
> > Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > ---
> > drivers/cpufreq/imx6q-cpufreq.c | 11 ++++++-----
> > 1 file changed, 6 insertions(+), 5 deletions(-)
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
Applied, thanks!
prev parent reply other threads:[~2017-12-17 18:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-11 13:19 [PATCH] cpufreq: imx6q: fix speed grading regression on i.MX6 QuadPlus Lucas Stach
2017-12-12 14:41 ` Viresh Kumar
2017-12-17 18:06 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3041111.LGmKWMtgYY@aspire.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=linux-pm@vger.kernel.org \
--cc=patchwork-lst@pengutronix.de \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox