From mboxrd@z Thu Jan 1 00:00:00 1970 From: Quentin Schulz Subject: Re: [PATCH 15/22] mfd: axp20x: add CHRG_CTRL1 to writeable regs for AXP20X/AXP22X Date: Thu, 5 Jan 2017 09:10:35 +0100 Message-ID: <304cdd9e-93a7-f554-99ce-e3e01762761d@free-electrons.com> References: <20170102163723.7939-1-quentin.schulz@free-electrons.com> <20170102163723.7939-16-quentin.schulz@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Chen-Yu Tsai Cc: Mark Rutland , devicetree , Lars-Peter Clausen , "open list:THERMAL" , linux-iio@vger.kernel.org, linux-kernel , Sebastian Reichel , Russell King , =?UTF-8?Q?Bruno_Pr=c3=a9mont?= , Rob Herring , linux-arm-kernel , Peter Meerwald-Stadler , knaack.h@gmx.de, Maxime Ripard , Lee Jones , Thomas Petazzoni , Jonathan Cameron , Icenowy Zheng List-Id: linux-pm@vger.kernel.org On 05/01/2017 07:10, Chen-Yu Tsai wrote: > On Tue, Jan 3, 2017 at 12:37 AM, Quentin Schulz > wrote: >> The CHR_CTRL1 register is made of 7 read-write bits with one being used >> to set the target voltage for battery charging. > > The description is incorrect. > > All 8 bits are read-write: > > - The highest bit enables the charger module > - Bits [6:5] set the target voltage > - Bits [4:3] set when the charge cycle ends, based on percentage > of charge current > - Bits [2:0] set the charge current > > Feel free to use the above in the commit message. > Thanks for the correction. >> >> This adds the CHRG_CTRL1 register to the list of writeable registers for >> AXP20X and AXP22X PMICs. > > You might want to add up to CHRG_CTRL3 for the AXP22x and CHRG_CTRL2 > for the AXP20x. These control additional aspects of the charger. > ACK. > AXP20X_CHRG_BAK_CTRL controls the charger for the RTC battery. You > could add this now, or let the person doing the RTC battery driver > add it. I'll let the person adding the RTC battery driver add it. Thanks, Quentin -- Quentin Schulz, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com