From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: "Viresh Kumar" <viresh.kumar@linaro.org>,
"Tomasz Wilczyński" <twilczynski@naver.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpufreq: conservative: Allow down_threshold to take values from 1 to 10
Date: Mon, 12 Jun 2017 14:23:28 +0200 [thread overview]
Message-ID: <3062414.lj8A9ADAOY@aspire.rjw.lan> (raw)
In-Reply-To: <20170612034035.GB5297@vireshk-i7>
On Monday, June 12, 2017 09:10:35 AM Viresh Kumar wrote:
> On 11-06-17, 17:28, Tomasz Wilczyński wrote:
> > Commit 27ed3cd2ebf4cd78b198be9758c538cdede36d8a ("cpufreq: conservative:
> > Fix the logic in frequency decrease checking") removed the 10 point
> > substraction when comparing the load against down_threshold but did not
> > remove the related limit for the down_threshold value. As a result,
> > down_threshold lower than 11 is not allowed even though values from
> > 1 to 10 do work correctly too. The comment ("cannot be lower than 11
> > otherwise freq will not fall") is also not true after removing the
> > substraction.
> >
> > For this reason, allow down_threshold to take any value from 1 to 99
> > and fix the related comment.
> >
> > Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com>
>
> Please add Fixes tag and relevant kernel release for stable tag.
Actually, the Fixes: tag would be sufficient and then adding it would be
appreciated.
No need to resend the patch, though.
Thanks,
Rafael
next prev parent reply other threads:[~2017-06-12 12:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1497169719-13613-1-git-send-email-twilczynski@naver.com>
2017-06-12 3:40 ` [PATCH] cpufreq: conservative: Allow down_threshold to take values from 1 to 10 Viresh Kumar
2017-06-12 12:23 ` Rafael J. Wysocki [this message]
[not found] ` <7fa1e0c6-8d9c-c346-f5e2-87f024ebc1bb@naver.com>
2017-06-13 6:02 ` Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3062414.lj8A9ADAOY@aspire.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=twilczynski@naver.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox