linux-pm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Rafael Wysocki <rjw@rjwysocki.net>,
	Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>
Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
	Viresh Kumar <viresh.kumar@linaro.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH 3/6] cpufreq: schedutil: Improve prints messages with pr_fmt
Date: Wed, 18 May 2016 17:55:28 +0530	[thread overview]
Message-ID: <30cb533c2e24d22832cbc2953c51fa3cf60cd202.1463574213.git.viresh.kumar@linaro.org> (raw)
In-Reply-To: <cover.1463574213.git.viresh.kumar@linaro.org>
In-Reply-To: <cover.1463574213.git.viresh.kumar@linaro.org>

Prefix print messages with KBUILD_MODNAME, i.e 'cpufreq_schedutil: '.
This helps to keep similar formatting for all the print messages
particular to a file and identify those easily in kernel logs.

Its already done this way for rest of the governors.

Along with that, remove the (now) redundant bits from a print message.

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
---
 kernel/sched/cpufreq_schedutil.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/kernel/sched/cpufreq_schedutil.c b/kernel/sched/cpufreq_schedutil.c
index 154ae3a51e86..14c4aa25cc45 100644
--- a/kernel/sched/cpufreq_schedutil.c
+++ b/kernel/sched/cpufreq_schedutil.c
@@ -9,6 +9,8 @@
  * published by the Free Software Foundation.
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/cpufreq.h>
 #include <linux/module.h>
 #include <linux/slab.h>
@@ -388,7 +390,7 @@ static int sugov_init(struct cpufreq_policy *policy)
 	mutex_unlock(&global_tunables_lock);
 
 	sugov_policy_free(sg_policy);
-	pr_err("cpufreq: schedutil governor initialization failed (error %d)\n", ret);
+	pr_err("initialization failed (error %d)\n", ret);
 	return ret;
 }
 
-- 
2.7.1.410.g6faf27b

  parent reply	other threads:[~2016-05-18 12:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-18 12:25 [PATCH 0/6] cpufreq: minor cleanups Viresh Kumar
2016-05-18 12:25 ` [PATCH 1/6] cpufreq: governor: Remove prints from allocation failures Viresh Kumar
2016-05-18 12:25 ` [PATCH 2/6] cpufreq: governor: Remove unnecessary bits from print message Viresh Kumar
2016-05-18 12:25 ` Viresh Kumar [this message]
2016-05-18 12:25 ` [PATCH 4/6] cpufreq: conservative: Remove declaration of cs_dbs_gov Viresh Kumar
2016-05-18 21:03   ` Rafael J. Wysocki
2016-05-19  2:13     ` Viresh Kumar
2016-05-18 12:25 ` [PATCH 5/6] cpufreq: Reuse gov_attr_* macros in schedutil governor Viresh Kumar
2016-05-18 21:01   ` Rafael J. Wysocki
2016-05-19  2:13     ` Viresh Kumar
2016-05-19 11:43       ` Rafael J. Wysocki
2016-05-18 12:25 ` [PATCH 6/6] cpufreq: governor: Create cpufreq_policy_apply_limits() Viresh Kumar
2016-05-18 21:06 ` [PATCH 0/6] cpufreq: minor cleanups Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30cb533c2e24d22832cbc2953c51fa3cf60cd202.1463574213.git.viresh.kumar@linaro.org \
    --to=viresh.kumar@linaro.org \
    --cc=linaro-kernel@lists.linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=rjw@rjwysocki.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).