From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DCA92877D7 for ; Mon, 16 Jun 2025 16:48:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750092515; cv=none; b=U17YMfkYiK1V8y1YZvnkhxHOXnch12fhVk9hZoic98Gh+WoJjmcELdzakgr10wt3z4bXoi89gGesGbNiJXp/YgngZgM0d7GL3jvzzzaQVQ8Luehr/ZJsWDM4T3NXryXqnxaEY2mXnoZ7TwpXlLAxGnCkQOkuxFyCFFqvwEdKRf8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1750092515; c=relaxed/simple; bh=/h+0C0+QWS3aA/QPz3SawkeyoNRtLolokTJ/FYPaC3o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=MhuYfUfIua4wYGDGO5+rwOCSoCQaA4WA4jHn5uwq/2zlBmOawOUf8GkfQ3wgNbzM3dJv+T52uc0nHVZIGKeJL5v8+g7spZc6ahF9FIGaXWFgpVKQbU70PZJouGiV5z04jbSlIhTeCINfieFKqTjTC9HQ9qoqp42WDhXtQx4bglI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=d5Xd7REY; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="d5Xd7REY" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 55G8oE3L005767 for ; Mon, 16 Jun 2025 16:48:33 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= lxyeOcoLjC3T2xwCWZvRjoeExdTH0SjUCC/Y0ERYeNQ=; b=d5Xd7REYM3S9gnS5 n7bYGFpFbiw+1+kJ2EqZbnWEMgfB2xuele5T5Pwm9aKsDRA78/EKtOy0F2QNTYzT KJvLT7ey6fAz3mjnpAWR432o8QADvN+IEnRwpM9Yj6bc0Ge8sjvzz0ZWiAwbFZTq nSepVk6eUNbh2ajDno4AWOc80XhTQlCWJcNa+Xm0CfPGPAoe58ojfQ9t2H2KbETZ z7mYYqFgR+aN0ahVuhbD8tNmbaw4ythr6pL1F0kGDSq4MFutDxLYRwjZC/QWS+ot Q/wBmVMGl0R5Qzntex2p8lKoFoNZds64/OuZsZjde6FVoaFAvIo75Ja0bP5wgTr2 Mlo+Yg== Received: from mail-pf1-f199.google.com (mail-pf1-f199.google.com [209.85.210.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4791hcw9hy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 16 Jun 2025 16:48:33 +0000 (GMT) Received: by mail-pf1-f199.google.com with SMTP id d2e1a72fcca58-747d29e90b4so3652733b3a.0 for ; Mon, 16 Jun 2025 09:48:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750092512; x=1750697312; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=lxyeOcoLjC3T2xwCWZvRjoeExdTH0SjUCC/Y0ERYeNQ=; b=RNhVckrx7UxkPR90Xy/8Icm05jJH44qO3nH9SivJG4BVtTItKha6Ob1BK7x0nv7pZp 1ulGYRBwFJTdTGE8wgMJpy0Br3V/uk7K9E/DH0ZT50iec4GXdSQZaz/cM0OpwuXA2p4H Iv6fXy67VtTxzo+Fvr2IuA3OuCb9v247bM8WLwWOBa4S23QPwOYqwbk7PQw9/Ko/dKs2 G+nTCWEBz85GHxouSGup161xIjAENP2asAAtz8vPs2+QjJJNlH9MlCDevRO2nibmiBHs vkKAknBkWD9jv2nmfcbYCdXNeg4A2fvj6xqNdA7N3n1a4J1w9Hujv9v1RdTJ3TLvTUai /MGA== X-Forwarded-Encrypted: i=1; AJvYcCUg2O+axmemeKr95qRaTWbC7o19UY8mMnAIgCElfgSC+CYOPEA4kpPX1Yo9WPf1v1qASvGjS1qP/A==@vger.kernel.org X-Gm-Message-State: AOJu0Yx3G0l6iOVlCI3jBnEoYJe0ovKlvtfrTCF+tSTQaoKRsUNTBltK nN4CLh8eIyPByXMBNSsYUpAGK4rg8VG+Wwz0TXW/NFiZzIeU4IDo2flqD+jcRVH57n0D5+OKcEB GLGP4k9Z3t1NSUdnFeCgOEWEoTRwtk7LKyDljA4QfNN9SG7v7NuMJ+k7JJjEh3Q== X-Gm-Gg: ASbGncsxjkpEk7PbsrKvedOFdC13nabYCBsZDwsikv+RoOBRBMd/E8WvP4yCzhGw84N wdg3NS3ZNFgtJhr5rnTzbg+L3w5c1YLNrjsr918rSzstcUidq0I6QkZDCcOSepUGYA9mCxmK/vE N2/zNYT6txfinbS13y+741Ntr6YUhv8JNqvdb0S3Z8dKmqaH9di2m5It81s0rBFPV/sDAW9rbmX DSvcEbUu5QDkeuateEoHj4W4HlSR5xwB2aaRJS0Bw3Ty1WrhH/6xdh/QHudfjbFZvlF1S/W8Sni Hy1agG0vlGZDCtOV8VIdIGqOf6a6d/D7yNp4gjIIsg== X-Received: by 2002:a05:6a21:318c:b0:215:d611:5d9b with SMTP id adf61e73a8af0-21fbd4bbd5fmr14908420637.12.1750092512624; Mon, 16 Jun 2025 09:48:32 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFiRsfJISsTnkxLW8qZGNZNt7p0Rfn9bVYWR0l8aBesdxG90+o4bb4c6x4zbi0HdUx7zVZcJw== X-Received: by 2002:a05:6a21:318c:b0:215:d611:5d9b with SMTP id adf61e73a8af0-21fbd4bbd5fmr14908365637.12.1750092512245; Mon, 16 Jun 2025 09:48:32 -0700 (PDT) Received: from [10.206.104.82] ([202.46.23.25]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b2fe1680454sm6019135a12.37.2025.06.16.09.48.25 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Jun 2025 09:48:31 -0700 (PDT) Message-ID: <31c50188-986a-44e8-8765-c1fce6ad3c2c@oss.qualcomm.com> Date: Mon, 16 Jun 2025 22:18:24 +0530 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/4] dt-bindings: opp: adreno: Update regex of OPP entry To: Krzysztof Kozlowski , Catalin Marinas , Will Deacon , Rob Clark , Sean Paul , Konrad Dybcio , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Marijn Suijten , David Airlie , Simona Vetter , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Viresh Kumar , Nishanth Menon , Stephen Boyd Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, devicetree@vger.kernel.org, linux-pm@vger.kernel.org References: <20250611-x1p-adreno-v2-0-5074907bebbd@oss.qualcomm.com> <20250611-x1p-adreno-v2-1-5074907bebbd@oss.qualcomm.com> <492417fe-c086-4980-b108-0487bad08155@kernel.org> <750da319-d25f-454d-b376-ebbc194e0e41@kernel.org> From: Akhil P Oommen Content-Language: en-US In-Reply-To: <750da319-d25f-454d-b376-ebbc194e0e41@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwNjE2MDExMSBTYWx0ZWRfX3SUgiFtwxUU4 WeZY5+UQ75FCy70RoezYY2Ml3kVgon8ZpLGs4cHqTRjJXXId5odLLUugjXxssXpEZ7ae5VBxRgN hs195yaUhOMk0v5uOsS+Kz1jSoEVJ7W4n+J/wA9zrXsQUm+idRuKGsMSONkU5T3EsEkjhGc9fRF iKQm5Log+42rQlN2U1wR7WNi8ZcQiTRMsEYKgS78pZQzapzHj6bOaWHbCZh6CJpk/e19YYso48m +P/+IptB0nWhQ7fOK0nN4On4pJwHvnKSDbpxCN/FFa3Jkdy4NC84EnA0CDczQQ4kq7kd0ai30hS Lx1bNTFbpm4IVIs1sButDz8scyYcd0Ayj9vhGnGSHrQJpaG32PIeBlR0C5vKfr0wKL0ArL77kjH XLgKQaNUeZJn5mpLZeE8m7rHHrGdpZgXcpBe8b5Zgos+l0jYrwzqb5MSuVDP1XPSJTYCL1Qp X-Authority-Analysis: v=2.4 cv=PtaTbxM3 c=1 sm=1 tr=0 ts=68504ae1 cx=c_pps a=WW5sKcV1LcKqjgzy2JUPuA==:117 a=ZePRamnt/+rB5gQjfz0u9A==:17 a=IkcTkHD0fZMA:10 a=6IFa9wvqVegA:10 a=DDAlTcr3_WI9VELS8V8A:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=OpyuDcXvxspvyRM73sMx:22 X-Proofpoint-ORIG-GUID: D35v-gKl9byOofa_yWPjFfa2ID6oLHhe X-Proofpoint-GUID: D35v-gKl9byOofa_yWPjFfa2ID6oLHhe X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1099,Hydra:6.0.736,FMLib:17.12.80.40 definitions=2025-06-16_08,2025-06-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1015 mlxlogscore=999 suspectscore=0 malwarescore=0 lowpriorityscore=0 impostorscore=0 adultscore=0 spamscore=0 priorityscore=1501 phishscore=0 mlxscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2505280000 definitions=main-2506160111 On 6/12/2025 4:59 PM, Krzysztof Kozlowski wrote: > On 11/06/2025 14:24, Akhil P Oommen wrote: >>>> >>>> patternProperties: >>>> - '^opp-[0-9]+$': >>>> + '^opp(-?[0-9]+)*$': >>> >>> Not correct regex. You allow "opp", "opp1" and all other unusual >>> variants. Commit does not explain what problem you are solving, so I >>> have no clue what you want here, but for sure opp1 is wrong. >> >> Just to confirm, would this be fine for the requirement I mentioned above? >> >> "'^opp(-[0-9]+)*$'" > > No, You did not solve half of the problems - still allows "opp" and > commit msg does not explain why "opp" is now correct. Describe the > actual problem and then write the regex solving it in specific way, not > causing other effects. Gotcha. If we want to be super strict, the regex should be: ^opp(-[0-9]+){1,2}$ I will send out a new patch. -Akhil > > Best regards, > Krzysztof