Re: [PATCH 1/2] PM / devfreq: Export helper functions for drivers

Re: [PATCH 1/2] PM / devfreq: Export helper functions for drivers

[함명주]

Sender : Punit Agrawal<punit.agrawal@arm.com>
> From: Ørjan Eide 
>
> These functions are indended for use by drivers and should be available
> also when the driver is built as a module.
>
> Cc: MyungJoo Ham 
> Cc: Kyungmin Park 
> Signed-off-by: Ørjan Eide 

Dear Punit,


Just being curious, is there any reason not to use EXPORT_SYMBOL_GPL ?


Cheers,
MyungJoo.

--
MyungJoo Ham (함명주), PHD
Frontier CS Lab, Software Center
Samsung Electronics
Cell: +82-10-6714-2858

Re: [PATCH 1/2] PM / devfreq: Export helper functions for drivers

[Punit Agrawal]

함명주 <myungjoo.ham@samsung.com> writes:

> Sender : Punit Agrawal<punit.agrawal@arm.com>
>> From: Ørjan Eide 
>>
>> These functions are indended for use by drivers and should be available
>> also when the driver is built as a module.
>>
>> Cc: MyungJoo Ham 
>> Cc: Kyungmin Park 
>> Signed-off-by: Ørjan Eide 
>
> Dear Punit,

Hi MyungJoo,

>
>
> Just being curious, is there any reason not to use EXPORT_SYMBOL_GPL ?

No reason other than to match the existing EXPORT_SYMBOLs in this file.

Would you prefer this and the following patch to use EXPORT_SYMBOL_GPL
instead?

>
>
> Cheers,
> MyungJoo.
>
> --
> MyungJoo Ham (함명주), PHD
> Frontier CS Lab, Software Center
> Samsung Electronics
> Cell: +82-10-6714-2858--
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: RE: [PATCH 1/2] PM / devfreq: Export helper functions for drivers

[함명주]

> ------- Original Message -------
> Sender : Hernandez, Carlos<ceh@ti.com>
> Date : 2014-08-12 22:49 (GMT+09:00)
> Title : RE: [PATCH 1/2] PM / devfreq: Export helper functions for drivers
> 
> Acked-By: Carlos Hernandez 
> 
> -----Original Message-----
> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-owner@vger.kernel.org] On Behalf Of Punit Agrawal
> Sent: Friday, July 18, 2014 10:10 AM
> To: linux-pm@vger.kernel.org; linux-samsung-soc@vger.kernel.org
> Cc: orjan.eide@arm.com; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; MyungJoo Ham; Kyungmin Park
> Subject: [PATCH 1/2] PM / devfreq: Export helper functions for drivers
> 
> From: Ørjan Eide 
> 
> These functions are indended for use by drivers and should be available also when the driver is built as a module.> 
> 
> Cc: MyungJoo Ham 
> Cc: Kyungmin Park 
> Signed-off-by: Ørjan Eide 

Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>

There will be some modifications to this patch for consistency with other pending patches, but please don't worry about them. I'll handle them while merging this.


Cheers,
MyungJoo.

> ---
> drivers/devfreq/devfreq.c |    3 +++
> 1 file changed, 3 insertions(+)



--
MyungJoo Ham (함명주), PHD
Frontier CS Lab, Software Center
Samsung Electronics
Cell: +82-10-6714-2858

Re: [PATCH 1/2] PM / devfreq: Export helper functions for drivers

[Punit Agrawal]

함명주 <myungjoo.ham@samsung.com> writes:

>> ------- Original Message -------
>> Sender : Hernandez, Carlos<ceh@ti.com>
>> Date : 2014-08-12 22:49 (GMT+09:00)
>> Title : RE: [PATCH 1/2] PM / devfreq: Export helper functions for drivers
>> 
>> Acked-By: Carlos Hernandez 
>> 
>> -----Original Message-----
>> From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-owner@vger.kernel.org] On Behalf Of Punit Agrawal
>> Sent: Friday, July 18, 2014 10:10 AM
>> To: linux-pm@vger.kernel.org; linux-samsung-soc@vger.kernel.org
>> Cc: orjan.eide@arm.com; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; MyungJoo Ham; Kyungmin Park
>> Subject: [PATCH 1/2] PM / devfreq: Export helper functions for drivers
>> 
>> From: Ørjan Eide 
>> 
>> These functions are indended for use by drivers and should be available also when the driver is built as a module.> 
>> 
>> Cc: MyungJoo Ham 
>> Cc: Kyungmin Park 
>> Signed-off-by: Ørjan Eide 
>
> Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
>
> There will be some modifications to this patch for consistency with
> other pending patches, but please don't worry about them. I'll handle
> them while merging this.

Great! Thanks MyungJoo.

>
>
> Cheers,
> MyungJoo.
>
>> ---
>> drivers/devfreq/devfreq.c |    3 +++
>> 1 file changed, 3 insertions(+)
>
>
>
> --
> MyungJoo Ham (함명주), PHD
> Frontier CS Lab, Software Center
> Samsung Electronics
> Cell: +82-10-6714-2858--
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 0/2] Convert exynos PPMU driver to be built as module

[Punit Agrawal]

Hi,

There's no reason why the exynos PPMU can't be built as a module
except you need -

- The first patch exports the functions that are needed to build
devfreq drivers as modules.

- The second patch then converts the exynos PPMU devfreq driver to be
  built as a module.

Compile tested only.

Thanks

Punit Agrawal (1):
  PM / devfreq: exynos: Enable building exynos PPMU as module

Ørjan Eide (1):
  PM / devfreq: Export helper functions for drivers

 drivers/devfreq/Kconfig              |    2 +-
 drivers/devfreq/devfreq.c            |    3 +++
 drivers/devfreq/exynos/exynos_ppmu.c |    3 +++
 3 files changed, 7 insertions(+), 1 deletion(-)

-- 
1.7.10.4

[PATCH 1/2] PM / devfreq: Export helper functions for drivers

[Punit Agrawal]

From: Ørjan Eide <orjan.eide@arm.com>

These functions are indended for use by drivers and should be available
also when the driver is built as a module.

Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Ørjan Eide <orjan.eide@arm.com>
---
 drivers/devfreq/devfreq.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
index 9f90369..30b538d8 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -1119,6 +1119,7 @@ struct dev_pm_opp *devfreq_recommended_opp(struct device *dev,
 
 	return opp;
 }
+EXPORT_SYMBOL(devfreq_recommended_opp);
 
 /**
  * devfreq_register_opp_notifier() - Helper function to get devfreq notified
@@ -1142,6 +1143,7 @@ int devfreq_register_opp_notifier(struct device *dev, struct devfreq *devfreq)
 
 	return ret;
 }
+EXPORT_SYMBOL(devfreq_register_opp_notifier);
 
 /**
  * devfreq_unregister_opp_notifier() - Helper function to stop getting devfreq
@@ -1168,6 +1170,7 @@ int devfreq_unregister_opp_notifier(struct device *dev, struct devfreq *devfreq)
 
 	return ret;
 }
+EXPORT_SYMBOL(devfreq_unregister_opp_notifier);
 
 static void devm_devfreq_opp_release(struct device *dev, void *res)
 {
-- 
1.7.10.4

RE: [PATCH 1/2] PM / devfreq: Export helper functions for drivers

[Hernandez, Carlos]

Acked-By: Carlos Hernandez <ceh@ti.com>

-----Original Message-----
From: linux-kernel-owner@vger.kernel.org [mailto:linux-kernel-owner@vger.kernel.org] On Behalf Of Punit Agrawal
Sent: Friday, July 18, 2014 10:10 AM
To: linux-pm@vger.kernel.org; linux-samsung-soc@vger.kernel.org
Cc: orjan.eide@arm.com; linux-kernel@vger.kernel.org; linux-arm-kernel@lists.infradead.org; MyungJoo Ham; Kyungmin Park
Subject: [PATCH 1/2] PM / devfreq: Export helper functions for drivers

From: Ørjan Eide <orjan.eide@arm.com>

These functions are indended for use by drivers and should be available also when the driver is built as a module.

Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
Cc: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Ørjan Eide <orjan.eide@arm.com>
---
 drivers/devfreq/devfreq.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c index 9f90369..30b538d8 100644
--- a/drivers/devfreq/devfreq.c
+++ b/drivers/devfreq/devfreq.c
@@ -1119,6 +1119,7 @@ struct dev_pm_opp *devfreq_recommended_opp(struct device *dev,
 
 	return opp;
 }
+EXPORT_SYMBOL(devfreq_recommended_opp);
 
 /**
  * devfreq_register_opp_notifier() - Helper function to get devfreq notified @@ -1142,6 +1143,7 @@ int devfreq_register_opp_notifier(struct device *dev, struct devfreq *devfreq)
 
 	return ret;
 }
+EXPORT_SYMBOL(devfreq_register_opp_notifier);
 
 /**
  * devfreq_unregister_opp_notifier() - Helper function to stop getting devfreq @@ -1168,6 +1170,7 @@ int devfreq_unregister_opp_notifier(struct device *dev, struct devfreq *devfreq)
 
 	return ret;
 }
+EXPORT_SYMBOL(devfreq_unregister_opp_notifier);
 
 static void devm_devfreq_opp_release(struct device *dev, void *res)  {
--
1.7.10.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/