Re: [PATCH v2 0/5] rtc: rtc-cmos: Assorted ACPI-related cleanups and fixes

Zhang Rui
2022-11-10T12:00:37Z

On Wed, 2022-11-09 at 13:05 +0100, Rafael J. Wysocki wrote:
> Hi All,
>
> This is a v2 of the series previously posted as
>
> https://lore.kernel.org/linux-acpi/2276401.ElGaqSPkdT@kreacher/
>
> The first three patches in the series have not changed since then (I
> have
> considered moving the last patch, which is a fix, to the front, but
> that turns
> out to be a bit cumbersome and not really worth the effort).
>
> This series of patches does some assorted ACPI-related cleanups to
> the CMOS RTC
> driver:
> - redundant static variable is dropped,
> - code duplication is reduced,
> - code is relocated so as to drop a few unnecessary forward
> declarations of
> functions,
> - functions are renamed to avoid confusion,
> and fixes up an issue in the driver removal path.
>
>
>

Reviewed-by: Zhang Rui <rui.zhang@intel.com>

And I have tested the patch series on a platform with both
use_acpi_alarm parameter set and cleared, the ACPI RTC fixed event
works as expected, for both runtime and suspend wakeups.

So
Tested-by: Zhang Rui <rui.zhang@intel.com>

thanks,
rui