From: Mikko Perttunen <mperttunen@nvidia.com>
To: Svyatoslav Ryhel <clamor95@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Thierry Reding <treding@nvidia.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Prashant Gaikwad <pgaikwad@nvidia.com>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH v3 1/4] dt-bindings: reset: add Tegra114 car header
Date: Tue, 26 Aug 2025 17:29:52 +0900 [thread overview]
Message-ID: <3303492.5fSG56mABF@senjougahara> (raw)
In-Reply-To: <2ef333b7-2c4c-4c06-b90f-5dfa8af41e36@kernel.org>
On Tuesday, August 26, 2025 5:21 PM Krzysztof Kozlowski wrote:
> On 26/08/2025 08:11, Svyatoslav Ryhel wrote:
> > Binding values for special resets that are placed starting from
> > software-defined index 160 in line with other chips.
> >
> > Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
> > ---
> >
> > include/dt-bindings/reset/tegra114-car.h | 13 +++++++++++++
>
> NAK
>
> You got comments last time and you completely ignored them.
>
> Best regards,
> Krzysztof
Thierry explained to you last time why this patch makes sense.
The existing binding is such that values below 160 map to clock IDs (in dt-
bindings/clock/tegra114-car.h). We cannot use those numbers for these "special
resets" that have no corresponding clock, or we'd be changing existing
binding. Hence this patch starts them at 160, above the clock IDs. The same
already exists in the tegra124-car binding for TEGRA124_RST_DFLL_DVCO -- this
just extends that to Tegra114.
Mikko
next prev parent reply other threads:[~2025-08-26 8:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-26 6:11 [PATCH v3 0/4] clk: tegra: add DFLL support for Tegra114 Svyatoslav Ryhel
2025-08-26 6:11 ` [PATCH v3 1/4] dt-bindings: reset: add Tegra114 car header Svyatoslav Ryhel
2025-08-26 8:21 ` Krzysztof Kozlowski
2025-08-26 8:29 ` Mikko Perttunen [this message]
2025-08-26 9:16 ` Krzysztof Kozlowski
2025-08-26 6:11 ` [PATCH v3 2/4] clk: tegra: add DFLL DVCO reset control for Tegra114 Svyatoslav Ryhel
2025-08-26 6:11 ` [PATCH v3 3/4] clk: tegra: dfll: add CVB tables " Svyatoslav Ryhel
2025-08-26 6:11 ` [PATCH v3 4/4] ARM: tegra: Add DFLL clock support " Svyatoslav Ryhel
2025-08-26 6:25 ` [PATCH v3 0/4] clk: tegra: add DFLL " Mikko Perttunen
2025-08-26 13:56 ` Rob Herring (Arm)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3303492.5fSG56mABF@senjougahara \
--to=mperttunen@nvidia.com \
--cc=clamor95@gmail.com \
--cc=jonathanh@nvidia.com \
--cc=krzk@kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=pgaikwad@nvidia.com \
--cc=rafael@kernel.org \
--cc=sboyd@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=treding@nvidia.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox