From: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: Re: your patch "intel_idle: add core C6 optimization for SPR"
Date: Tue, 26 Apr 2022 13:22:43 +0300 [thread overview]
Message-ID: <339d6f1495779ba402dab7f7940cdcae3bb94e71.camel@linux.intel.com> (raw)
In-Reply-To: <af7b829e-0d4c-8e4d-faf7-e86f2813cdab@suse.com>
On Tue, 2022-04-26 at 11:35 +0200, Jan Beulich wrote:
> Artem,
>
> somewhat similarly to the C1E patch, while porting this one to our
> driver clone in Xen I've noticed that the code added here would not
> be reached in case the user specified a conflicting C1E-related
> command line option (which ought to be unrelated to C6 handling).
> In my port of the patch I've converted to
>
> /* Check if user prefers C1E over C1. */
> if (preferred_states_mask & BIT(2, U) &&
> /* Both can't be enabled, stick to the defaults. */
> !(preferred_states_mask & BIT(1, U))) {
> ...
> }
Hi, ack, I'll send a fix for this too.
prev parent reply other threads:[~2022-04-26 10:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-26 9:35 your patch "intel_idle: add core C6 optimization for SPR" Jan Beulich
2022-04-26 10:22 ` Artem Bityutskiy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=339d6f1495779ba402dab7f7940cdcae3bb94e71.camel@linux.intel.com \
--to=artem.bityutskiy@linux.intel.com \
--cc=jbeulich@suse.com \
--cc=linux-pm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).