From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18FAF2F99A9 for ; Mon, 15 Sep 2025 09:44:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757929493; cv=none; b=QAqsS5oGi7Z2x+crcCA6nT7/qzkR3pjPfMz/CTdCWnhguULAwvW7jv5Qd3Et9DLY2pP1fNCywLk6k8K6MpjGvj5fsdtwXYzkqCwLb5mnz0Uyviab5w/CV7bXgQxixcG35AKdIrnXERZqFoGEhQA2sR4Onp6ChFm/ZQsrYXj6Mdc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757929493; c=relaxed/simple; bh=v3RG+UICPkrVnxWKbeqHLBZe1IIHqbLgB0YYfEB2ieY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=GJNnKE7o2ZmcbGBGsYeNoeAKLpCFqk4HwYjw60iek9HPKiurE7m5eCxbsIxyTDE9U1aIZTGlC+8+uSmrns2NbV/d7OdwcjP5iNegNuPFviNNWKfXeKR761tyS7oDQdu2jv8nZlLCFKT0Ban+p6S5XpQJl1Tzs+o/kCSn2QLVipM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YTPLKp+Z; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YTPLKp+Z" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 58F8FvCO006003 for ; Mon, 15 Sep 2025 09:44:50 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= btUt09/JWFKx9VAylYCCOROw35FyhcxsxetmaKbojb8=; b=YTPLKp+ZUmN02Qpm MghxcspLw2YbFDu6hU6ii4k1CwK7ncmt1QMSTkMI8DTr0529ix5yhvUGgr0GMoWX 9flipKVbHTiw0HVoPSHidwIc6np4RzvmP1kGgCOKxF4n7jJsCpLuPOcD2oKOr4Yp FHl26H0Fj5fJzlV0h8YKme45jH34LA1/HQoxdzxOhoIGufGq8A1EG/4ioZGxvsa/ FmsS8WFHpJ48EVFbiwmSi7RNhztLFt2Vfh0lmHVlRI/VRDn6hQ6t/jjn0R8Mfv75 8M4BwleYkaTzJWkOhU+ANphqLOUZIbm6t1HGIVW9YgzeodzkW0JfBr4MOdzJx0L5 cEpIag== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4951snm8cc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Mon, 15 Sep 2025 09:44:50 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-261cec07f2dso12483125ad.1 for ; Mon, 15 Sep 2025 02:44:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757929489; x=1758534289; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=btUt09/JWFKx9VAylYCCOROw35FyhcxsxetmaKbojb8=; b=Gp1fd3p0a2XLDc574OlmOx7Rsh7M1cZGSK4Ik2cLqkHx8icaAXmmVAqpwQQCOntINi tMb+5Ku0DAt/afWZksg6OgFFCEPV8B2tzyVfPy0Zm/ODT3r08Wd0UypNnFDxh4O+hqHU j68CTHyw6c9yi+AYOoOAiP7Q+5D2rkfrnIErA6N2QOh31w3NPPaYnw8Vp2ePKcBRvAQd yh501dbQ/z7Q1Vm1+QRPnnEpgfWxkkk+cEhadLYTjSGHxtqQk4B1aJjqE1rOhewfI1R+ 6duF73MMt7nEZPVLEQLtnX8Rv1GqSyYI2ZpA83EyBkHeU3e+yrkYQqQdt5cv60pl9elj ktSg== X-Forwarded-Encrypted: i=1; AJvYcCWoBCu+lZeKaxq4qmqlcLhDK/3U1ft8WtyjsUM5R5oU8JVxQyjJ0iZyPlhucEv5yHGwxAjsfiGCCw==@vger.kernel.org X-Gm-Message-State: AOJu0YxiMee+wxe0RSBS9YJ+/RP6LAFgRocrVFL+dL3Amm+Vv09s6f9r ukKBLblNCSSgurFutKvFoBUQq50p1no1DgmVlQ/h0mj4lWvSIu6pRbTO7U87FDWZrEgf4b17M8p 1Xo5mx3xy65/Ju50l38VUhckw5+pQs7BZ+TJFEGU3iw3tbuaru+qYW3m/amb3jA== X-Gm-Gg: ASbGncuyEe+aUsiPoOyUQcDKlU4OBkcARodRx0RfENvf70IB0Y6Z4bvDHUnq23+wVh4 OKUqueSU+xgY9Oij22cIKrf3jByLV3tFdG1aiCAfDotoaY/IEarXYFBha3bApT0zrxfD4S4EbEx fSETU65pkZTLHNbj2nK11htWWe/cukISdVe7gdemXBxR22wCsADe0At/3SeI0Ugr3jmRP3Wk+hK yGx9mGRmyiX0kgOoI52k4z02GyC1Ag1FIrsLtvilPxe/ehnQGhqraQVOYIRpLDq0Kwt5tg3MPQI r8/4w+gfQLDeRc4zFXb4yesS5Alg+SLwk85yb8vZxXVy6kIzxIFZJHoCEiaNNz5LiWIS7CY/uTy R645FCCgbk6jRz8T+FzCJ2BG7ZkapFvo+8w== X-Received: by 2002:a17:903:185:b0:262:9ac8:6132 with SMTP id d9443c01a7336-2629ac88031mr71832015ad.19.1757929489312; Mon, 15 Sep 2025 02:44:49 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHB82jOSYdcixCfESlUwNeTpTC1N6ixEj5+ZgwzGyCnR/7UvipAKq3xTaZw7ZjJWJzsrOwUtg== X-Received: by 2002:a17:903:185:b0:262:9ac8:6132 with SMTP id d9443c01a7336-2629ac88031mr71831745ad.19.1757929488787; Mon, 15 Sep 2025 02:44:48 -0700 (PDT) Received: from [10.133.33.240] (tpe-colo-wan-fw-bordernet.qualcomm.com. [103.229.16.4]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2653fcb5b23sm34612035ad.56.2025.09.15.02.44.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Sep 2025 02:44:48 -0700 (PDT) Message-ID: <3559cbe4-b2e2-42d4-85ad-554258fc9dec@oss.qualcomm.com> Date: Mon, 15 Sep 2025 17:44:40 +0800 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 5/8] power: supply: qcom_battmgr: update compats for SM8550 and X1E80100 To: Stephan Gerhold Cc: Sebastian Reichel , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heikki Krogerus , Greg Kroah-Hartman , Dmitry Baryshkov , Bryan O'Donoghue , Konrad Dybcio , Subbaraman Narayanamurthy , David Collins , =?UTF-8?Q?Gy=C3=B6rgy_Kurucz?= , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, kernel@oss.qualcomm.com, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, Neil Armstrong References: <20250915-qcom_battmgr_update-v4-0-6f6464a41afe@oss.qualcomm.com> <20250915-qcom_battmgr_update-v4-5-6f6464a41afe@oss.qualcomm.com> Content-Language: en-US From: Fenglin Wu In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=JO87s9Kb c=1 sm=1 tr=0 ts=68c7e012 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=nuhDOHQX5FNHPW3J6Bj6AA==:17 a=IkcTkHD0fZMA:10 a=yJojWOMRYYMA:10 a=VwQbUJbxAAAA:8 a=KKAkSRfTAAAA:8 a=EUspDBNiAAAA:8 a=j-CFaJrOc8d7PKyLKvMA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 a=cvBusfyB2V15izCimMoJ:22 X-Proofpoint-ORIG-GUID: 7_YP8qrSVo3byYUUrO1R1sGM_D4ReEVS X-Proofpoint-GUID: 7_YP8qrSVo3byYUUrO1R1sGM_D4ReEVS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUwOTEzMDA0MCBTYWx0ZWRfXwE76ZBFf5dck qXPyWpHG65mHdzHzp8DiGgJKzNnT5PAsH79xzZhuR7+ZtCn0MIe2yR1V9UZUa4Ok0M2Tx5nRpa9 jgkVOsKoHgAiX+J4ZBh6VJwPfcoTECkxRKhCt+fufX0mM5+QogYL+ifHN24SbJ41kAYWEMhvWha WvbjZihsxA6/wd69+CQ9XoFIL5EPTQUYmVv5cUMo3bO1R1JaN58u0gqm8wYXqRI5oD9JDyEzGxX F9D3B5QLWXsXO2nOWkiOBLZb+l7mSBIaeuOBGPrb/XDCU06Nlu2ur8Xh+uKveCMqVkvBWW1iS+9 7RvaerJ18GZjbaXKM+CInYuFGafr1qsdW03idFRvy5l6UgOgl8ifTyPQ1Oth9JbC4JruRDPGF45 EZNodF3+ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1117,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-09-15_04,2025-09-12_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 phishscore=0 spamscore=0 clxscore=1015 adultscore=0 malwarescore=0 priorityscore=1501 bulkscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2507300000 definitions=main-2509130040 On 9/15/2025 5:02 PM, Stephan Gerhold wrote: > On Mon, Sep 15, 2025 at 04:49:57PM +0800, Fenglin Wu via B4 Relay wrote: >> From: Fenglin Wu >> >> Add variant definitions for SM8550 and X1E80100 platforms. Add a compat >> for SM8550 and update match data for X1E80100 specifically so that they >> could be handled differently in supporting charge control functionality. >> >> Tested-by: Neil Armstrong # on Thinkpad T14S OLED >> Signed-off-by: Fenglin Wu >> --- >> drivers/power/supply/qcom_battmgr.c | 7 +++++-- >> 1 file changed, 5 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/power/supply/qcom_battmgr.c b/drivers/power/supply/qcom_battmgr.c >> index 008e241e3eac3574a78459a2256e006e48c9f508..174d3f83ac2b070bb90c21a498686e91cc629ebe 100644 >> --- a/drivers/power/supply/qcom_battmgr.c >> +++ b/drivers/power/supply/qcom_battmgr.c >> @@ -19,8 +19,10 @@ >> #define BATTMGR_STRING_LEN 128 >> >> enum qcom_battmgr_variant { >> - QCOM_BATTMGR_SM8350, >> QCOM_BATTMGR_SC8280XP, >> + QCOM_BATTMGR_SM8350, >> + QCOM_BATTMGR_SM8550, >> + QCOM_BATTMGR_X1E80100, >> }; >> >> #define BATTMGR_BAT_STATUS 0x1 >> @@ -1333,7 +1335,8 @@ static void qcom_battmgr_pdr_notify(void *priv, int state) >> static const struct of_device_id qcom_battmgr_of_variants[] = { >> { .compatible = "qcom,sc8180x-pmic-glink", .data = (void *)QCOM_BATTMGR_SC8280XP }, >> { .compatible = "qcom,sc8280xp-pmic-glink", .data = (void *)QCOM_BATTMGR_SC8280XP }, >> - { .compatible = "qcom,x1e80100-pmic-glink", .data = (void *)QCOM_BATTMGR_SC8280XP }, >> + { .compatible = "qcom,sm8550-pmic-glink", .data = (void *)QCOM_BATTMGR_SM8550 }, >> + { .compatible = "qcom,x1e80100-pmic-glink", .data = (void *)QCOM_BATTMGR_X1E80100 }, >> /* Unmatched devices falls back to QCOM_BATTMGR_SM8350 */ >> {} >> }; > I think you need to squash this with "[PATCH 7/8] power: supply: > qcom_battmgr: Add charge control support", or move the modified checks > for > > if (battmgr->variant == QCOM_BATTMGR_SC8280XP || > battmgr->variant == QCOM_BATTMGR_X1E80100) { > > into this patch. > > With this patch right now, I would expect that your series is not > bisectable: The wrong code paths are chosen if you only apply this patch > because e.g. X1E doesn't use the QCOM_BATTMGR_SC8280XP code anymore. > > Thanks, > Stephan I see. I was making it this way to address the review comment from Bryan in patch v2 about separating the compats change. See here: https://lore.kernel.org/all/7f001134-e099-492d-8ce5-4122d83a3de3@linaro.org/ If I revise it according to your 2nd suggestion, would it conflict with Bryan's feedback?