From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7705C77B73 for ; Tue, 30 May 2023 15:47:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232526AbjE3Prn (ORCPT ); Tue, 30 May 2023 11:47:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38000 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232210AbjE3Prj (ORCPT ); Tue, 30 May 2023 11:47:39 -0400 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 60136131 for ; Tue, 30 May 2023 08:47:15 -0700 (PDT) Received: by mail-wr1-x42f.google.com with SMTP id ffacd0b85a97d-30aeee7c8a0so1511778f8f.1 for ; Tue, 30 May 2023 08:47:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685461633; x=1688053633; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=X98uEJIUr5N96PKhi+a99X85M9f95CxufPpRR6wZq8A=; b=I4GPQWEllzF6GBOexpjF+zqBiGkBryBgzrEJtXRHQddmLLIOOng95jwaUCgCr1tgsL Jv05YlGGBLV0dnEU2jx+6DUkVpHbZZepwRBsWcxCtgO8LoZjofiJopoMWOJYUc+vHkEQ 0nkVIfh2wmrheNx40RaXua8/vNVNYV3VLClb9m6E/Ib2FLzBWX3w9HnRDP2/WMrzrS8f v4h6Xo4rA+eN7dUYhsWR5dZNWvYr3wPUYkyCzlOkIvWmVKVA7aPpl5Uo/hMqOlL9W4Vv BdMCjM0CqmsjMAMQfh3IpccWhHSKKBIVBKD0aCHhWnL/8VqQTWkP4jpb17llwILviawK Yhdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685461633; x=1688053633; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=X98uEJIUr5N96PKhi+a99X85M9f95CxufPpRR6wZq8A=; b=jVdPQjNglxNoqhFaiykbMS817Vqtgu7PZ7q8eEBjzIWJvhQmke6n0XbXte4ZKINnZa mK2VU7Zt7eb3G7A4iHnrNBOw2w+UL9C9INXrxYIleySgdmalnOzTLHPvkgwzlhsz47AQ t8v7nzHKnJshtHHSONi93DtE+I27NEOTKa4+pj6cyZTud6gQkNfNJrL10IrqEO+GjZ3N P9NaJHu6xIIv8Wh0uQtziFnLgpXBoO/zY2oYQLkm8gO9N57h5k/YzBpp3l1OCXwMQdrm uL1Vtcdk5fiAOqp9p+FzXSowudZMnGX8KaIT+wCXI6BOu/XAM2y7WzZhV7N7pR4syIaf Rvng== X-Gm-Message-State: AC+VfDyk3wfZxhlF2atPyYc8iIIFGNyadBElcrzDP0WE8zy7pLksW/9Y 0TyTjRbDeQroeMrfAGKV7G3GRg== X-Google-Smtp-Source: ACHHUZ7srJ4pOnP/FvjZ38eh3SqEMIgReJFKmoPPE7Dt9i4SzWqtjk05iWZ0+SjI68fY+m6jsF8SOw== X-Received: by 2002:adf:f485:0:b0:30a:c681:fd2e with SMTP id l5-20020adff485000000b0030ac681fd2emr2350372wro.22.1685461633507; Tue, 30 May 2023 08:47:13 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:dd1c:e75b:56ba:6bf? ([2a05:6e02:1041:c10:dd1c:e75b:56ba:6bf]) by smtp.googlemail.com with ESMTPSA id d1-20020adfe881000000b0030631a599a0sm3735752wrm.24.2023.05.30.08.47.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 May 2023 08:47:13 -0700 (PDT) Message-ID: <35dea714-6a0f-4673-fd33-23644ea85d33@linaro.org> Date: Tue, 30 May 2023 17:47:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH] lvts_thermal.c: Fix error checking for debugfs_create_dir Content-Language: en-US To: Osama Muhammad , rafael@kernel.org, amitk@kernel.org, rui.zhang@intel.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, bchihi@baylibre.com, wenst@chromium.org Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230517160326.10732-1-osmtendev@gmail.com> From: Daniel Lezcano In-Reply-To: <20230517160326.10732-1-osmtendev@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 17/05/2023 18:03, Osama Muhammad wrote: > This patch fixes the error checking in lvts_thermal.c in > debugfs_create_dir. The correct way to check if an error occurred > is 'IS_ERR' inline function. We do no longer check debugfs functions return values. eg. https://www.spinics.net/lists/linux-spi/msg37903.html https://lore.kernel.org/lkml/2023052835-oxidant-doily-404f@gregkh/ > Signed-off-by: Osama Muhammad > --- > drivers/thermal/mediatek/lvts_thermal.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/mediatek/lvts_thermal.c b/drivers/thermal/mediatek/lvts_thermal.c > index d0a3f95b7884..61386be78fa0 100644 > --- a/drivers/thermal/mediatek/lvts_thermal.c > +++ b/drivers/thermal/mediatek/lvts_thermal.c > @@ -188,7 +188,7 @@ static int lvts_debugfs_init(struct device *dev, struct lvts_domain *lvts_td) > int i; > > lvts_td->dom_dentry = debugfs_create_dir(dev_name(dev), NULL); > - if (!lvts_td->dom_dentry) > + if (IS_ERR(lvts_td->dom_dentry)) > return 0; > > for (i = 0; i < lvts_td->num_lvts_ctrl; i++) { > @@ -197,7 +197,7 @@ static int lvts_debugfs_init(struct device *dev, struct lvts_domain *lvts_td) > > sprintf(name, "controller%d", i); > dentry = debugfs_create_dir(name, lvts_td->dom_dentry); > - if (!dentry) > + if (IS_ERR(dentry)) > continue; > > regset = devm_kzalloc(dev, sizeof(*regset), GFP_KERNEL); -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog