From: Thomas Renninger <trenn@suse.de>
To: Rafael Wysocki <rafael@kernel.org>
Cc: linux-pm@vger.kernel.org
Subject: [PATCH] x86: Do not override performance EPB MSR value on servers
Date: Mon, 08 Apr 2019 10:46:46 +0200 [thread overview]
Message-ID: <36183132.7cOCK0nhyl@house> (raw)
It is about this kernel message showing up on quite a lot servers:
[ 0.072652] ENERGY_PERF_BIAS: Set to 'normal', was 'performance'
[ 0.076003] ENERGY_PERF_BIAS: View and update with x86_energy_perf_policy(8)
With this patch the EPB value is not overridden anymore on systems
which expose themselves as appliance or enterprise server via ACPI
perferred profile variable.
Signed-off-by: trenn@suse.de
Index: perf_bias_acpi_server_only/arch/x86/kernel/cpu/intel_epb.c
===================================================================
--- perf_bias_acpi_server_only.orig/arch/x86/kernel/cpu/intel_epb.c 2019-04-05 14:43:04.280222577 +0200
+++ perf_bias_acpi_server_only/arch/x86/kernel/cpu/intel_epb.c 2019-04-08 10:01:26.029278425 +0200
@@ -19,6 +19,8 @@
#include <asm/cpufeature.h>
#include <asm/msr.h>
+#include <linux/acpi.h>
+
/**
* DOC: overview
*
@@ -89,7 +91,10 @@ static void intel_epb_restore(void)
* ('normal').
*/
val = epb & EPB_MASK;
- if (val == ENERGY_PERF_BIAS_PERFORMANCE) {
+ if (acpi_gbl_FADT.preferred_profile == PM_ENTERPRISE_SERVER ||
+ acpi_gbl_FADT.preferred_profile == PM_PERFORMANCE_SERVER) {
+ /* Keep performance setting on servers */
+ } else if (val == ENERGY_PERF_BIAS_PERFORMANCE) {
val = ENERGY_PERF_BIAS_NORMAL;
pr_warn_once("ENERGY_PERF_BIAS: Set to 'normal', was 'performance'\n");
}
next reply other threads:[~2019-04-08 8:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 8:46 Thomas Renninger [this message]
2019-04-08 8:51 ` [PATCH] x86: Do not override performance EPB MSR value on servers Thomas Renninger
2019-04-16 21:31 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36183132.7cOCK0nhyl@house \
--to=trenn@suse.de \
--cc=linux-pm@vger.kernel.org \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).