Re: [PATCH 00/10] pmdomain: Partial refactor, support modem and RTFF

[AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>]

Il 03/07/25 20:27, Nícolas F. R. A. Prado ha scritto:
> On Thu, 2025-07-03 at 13:02 +0200, AngeloGioacchino Del Regno wrote:
>> This series is a subset of [1], leaving out the Hardware Voter
>> specific
>> bits for MT8196 until the discussion around it reaches a conclusion.
> [..]
>> Compared to v1 in [1]:
>>   - Changed mediatek,bus-protection to access-controllers
>>     as suggested by Rob (thanks!)
>>   - Added commits to document #access-controller-cells on all of
>>     the access control providers
> [..]
>> [1]
>> https://lore.kernel.org/all/20250623120154.109429-1-angelogioacchino.delregno@collabora.com
>>
>> AngeloGioacchino Del Regno (10):
>>    dt-bindings: memory: mtk-smi: Document #access-controller-cells
>>    dt-bindings: clock: mediatek: Document #access-controller-cells
>>    dt-bindings: power: mediatek: Document access-controllers property
>>    pmdomain: mediatek: Refactor bus protection regmaps retrieval
>>    pmdomain: mediatek: Handle SoCs with inverted SRAM power-down bits
>>    pmdomain: mediatek: Move ctl sequences out of power_on/off
>> functions
>>    pmdomain: mediatek: Add support for modem power sequences
>>    pmdomain: mediatek: Add support for RTFF Hardware in MT8196/MT6991
>>    pmdomain: mediatek: Convert all SoCs to new style regmap retrieval
>>    arm64: dts: mediatek: Convert all SoCs to use access-controllers
> 
> As already pointed out by rob's bot you're missing adding the
> properties to
> 
> mediatek,mt8195-sys-clock.yaml
> mediatek,mt8188-sys-clock.yaml
> 
> on patch 2. But other than that, for the whole series (since the tag
> wasn't added from the previous version):
> 

Oh I did, trust me I did.
But then I forgot to squash the changes in the patch that I've sent.

This all means that I need more coffee: fixing that now (both the patches
and getting more coffee :-P).

Thanks btw!
Angelo

> Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
>