public inbox for linux-pm@vger.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Nishanth Menon <nm@ti.com>
Cc: linux-pm@vger.kernel.org,
	Rajagopal Venkat <rajagopal.venkat@linaro.org>,
	MyungJoo Ham <myungjoo.ham@samsung.com>,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
	Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [for-next PATCH 2/2] PM / devfreq: more documentation warning fixes next set
Date: Fri, 26 Oct 2012 02:05:18 +0200	[thread overview]
Message-ID: <3731897.oMofWLtvr4@vostro.rjw.lan> (raw)
In-Reply-To: <1351206614-23993-3-git-send-email-nm@ti.com>

On Thursday, October 25, 2012 06:10:14 PM Nishanth Menon wrote:
> commit cfd5194aecd08cd8fbfbf1534a0209b95bc6fcdf
> (PM / devfreq: Core updates to support devices which can idle)
> in Rafael's pm-devfreq-next branch on
> git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git
> 
> Patchworks: https://patchwork.kernel.org/patch/1545751/
> 
> introduced a kernel documentation warning:
> Warning(drivers/devfreq/devfreq.c:289): bad line: 		release its resources.
> 
> This is due to lack of '*' at documentation start messing
> up poor scripts/kernel-doc 's mind. I suggest squashing
> this to original commit given not-yet-upstream status :).
> 
> Cc: Rajagopal Venkat <rajagopal.venkat@linaro.org>
> Cc: MyungJoo Ham <myungjoo.ham@samsung.com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> 
> Signed-off-by: Nishanth Menon <nm@ti.com>

I fixed up the original patch in a slightly different way.

Thanks,
Rafael


> ---
>  drivers/devfreq/devfreq.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/devfreq/devfreq.c b/drivers/devfreq/devfreq.c
> index cdc3e2d..2f6ad6b 100644
> --- a/drivers/devfreq/devfreq.c
> +++ b/drivers/devfreq/devfreq.c
> @@ -286,7 +286,7 @@ static int devfreq_notifier_call(struct notifier_block *nb, unsigned long type,
>  
>  /**
>   * _remove_devfreq() - Remove devfreq from the devfreq list and
> -		release its resources.
> + *			release its resources.
>   * @devfreq:	the devfreq struct
>   * @skip:	skip calling device_unregister().
>   */
> 
-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

      reply	other threads:[~2012-10-26  0:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-25 23:10 [for-next PATCH 0/2] PM / devfreq: more documentation fixes Nishanth Menon
2012-10-25 23:10 ` [for-next PATCH 1/2] PM / devfreq: more documentation warning fixes Nishanth Menon
2012-10-26  0:05   ` Rafael J. Wysocki
2012-10-25 23:10 ` [for-next PATCH 2/2] PM / devfreq: more documentation warning fixes next set Nishanth Menon
2012-10-26  0:05   ` Rafael J. Wysocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3731897.oMofWLtvr4@vostro.rjw.lan \
    --to=rjw@sisk.pl \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=nm@ti.com \
    --cc=rafael.j.wysocki@intel.com \
    --cc=rajagopal.venkat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox