[PATCH 0/3] Minor fixes for tools/cpupower

[PATCH 0/3] Minor fixes for tools/cpupower

[malattia]

From: Mattia Dongili <malattia@linux.it>

Hi Thomas,

here's a handful of patches that I'm applying for the Debian packaging of
cpupower.
Nothing major like you'll see below, let me know if you want me to change
anything.

Thanks!

Mattia Dongili (3):
  warning: comparison of constant ‘-1’ with boolean expression is always
    false
  Fix cpupower manpages "NAME" section
  Honour user's LDFLAGS

 tools/power/cpupower/bench/Makefile                | 2 +-
 tools/power/cpupower/man/cpupower-frequency-info.1 | 2 +-
 tools/power/cpupower/man/cpupower-frequency-set.1  | 2 +-
 tools/power/cpupower/man/cpupower-idle-info.1      | 2 +-
 tools/power/cpupower/man/cpupower-idle-set.1       | 2 +-
 tools/power/cpupower/utils/helpers/topology.c      | 2 +-
 6 files changed, 6 insertions(+), 6 deletions(-)

-- 
2.7.0

[PATCH 1/3] warning: comparison of constant ‘-1’ with boolean expression is always false

[malattia]

From: Mattia Dongili <malattia@linux.it>

Signed-off-by: Mattia Dongili <malattia@linux.it>
---
 tools/power/cpupower/utils/helpers/topology.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/power/cpupower/utils/helpers/topology.c b/tools/power/cpupower/utils/helpers/topology.c
index 9cbb7fd..771ec60 100644
--- a/tools/power/cpupower/utils/helpers/topology.c
+++ b/tools/power/cpupower/utils/helpers/topology.c
@@ -106,7 +106,7 @@ int get_cpu_topology(struct cpupower_topology *cpu_top)
 			cpu_top->pkgs++;
 		}
 	}
-	if (!cpu_top->core_info[0].pkg == -1)
+	if (cpu_top->core_info[0].pkg != -1)
 		cpu_top->pkgs++;
 
 	/* Intel's cores count is not consecutively numbered, there may
-- 
2.7.0

[PATCH 2/3] Fix cpupower manpages "NAME" section

[malattia]

From: Mattia Dongili <malattia@linux.it>

The token before "-" should be the program name, no spaces allowed.
See man(7) and lexgrog(1).

Signed-off-by: Mattia Dongili <malattia@linux.it>
---
 tools/power/cpupower/man/cpupower-frequency-info.1 | 2 +-
 tools/power/cpupower/man/cpupower-frequency-set.1  | 2 +-
 tools/power/cpupower/man/cpupower-idle-info.1      | 2 +-
 tools/power/cpupower/man/cpupower-idle-set.1       | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/tools/power/cpupower/man/cpupower-frequency-info.1 b/tools/power/cpupower/man/cpupower-frequency-info.1
index 9c85a38..6aa8d23 100644
--- a/tools/power/cpupower/man/cpupower-frequency-info.1
+++ b/tools/power/cpupower/man/cpupower-frequency-info.1
@@ -1,7 +1,7 @@
 .TH "CPUPOWER\-FREQUENCY\-INFO" "1" "0.1" "" "cpupower Manual"
 .SH "NAME"
 .LP 
-cpupower frequency\-info \- Utility to retrieve cpufreq kernel information
+cpupower\-frequency\-info \- Utility to retrieve cpufreq kernel information
 .SH "SYNTAX"
 .LP 
 cpupower [ \-c cpulist ] frequency\-info [\fIoptions\fP]
diff --git a/tools/power/cpupower/man/cpupower-frequency-set.1 b/tools/power/cpupower/man/cpupower-frequency-set.1
index 3eacc8d..b505702 100644
--- a/tools/power/cpupower/man/cpupower-frequency-set.1
+++ b/tools/power/cpupower/man/cpupower-frequency-set.1
@@ -1,7 +1,7 @@
 .TH "CPUPOWER\-FREQUENCY\-SET" "1" "0.1" "" "cpupower Manual"
 .SH "NAME"
 .LP 
-cpupower frequency\-set \- A small tool which allows to modify cpufreq settings.
+cpupower\-frequency\-set \- A small tool which allows to modify cpufreq settings.
 .SH "SYNTAX"
 .LP 
 cpupower [ \-c cpu ] frequency\-set [\fIoptions\fP]
diff --git a/tools/power/cpupower/man/cpupower-idle-info.1 b/tools/power/cpupower/man/cpupower-idle-info.1
index 7b3646a..80a1311 100644
--- a/tools/power/cpupower/man/cpupower-idle-info.1
+++ b/tools/power/cpupower/man/cpupower-idle-info.1
@@ -1,7 +1,7 @@
 .TH "CPUPOWER-IDLE-INFO" "1" "0.1" "" "cpupower Manual"
 .SH "NAME"
 .LP
-cpupower idle\-info \- Utility to retrieve cpu idle kernel information
+cpupower\-idle\-info \- Utility to retrieve cpu idle kernel information
 .SH "SYNTAX"
 .LP
 cpupower [ \-c cpulist ] idle\-info [\fIoptions\fP]
diff --git a/tools/power/cpupower/man/cpupower-idle-set.1 b/tools/power/cpupower/man/cpupower-idle-set.1
index 580c4e3..21916cf 100644
--- a/tools/power/cpupower/man/cpupower-idle-set.1
+++ b/tools/power/cpupower/man/cpupower-idle-set.1
@@ -1,7 +1,7 @@
 .TH "CPUPOWER-IDLE-SET" "1" "0.1" "" "cpupower Manual"
 .SH "NAME"
 .LP
-cpupower idle\-set \- Utility to set cpu idle state specific kernel options
+cpupower\-idle\-set \- Utility to set cpu idle state specific kernel options
 .SH "SYNTAX"
 .LP
 cpupower [ \-c cpulist ] idle\-info [\fIoptions\fP]
-- 
2.7.0

[PATCH 3/3] Honour user's LDFLAGS

[malattia]

From: Mattia Dongili <malattia@linux.it>

Signed-off-by: Mattia Dongili <malattia@linux.it>
---
 tools/power/cpupower/bench/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/power/cpupower/bench/Makefile b/tools/power/cpupower/bench/Makefile
index 7ec7021..5445c03 100644
--- a/tools/power/cpupower/bench/Makefile
+++ b/tools/power/cpupower/bench/Makefile
@@ -16,7 +16,7 @@ $(OUTPUT)%.o : %.c
 
 $(OUTPUT)cpufreq-bench: $(OBJS)
 	$(ECHO) "  CC      " $@
-	$(QUIET) $(CC) -o $@ $(CFLAGS) $(OBJS) $(LIBS)
+	$(QUIET) $(CC) -o $@ $(CFLAGS) $(LDFLAGS) $(OBJS) $(LIBS)
 
 all: $(OUTPUT)cpufreq-bench
 
-- 
2.7.0

Re: [PATCH 0/3] Minor fixes for tools/cpupower

[Thomas Renninger]

On Wednesday, March 16, 2016 07:13:05 AM malattia@linux.it wrote:
> From: Mattia Dongili <malattia@linux.it>
> 
> Hi Thomas,
> 
> here's a handful of patches that I'm applying for the Debian packaging of
> cpupower.
> Nothing major like you'll see below, let me know if you want me to change
> anything.

Thanks!

I have a bigger change pending.
I'll already add your patches there and will repost alltogether.
This will still take some days, but as there is no urgent fix,
that should be fine.

Thanks again,

     Thomas