From: Arnd Bergmann <arnd@arndb.de>
To: Sebastian Reichel <sre@kernel.org>
Cc: Stephen Boyd <sboyd@codeaurora.org>,
Dmitry Eremin-Solenikov <dbaryshkov@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Courtney Cavin <courtney.cavin@sonymobile.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: qcom-smbb: add extcon dependency
Date: Wed, 29 Jun 2016 23:16:09 +0200 [thread overview]
Message-ID: <3941061.eCNkMs7lBz@wuerfel> (raw)
In-Reply-To: <20160629210958.GB15422@earth>
On Wednesday, June 29, 2016 11:09:58 PM CEST Sebastian Reichel wrote:
> On Wed, Jun 29, 2016 at 11:10:34AM -0700, Stephen Boyd wrote:
> > On 06/29/2016 07:38 AM, Sebastian Reichel wrote:
> > > On Wed, Jun 29, 2016 at 04:30:02PM +0200, Arnd Bergmann wrote:
> > >> Building the smbb driver without extcon results in a link failure:
> > >>
> > >> drivers/power/built-in.o: In function `smbb_usb_valid_handler':
> > >> :(.text+0x3190): undefined reference to `extcon_set_cable_state_'
> > >> drivers/power/built-in.o: In function `smbb_charger_probe':
> > >> :(.text+0x3880): undefined reference to `devm_extcon_dev_allocate'
> > >> :(.text+0x3898): undefined reference to `devm_extcon_dev_register'
> > >>
> > >> This adds a Kconfig dependency.
> > >>
> > >> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> > >> Fixes: 56d7df8716b2 ("power: Add Qualcomm SMBB driver")
> >
> > extcon use was only recently introduced so this should be
> >
> > Fixes: 0b7fe26ae602 ("power: qcom_smbb: Make an extcon for usb cable
> > detection")
>
> Right, I didn't notice the Fixes line is wrong. Since I will have to
> rebase now, I will just squash this into 0b7fe26ae602.
Ok, thanks and sorry for the mixup, I must have pasted the wrong line.
Arnd
prev parent reply other threads:[~2016-06-29 21:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-29 14:30 [PATCH] power: qcom-smbb: add extcon dependency Arnd Bergmann
2016-06-29 14:38 ` Sebastian Reichel
2016-06-29 18:10 ` Stephen Boyd
2016-06-29 21:09 ` Sebastian Reichel
2016-06-29 21:16 ` Arnd Bergmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3941061.eCNkMs7lBz@wuerfel \
--to=arnd@arndb.de \
--cc=courtney.cavin@sonymobile.com \
--cc=dbaryshkov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sboyd@codeaurora.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox