Re: [PATCH v8 05/10] pmdomain: samsung: convert to using regmap

Marek Szyprowski
2026-03-19T15:57:50Z

On 19.03.2026 12:58, André Draszik wrote:
> On Thu, 2026-03-19 at 11:29 +0100, Marek Szyprowski wrote:
>> On 19.03.2026 11:13, Ulf Hansson wrote:
>>> As a follow-up patch on top, please consider converting the open-coded
>>> polling loop above into a readx_poll_timeout_atomic().
>> This has been tried and it doesn't work in all cases required for power
>> domain driver:
>>
>> https://lore.kernel.org/all/5c19e4ef-c4fd-4bf5-88b3-46c86751b14e@samsung.com/
>>
>> Probably a comment about that could be added directly to this code to
>> avoid such conversion and breakage in the future.
> I am planning to revisit this in the future and am hoping that we can
> figure out what goes wrong when using regmap_read_poll_timeout().
>
> Hopefully such a comment would only be short-lived, so maybe not really
> worth it? I can add it, though, if you prefer.

Well, I think I've already pointed what goes wrong with
regmap_read_poll_timeout() in the above mentioned thread. You would need
to use regmap_read_poll_timeout_atomic() and modify it the same way as
commit 7349a69cf312 did for read_poll_timeout_atomic().

Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland