From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA2D62D3220; Fri, 5 Sep 2025 06:59:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757055574; cv=none; b=QZwVEZNUcswm/65YmNIEioO3Y6FDMsGXXMlpAR1jX7wAyiqVybHPtlK1aiWLHFk1C6U1EbgzwwzEh3NWbXJzVsK05UmSgM02ExkVfZyoxFXBC8rrfS6uz92DjQZKm24V71cQJDBcbd7Oefk/7VOzgk4Fm4hzOcuHA9fYgdkBFZ0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1757055574; c=relaxed/simple; bh=cugq+qw3GpO8v3/zvxw4Zv8vTWDCt+fAotQhmHLxXiY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=aC4mLq6uyIwYRNcECVcCFv+5cY70BHuBRQ7jSIuTTeJC1hKe1hzg4kwurfUiMg5anQtS9L6ixAm3atLLAl7YVfCMofAJnC8bICyAylZV5YNE8imjyp41Mw7UwTWZ6RbYqtTNKeQqfwqr6xGUlI6r4JWW7tzeCGQchD7oSb9aEgk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=CF4binMN; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="CF4binMN" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7C8CC4CEF1; Fri, 5 Sep 2025 06:59:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1757055574; bh=cugq+qw3GpO8v3/zvxw4Zv8vTWDCt+fAotQhmHLxXiY=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=CF4binMNIxiWGtuuQhlwzvCc8J+tQLefHXAmP/4jLna/lyTqrOrP/MM+f/iZsI3Xg 8Ns6FSBRCjnyqRr3EllKTVhjAGqUGoepfpf5wB0Bh0nWrIx4P62B4A4cYZV/1ahs9X 7EjbQ7iUYVhfHGLHkbr8LqwA3CdK670OU0aiogzMt+kpNmF7x1kJDXmTMl1qsI+6wz 7lpajlijr7zG9v8ybLc4stzG1Z0h2yzN10V+hpWFJogtvX97f3FPgwjEgykRpIYZjq m6VXZtH592HS4jrN6unhF6tLxKDBBTg5uHTLVKEEWDPB6bbaGkQz8qBWTYKZsZA9f/ 40aNz3qwrTpuw== Message-ID: <3c463028-65b2-462e-b933-9ccb3fb37e0e@kernel.org> Date: Fri, 5 Sep 2025 08:59:29 +0200 Precedence: bulk X-Mailing-List: linux-pm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/8] memory: tegra210: Support interconnect framework To: Aaron Kling Cc: Rob Herring , Conor Dooley , Thierry Reding , Jonathan Hunter , Krzysztof Kozlowski , MyungJoo Ham , Kyungmin Park , Chanwoo Choi , Dmitry Osipenko , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org References: <20250903-t210-actmon-v2-0-e0d534d4f8ea@gmail.com> <20250903-t210-actmon-v2-5-e0d534d4f8ea@gmail.com> <20250904-aloof-cow-of-speed-ad5fe5@kuoka> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 04/09/2025 19:28, Aaron Kling wrote: >>> + >>> +static int tegra_emc_opp_table_init(struct tegra210_emc *emc) >>> +{ >>> + u32 hw_version = BIT(tegra_sku_info.soc_speedo_id); >>> + struct dev_pm_opp *opp; >>> + unsigned long rate; >>> + int opp_token, err, max_opps, i; >>> + >>> + err = dev_pm_opp_set_supported_hw(emc->dev, &hw_version, 1); >>> + if (err < 0) { >>> + dev_err(emc->dev, "failed to set OPP supported HW: %d\n", err); >>> + return err; >>> + } >>> + opp_token = err; >>> + >>> + err = dev_pm_opp_of_add_table(emc->dev); >>> + if (err) { >>> + if (err == -ENODEV) >>> + dev_err(emc->dev, "OPP table not found, please update your device tree\n"); >> >> So this looks like the actual ABI break. > > Okay, so let's discuss this. For reference, I based this patch off the > tegra124 change [0], which also caused an abi break. I know past That was almost 5 years ago and we also got stricter what we require in the commit msg. It's also documented in writing bindings. > changes don't justify current mistakes, but this is the context. This > series adds all new required dt properties to the arch common dtsi, so > any newly compiled dtb will work. Any old dtb with a new kernel would > fail to probe, however. I think it would be safe to just skip the That's the ABI break. > interconnect init if the opp table init returns ENODEV, then let probe > succeed, but I would have to verify that. Do I need to do that and > drop the new requires from the binding? The best would be yes, make it optional in the binding as well. Best regards, Krzysztof