From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C31FFC4320A for ; Tue, 31 Aug 2021 08:54:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AA522604D7 for ; Tue, 31 Aug 2021 08:54:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240452AbhHaIzk (ORCPT ); Tue, 31 Aug 2021 04:55:40 -0400 Received: from foss.arm.com ([217.140.110.172]:52410 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240380AbhHaIzk (ORCPT ); Tue, 31 Aug 2021 04:55:40 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 803EB1FB; Tue, 31 Aug 2021 01:54:44 -0700 (PDT) Received: from [192.168.178.6] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1FE993F5A1; Tue, 31 Aug 2021 01:54:40 -0700 (PDT) Subject: Re: [PATCH V3 0/9] Add callback to register with energy model To: Viresh Kumar , Rafael Wysocki , Vincent Donnefort , lukasz.luba@arm.com, Quentin Perret , Andy Gross , Bjorn Andersson , Cristian Marussi , Fabio Estevam , Kevin Hilman , Matthias Brugger , NXP Linux Team , Pengutronix Kernel Team , Sascha Hauer , Shawn Guo , Sudeep Holla Cc: linux-pm@vger.kernel.org, Vincent Guittot , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-omap@vger.kernel.org References: From: Dietmar Eggemann Message-ID: <3d5b823f-259a-8fc6-27ab-2a5d5df89844@arm.com> Date: Tue, 31 Aug 2021 10:54:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 12/08/2021 06:35, Viresh Kumar wrote: > Many cpufreq drivers register with the energy model for each policy and > do exactly the same thing. Follow the footsteps of thermal-cooling, to > get it done from the cpufreq core itself. > > Provide a new callback, which will be called, if present, by the cpufreq > core at the right moment (more on that in the code's comment). Also > provide a generic implementation that uses dev_pm_opp_of_register_em(). > > This also allows us to register with the EM at a later point of time, > compared to ->init(), from where the EM core can access cpufreq policy > directly using cpufreq_cpu_get() type of helpers and perform other work, > like marking few frequencies inefficient, this will be done separately. > > This is build/boot tested by the bot for a couple of boards. > > https://gitlab.com/vireshk/pmko/-/pipelines/351965580 > > FWIW, I have queued up the series for linux-next to get more testing, but your > reviews are welcome. Thanks. > > V2->V3: > - Drop the auto-register part from all logs, this isn't called auto registration > anymore. > - Call register_em() only for new policies. > - Update scmi driver to register with EM only when required. > - Add Rby tags. LGTM. Tested on TC2 (vexpress-spc), Juno-r0 (scpi-cpufreq and scmi). Reviewed-by: Dietmar Eggemann