From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64A53CCA482 for ; Fri, 24 Jun 2022 10:05:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230431AbiFXKFg (ORCPT ); Fri, 24 Jun 2022 06:05:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49920 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230323AbiFXKFf (ORCPT ); Fri, 24 Jun 2022 06:05:35 -0400 Received: from mail-ed1-x532.google.com (mail-ed1-x532.google.com [IPv6:2a00:1450:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 631F06F780 for ; Fri, 24 Jun 2022 03:05:32 -0700 (PDT) Received: by mail-ed1-x532.google.com with SMTP id c65so2739945edf.4 for ; Fri, 24 Jun 2022 03:05:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=vT/m4Tsbd8efm3hJuxbD4cqK3IhssJw6vrlwpvAa4b0=; b=UakZorhpkKl5ALlrNDpU9jBka/t7cECYvhFhzj+zFDtScfLk4YgEeyOfo8DFWO15pX acdIkWuEWtfqRecdqSXnO6RuScer29NgRYGQi6w2b3AevrhtqGV4PyqFV7a7iCvnY+sz II+sI7Sn35mv1L55DCt78FSqkyddA8r13goTTMrWr2P/zMq2OgymKpeV3LuqffvPPV0c gxsfp8H+kd9rdXlBWi6P+ycPP0PrQm9hqjXMR9R6ZkONPE3AWNqGgVc8xBeaoZoOqwa/ m2oC2JqyOnyHMotqqqMJK9RbyXsMfJD8qnSgV+hHzIj49dnboun3MfivtpYLc97L4VwU ge9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=vT/m4Tsbd8efm3hJuxbD4cqK3IhssJw6vrlwpvAa4b0=; b=lu2XLT8MxhPniYOf423w/T6hV3HtSWrLg/rHXUkha2Prn2oLMD6W23E32Ee5VYsBZQ mpk+6pAF3kELiiK7XrBWkXBxXcN5yjS/6OkQQa/YMFMTXKUYmbQVOBP56F3dJfSX6bli 5cs+1vvk6iZLT2+D2tDq19uxlpIjaJk3x3p+nOisujd4uJcyACflXy7ZvxJyNrzXFmIt jI/GiVNEhobTqCPeG8F3XsDEvrhyS+AscBsQyD32fV1A1xU8WEVzugplCjhpfAfNsKkh PMLuc76YbVsZZUP9A2zXvTew+3SCAwZIm1SXsk0EBe8daDfXR81U8j9pmQEv7Ouc71Gg HgHQ== X-Gm-Message-State: AJIora/o5y7n7IEyZGwBwxgNLWoY4ZOddhyrXQdR8vJB7wOZt3vmSVrD RdY2f44Ev6gZurIgp9fxuPgjlw== X-Google-Smtp-Source: AGRyM1uaOjXwhg5I8X289/Baaww5kJzfDpSLWW9kaNvjsU7L/qEOz6gkCuSWZSjiQSEuXlbmDZ+EFQ== X-Received: by 2002:a05:6402:11cb:b0:435:75ed:f12f with SMTP id j11-20020a05640211cb00b0043575edf12fmr16487090edw.305.1656065130928; Fri, 24 Jun 2022 03:05:30 -0700 (PDT) Received: from [192.168.0.234] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id z8-20020a170906434800b00722f2a0944fsm845519ejm.107.2022.06.24.03.05.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jun 2022 03:05:30 -0700 (PDT) Message-ID: <3db6ca83-1fa0-0a6d-5af9-4dd0ba38b9a6@linaro.org> Date: Fri, 24 Jun 2022 12:05:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.10.0 Subject: Re: [PATCH v5 02/14] dt-bindings: clk: imx: Add fsl,scu-clk yaml file Content-Language: en-US To: Viorel Suman , Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Dmitry Torokhov , Srinivas Kandagatla , Dong Aisheng , Fabio Estevam , Shawn Guo , Stefan Agner , Pengutronix Kernel Team , Linus Walleij , Alessandro Zummo , Alexandre Belloni , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Wim Van Sebroeck , Guenter Roeck , Sascha Hauer , NXP Linux Team , Abel Vesa , Oliver Graute , Mirela Rabulea , Peng Fan , Liu Ying , Ming Qian , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-input@vger.kernel.org, linux-gpio@vger.kernel.org, linux-rtc@vger.kernel.org, linux-pm@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Abel Vesa References: <20220616164303.790379-1-viorel.suman@nxp.com> <20220616164303.790379-3-viorel.suman@nxp.com> From: Krzysztof Kozlowski In-Reply-To: <20220616164303.790379-3-viorel.suman@nxp.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 16/06/2022 18:42, Viorel Suman wrote: > From: Abel Vesa > > In order to replace the fsl,scu txt file from bindings/arm/freescale, > we need to split it between the right subsystems. This patch documents > separately the 'clock' child node of the SCU main node. > > Signed-off-by: Abel Vesa > Signed-off-by: Viorel Suman > --- > .../bindings/clock/fsl,scu-clk.yaml | 58 +++++++++++++++++++ > 1 file changed, 58 insertions(+) > create mode 100644 Documentation/devicetree/bindings/clock/fsl,scu-clk.yaml > > diff --git a/Documentation/devicetree/bindings/clock/fsl,scu-clk.yaml b/Documentation/devicetree/bindings/clock/fsl,scu-clk.yaml > new file mode 100644 > index 000000000000..8b59758eee4a > --- /dev/null > +++ b/Documentation/devicetree/bindings/clock/fsl,scu-clk.yaml > @@ -0,0 +1,58 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/clock/fsl,scu-clk.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: i.MX SCU Client Device Node - Clock bindings based on SCU Message Protocol > + > +maintainers: > + - Abel Vesa > + > +description: i.MX SCU Client Device Node > + Client nodes are maintained as children of the relevant IMX-SCU device node. > + This binding uses the common clock binding. > + (Documentation/devicetree/bindings/clock/clock-bindings.txt) > + The clock consumer should specify the desired clock by having the clock > + ID in its "clocks" phandle cell. > + See the full list of clock IDs from > + include/dt-bindings/clock/imx8qxp-clock.h > + > +properties: > + compatible: > + items: > + - enum: > + - fsl,imx8dxl-clk > + - fsl,imx8qm-clk > + - fsl,imx8qxp-clk > + - const: fsl,scu-clk > + > + '#clock-cells': > + const: 2 > + > + clocks: > + items: > + - description: XTAL 32KHz > + - description: XTAL 24MHz > + minItems: 1 > + > + clock-names: > + items: > + enum: > + - xtal_32KHz > + - xtal_24Mhz No, this does not match your clocks property and allow any combination. Are you sure that hardware can have entirely different clocks connected? > + minItems: 1 > + maxItems: 2 > + > +required: > + - compatible > + - '#clock-cells' Why the clocks are not required? > + > +additionalProperties: false > + > +examples: > + - | > + clock-controller { > + compatible = "fsl,imx8qxp-clk", "fsl,scu-clk"; Wrong indentation. 4 spaces for DTS example. > + #clock-cells = <2>; > + }; Best regards, Krzysztof