From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48D62C77B6D for ; Thu, 30 Mar 2023 21:14:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229484AbjC3VN4 (ORCPT ); Thu, 30 Mar 2023 17:13:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229518AbjC3VNt (ORCPT ); Thu, 30 Mar 2023 17:13:49 -0400 Received: from mail-wm1-x329.google.com (mail-wm1-x329.google.com [IPv6:2a00:1450:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EBB48E194 for ; Thu, 30 Mar 2023 14:13:47 -0700 (PDT) Received: by mail-wm1-x329.google.com with SMTP id l15-20020a05600c4f0f00b003ef6d684102so8846262wmq.3 for ; Thu, 30 Mar 2023 14:13:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680210826; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xYJ7UCsO7F5A7GpXsRX+DRI450uHDvtid0ji5HrtybQ=; b=TIOuMwmc+8BXKmxoFMV87oMywgcK9gX6n7HKYcIRNQi1qfrrh4vWceK117IiKCBCRl /C3RSxWGKAi3MXa9Zq0Ijm8ydELmAe76IJ5Bc+7xX6iqj+yXUxbvQh5MDAo6wjVgSvmh sHjDwMm2UP/yiZcOdJekZwww5sxrrPH4jCobUFUm36ZarX3aQ7fG6HfXSr1PkrcXd1ZM tfYKHp4DmRrkytK3zstli4lpNVTtBicxQHPnEyi5fOP5UhfS4lTAv9rHOzx1aDSbxxGX 22zMxMyHp1Jtp6+NPKJKKF6Emzw89VShKFj44OeI+CqNUIb7vaOlUYZJIzYL07KOC3Wx cJMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680210826; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xYJ7UCsO7F5A7GpXsRX+DRI450uHDvtid0ji5HrtybQ=; b=tBh6eVnzMxsA5HUj37O9LsrNjjcqpBu712tScNxi2wBom2bHlxKmHRS1F0xsmaQqf/ HvBMtF10Hs+DUsdK7a1m0SIsTzl/4UnNhoqrHpZ5yjatBIj+tyGiTx7MXS6SXKAleD/l HaSiHfYoO7ewS/FOBOvb6btZJKohK58Z3JFjXBDPU4Au5K4unUsCt4EV2UJB2pdW9mBo i3pA/mDjfp7qFiHGkLCxD+S+v6A2ZWOt3/EeLTH3Jj2oBs0RRvvcwcthaFySGXa1xWn1 mi1byM3gxGCkae7u+FTh4Be8+BlgmVmnQNnyirF7ePCVJ4wJBbAs6Bp/jBPm4Oynkl+N KDwg== X-Gm-Message-State: AO0yUKUmnziKa+Wg0hdZBK1h9e5LFjZ7C7erpMAiwWfFMc217eQZGmCO 3SDy7K7MgkcVr0D5KVK2reCKvA== X-Google-Smtp-Source: AK7set/RF9lEynbBcbIUXZaNxVwOwSMZ+BeXGxObXH50aHsfuSIlJxKeFMBWVKZjvnItHxnhRNWXzA== X-Received: by 2002:a7b:c381:0:b0:3ed:4627:ed09 with SMTP id s1-20020a7bc381000000b003ed4627ed09mr18481456wmj.28.1680210826323; Thu, 30 Mar 2023 14:13:46 -0700 (PDT) Received: from ?IPV6:2a05:6e02:1041:c10:17ff:909e:1b73:8366? ([2a05:6e02:1041:c10:17ff:909e:1b73:8366]) by smtp.googlemail.com with ESMTPSA id hg13-20020a05600c538d00b003ed793d9de0sm11413067wmb.1.2023.03.30.14.13.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Mar 2023 14:13:45 -0700 (PDT) Message-ID: <3e9154df-bae4-23a6-7c5d-d42477800b19@linaro.org> Date: Thu, 30 Mar 2023 23:13:45 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [RESEND] [PATCHv3 4/7] thermal: rockchip: Simplify channel id logic Content-Language: en-US To: =?UTF-8?Q?Heiko_St=c3=bcbner?= , Sebastian Reichel Cc: "Rafael J. Wysocki" , Amit Kucheria , Zhang Rui , Rob Herring , Krzysztof Kozlowski , linux-pm@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@collabora.com References: <20230308112253.15659-1-sebastian.reichel@collabora.com> <2066924.KlZ2vcFHjT@diego> From: Daniel Lezcano In-Reply-To: <2066924.KlZ2vcFHjT@diego> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On 30/03/2023 19:07, Heiko Stübner wrote: > Am Donnerstag, 16. März 2023, 11:05:25 CEST schrieb Daniel Lezcano: >> >> Hi Heiko, >> >> On 08/03/2023 19:42, Sebastian Reichel wrote: >>> Hi Daniel, >>> >>> On Wed, Mar 08, 2023 at 07:13:22PM +0100, Daniel Lezcano wrote: >>>> On 08/03/2023 12:22, Sebastian Reichel wrote: >>>>> Replace the channel ID lookup table by a simple offset, since >>>>> the channel IDs are consecutive. >>>>> >>>>> Signed-off-by: Sebastian Reichel >>>> >>>> As all the other patches are reviewed by Heiko, is the tag missing here? >>> >>> Heiko was not happy with this in PATCHv2, when he reviewed most >>> of the patches: >>> >>> https://lore.kernel.org/all/3601039.e9J7NaK4W3@phil/ >>> >>> I replied, but never got a response, so I kept it as is: >>> >>> https://lore.kernel.org/all/20221206170232.xsm4kcbfwrmlrriw@mercury.elektranox.org/ >>> >>> FWIW it is essential for the series and cannot be dropped, because >>> RK3588 has more than 2 channels. >> >> Do you have a suggestion to improve the proposed change ? > > I guess it's fine after all. > > Sebastian's response makes sense and there is not really a reason to keep > infrastructure around for a hypothetical case that may never happen. > > If that really changes with some SoC in the far future we can always > re-evaluate. Thanks, I've added your tag -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog