Re: [PATCH v3 10/12] thermal/of: Store the trips in the thermal zone

Lukasz Luba
2022-07-04T08:38:56Z

On 7/3/22 19:30, Daniel Lezcano wrote:
> As the thermal zone contains the trip point, we can store them
> directly in the when registering the thermal zone. That will allow

'directly in the' is there something missing?
maybe: in the thermal zone when registering

> another step forward to remove the duplicate thermal zone structure we
> find in the thermal_of code.
>
> Cc: Alexandre Bailon <abailon@baylibre.com>
> Cc: Kevin Hilman <khilman@baylibre.com>
> Cc; Eduardo Valentin <eduval@amazon.com>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linexp.org>
> ---
> drivers/thermal/thermal_of.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/thermal/thermal_of.c b/drivers/thermal/thermal_of.c
> index 16eb18c24430..16b6b90a2390 100644
> --- a/drivers/thermal/thermal_of.c
> +++ b/drivers/thermal/thermal_of.c
> @@ -1117,11 +1117,9 @@ int __init of_parse_thermal_zones(void)
> tzp->slope = tz->slope;
> tzp->offset = tz->offset;
>
> - zone = thermal_zone_device_register(child->name, tz->ntrips,
> - mask, tz,
> - ops, tzp,
> - tz->passive_delay,
> - tz->polling_delay);
> + zone = thermal_zone_device_register_with_trips(child->name, tz->trips, tz->ntrips,
> + mask, tz, ops, tzp, tz->passive_delay,
> + tz->polling_delay);
> if (IS_ERR(zone)) {
> pr_err("Failed to build %pOFn zone %ld\n", child,
> PTR_ERR(zone));

'num_trips' ?
Apart from that LGTM