Re: [PATCH v3 05/12] thermal/core: Remove unneeded EXPORT_SYMBOLS

Rafael J. Wysocki
2022-07-05T14:22:07Z

On Tue, Jul 5, 2022 at 9:30 AM Lukasz Luba <lukasz.luba@arm.com> wrote:
>
>
>
> On 7/4/22 22:14, Daniel Lezcano wrote:
> > On 04/07/2022 09:35, Lukasz Luba wrote:
> >> Hi Daniel,
> >>
> >> (+Todd and Wei on CC)
> >>
> >>
> >> On 7/3/22 19:30, Daniel Lezcano wrote:
> >
> > [ ... ]
> >
> >>> }
> >>> -EXPORT_SYMBOL(get_tz_trend);
> >
> > [ ... ]
> >
> >>> }
> >>> -EXPORT_SYMBOL(thermal_cdev_update);
> >>
> >> I wouldn't remove that export. I can see in my Pixel6 modules dir, that
> >> it's called in 7 places.
> >>
> >> I assume that in Android world this is common use.
> >
> > It is not possible to do changes taking into consideration out of tree
> > code. Moreover there is logically no good reason to use the
> > thermal_cdev_update() function from outside of the thermal core code.
> >
>
> I see your point which is 'upstream'. On the other hand the mostly
> deployed kernel is in Android devices and that brings a lot to the
> community.
>
> This symbol might also be used by other distros which might have
> modules for some accelerators, which also support tricky cooling.
>
> I would keep it as is...

I think that the long-term goal is to reduce differences between the
mainline kernel and Android. From this angle, it would be good if
Android was aware that the mainline did stuff especially for them and
making them carry an extra patch would go a long way towards that
purpose.