Re: [PATCH v3 05/12] thermal/core: Remove unneeded EXPORT_SYMBOLS

Daniel Lezcano
2022-07-04T21:14:21Z

On 04/07/2022 09:35, Lukasz Luba wrote:
> Hi Daniel,
>
> (+Todd and Wei on CC)
>
>
> On 7/3/22 19:30, Daniel Lezcano wrote:

[ ... ]

>>   }
>> -EXPORT_SYMBOL(get_tz_trend);

[ ... ]

>>   }
>> -EXPORT_SYMBOL(thermal_cdev_update);
>
> I wouldn't remove that export. I can see in my Pixel6 modules dir, that
> it's called in 7 places.
>
> I assume that in Android world this is common use.

It is not possible to do changes taking into consideration out of tree
code. Moreover there is logically no good reason to use the
thermal_cdev_update() function from outside of the thermal core code.